31 Oct
2022
31 Oct
'22
11:16 a.m.
On Mon Oct 31 11:16:43 2022 +0000, Jactry Zeng wrote:
Hi Liande, Please format the author name of the patch, capitalizing the initialize character of the first name and the last name. And I think the commit message is improvable, please read https://wiki.winehq.org/Submitting_Patches#The_commit_message for more information. I'm not an expert on VC runtime, just trying to point out some generic issues. Thanks for your contribution. :)
The patch looks OK but commit message might be improved. I don't know what crash do you have in mind (is it even possible to see it without modifying wine source?). How about changing it to `msvcp90: Make _Condition_variable_* function pointers static.`?