Re: [PATCH v3 0/2] MR583: vkd3d-shader/dxil: SRV/UAV support part 2.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> -
>        return;
> -
>    }
> -
>    else if (write_mask & (write_mask + 1))
> -
>    {
> -
>        FIXME("Unhandled write mask %#x.\n", write_mask);
> -
>        vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>                "Write mask %#x for a raw/structured buffer load operation is unhandled.", write_mask);
> -
>    }
> -
>    component_count = vsir_write_mask_component_count(write_mask);
> - }
> -
> - instruction_init_with_resource(ins, raw ? VKD3DSIH_LD_RAW : VKD3DSIH_LD_STRUCTURED, resource, sm6);
> - operand_count = 2 + !raw;
> - src_params = instruction_src_params_alloc(ins, operand_count, sm6);
> - src_params_init_from_operands(src_params, &operands[1], operand_count - 1);
> - src_param_init_vector_from_reg(&src_params[operand_count - 1], &resource->u.handle.reg);

Shouldn't we check for allocation success here?