Re: [PATCH v5 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c:
>  ok(GetLastError() == ERROR_SUCCESS || broken(GetLastError() == ERROR_INVALID_PARAMETER) /* some win8 machines */,
>      "Unexpected error %lu.\n", GetLastError());
>
> - /* test long file path, the length of the long_dest is larger than MAX_PATH. */
> - if (is_enabled_long_path())
> - {
> -
>    wcscpy(long_path_1, temp_path);
> -
>    wcscat(long_path_1, long_name_1);
> -
>    SetLastError(0xdeadbeef);
> -
>    ret = CopyFileExW(source, long_path_1, NULL, NULL, NULL, 0);
> -
>    ok(ret, "Expected CopyFileExW successed, but got %ld, copy %s -> %s\n", GetLastError(), wine_dbgstr_w(source), wine_dbgstr_w(long_path_1));
> -
>    wcscpy(long_path_2, temp_path);
> -
>    wcscat(long_path_2, long_name_2);
> -
>    SetLastError(0xdeadbeef);
> -
>    ret = CopyFileExW(long_path_1, long_path_2, NULL, NULL, NULL, 0);

You should probably use CopyFileExW(long_path_1, dest, ...) so that you're testing long path support for one parameter at a time.