On Fri Nov 10 16:50:33 2023 +0000, Zebediah Figura wrote:
If we choose to be permissive, should these tests be included or not?
I don't think we need to implement the logic right now, but having our logic match native in this respect I think is a good idea. I.e. we should implement the logic "eventually". So I would keep the tests, yes.
Okay, I added them at the end of `register-reservations-numeric.shader_test`.
Because there are many new tests I moved these tests to a new file `register-reservations-numeric.shader_tests` and renamed the older one to `register-reservations-resources.shader_tests`.
Also, properly indicating for which shader models these tests fail and are todo required 2/7, which I think most people agreed on !418, and also 3/7 which I think should not be so controversial as it is a natural extension of the current qualifiers code.
But perhaps I should send 1/7, 2/7, and 3/7 as a separate MR at this point, and make this one wait for that one now.