On Tue Feb 21 14:14:49 2023 +0000, Konstantin Romanov wrote:
As I understood winscard implementation was not accepted before, because there was no way to provide full-fledged testing. As I wrote above https://github.com/Jakuje/virt_cacard allows you to test in a virtual environment without hardware. (works also in docker containers) Including data exchange with smartcard. It took some time to offer a working testing scheme.
I didn't base my patches on Mounir's work, I started from scratch. I see that my implementation is a bit more complete. It has configure checks and wow64 support for example. It also does a number of things differently. One is that I'm not loading libpcsclite dynamically. Because this dll is not useful without libpcsclite support we can just let it fail to load. I also think it's cleaner to use UINT64 instead of doing those preprocessor tricks with DWORD. My MR is also already split into smaller commits.
I see that you have support for Apple which is not included in my own patches. You also have some good tests it seems.