Re: [PATCH 0/5] MR6776: d3dx9: D3DXSaveSurfaceToFileInMemory() refactoring, part 1.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
> -
>    if (FAILED(hr))
> -
>    {
> -
>        skip("Couldn't create surface for format %#x.\n", dds_tests[i].format);
> -
>        continue;
> -
>    }
> -
> -
>    winetest_push_context("Test %u", i);
> -
>    hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, dds_tests[i].palette, NULL);
> -
>    todo_wine_if(dds_tests[i].todo_hr) ok(hr == dds_tests[i].expected_hr, "Unexpected hr %#lx.\n", hr);
> -
>    if (SUCCEEDED(hr))
> -
>    {
> -
>        ok(ID3DXBuffer_GetBufferSize(buffer) == dds_tests[i].expected_buffer_size, "Unexpected buffer size %lu.\n",
> -
>                ID3DXBuffer_GetBufferSize(buffer));
> -
> -
>        dds = ID3DXBuffer_GetBufferPointer(buffer);
> -
>        check_dds_header(&dds->header, dds_tests[i].expected_flags, dds_tests[i].expected_height, dds_tests[i].expected_width,

We usually try to keep line length below 100-120 columns. It's not a super strict limit, but once you end up having to split lines you might as well aim for that kind of range.