Re: [PATCH 0/5] MR6776: d3dx9: D3DXSaveSurfaceToFileInMemory() refactoring, part 1.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
> -
>    struct dds_pixel_format expected_pixel_format;
> -
>    uint32_t expected_flags;
> -
>    uint32_t expected_width;
> -
>    uint32_t expected_height;
> -
>    uint32_t expected_pitch;
> -
>    uint32_t expected_depth;
> -
>    uint32_t expected_mip_levels;
> -
>    uint32_t expected_caps;
> -
>    uint32_t expected_caps2;
> -
>    uint32_t expected_buffer_size;
> -
>    BOOL todo_hr;
> -
>    BOOL todo_expected;
> - } dds_tests[] = {
> -
>    { D3DFMT_P8, 4, 4, test_palette, D3D_OK,
> -
>      { 32, DDS_PF_INDEXED, 0, 8, 0, 0, 0, 0 },
> -
>      (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), 4, 4, 0, 0, 0, (DDS_CAPS_TEXTURE | DDSCAPS_PALETTE), 0,

I think those kind of parentheses are a bit ugly, especially when they aren't used consistently.