26 Sep
2024
26 Sep
'24
3:17 p.m.
On Thu Sep 26 10:35:22 2024 +0000, Alexandros Frantzis wrote:
Although the surface configuration checks we have inside wayland_surface_reconfigure_{xdg,subsurface} currently seem to protect us from accessing invalid objects (i.e., when the actual current role is NONE), it seems fragile to depend on these checks. Perhaps it would be best to explicitly check for the invalid object case in those functions, too?
I moved the checks out of the helpers and to the caller side instead. Also restored the check that was initially here for `wayland_surface_reconfigure_xdg`.