Re: [PATCH 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/filter.y:
> +#include "wine/debug.h"
> -
>
> +WINE_DEFAULT_DEBUG_CHANNEL(msado15);
> -
>
> +void yyerror(parser_param* param, void const* scanner, char const* msg);
> +parser_param* yyget_extra ( void* yyscanner );
> +int yylex(void *yylval, void *scanner);
> +%}
> -
>
> +%define api.pure
> +%parse-param {parser_param* p}
> +%parse-param {void* scanner}
> +%lex-param {yyscan_t* scanner}
> -
>
> +%union {
> - char *token;

Naming-wise, it seems clearer to say "column", to distinguish it from a lex token, although you could probably just as easily just use "sval" instead and get rid of this.