Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> - { D3DXPT_INT, sizeof( DWORD ), sizeof( DWORD ), 0, D3DERR_INVALIDCALL, NULL, "i", NULL },
> - { D3DXPT_INT, sizeof( DWORD ) * 4, sizeof( DWORD ) * 4, 0, D3DERR_INVALIDCALL, NULL, "i4", NULL },
> - { D3DXPT_INT, sizeof( DWORD ) * 16, sizeof( DWORD ) * 16, 0, D3DERR_INVALIDCALL, NULL, "i44", NULL },
> - { D3DXPT_FLOAT, sizeof( DWORD ), sizeof( DWORD ), 0, D3DERR_INVALIDCALL, NULL, "f", NULL },
> - { D3DXPT_FLOAT, sizeof( DWORD ) * 4, sizeof( DWORD ) * 4, 0, D3DERR_INVALIDCALL, NULL, "f4", NULL },
> - { D3DXPT_FLOAT, sizeof( DWORD ) * 16, sizeof( DWORD ) * 16, 0, D3DERR_INVALIDCALL, NULL, "f44", NULL },
> - { D3DXPT_STRING, sizeof( "test" ), sizeof( "test" ), 0, D3DERR_INVALIDCALL, "test", "s_2", NULL },
> - */
> -
> - /* Boolean. Test 0x0 */
> - { D3DXPT_BOOL, sizeof( BOOL ), sizeof( BOOL ), 0, S_OK, &SET_RAWDATA_BOOL44_A, "b", &SET_RAWDATA_BOOL44_A },
> - { D3DXPT_BOOL, sizeof( BOOL ), 0, 0, S_OK, &SET_RAWDATA_BOOL44_A, "b", &SET_RAWDATA_INT44_B },
> - { D3DXPT_BOOL, sizeof( BOOL ), sizeof( BOOL ), sizeof( BOOL ), S_OK, &SET_RAWDATA_BOOL44_A, "b", &SET_RAWDATA_INT44_B },
> - { D3DXPT_BOOL, sizeof( BOOL ), sizeof( BOOL ), 0, S_OK, &SET_RAWDATA_BOOL44_A, "b", &SET_RAWDATA_INT44_B },
> -
> - /* Boolean vector. Test 0x4 */

Good idea to keep track of the test index. Decimal numbers would probably be easier to read though.