29 Nov
2024
29 Nov
'24
3:11 p.m.
On Thu Nov 28 16:02:07 2024 +0000, Rémi Bernon wrote:
changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/6916/diffs?diff_id=145991&start_sha=a47cf9646b0f176ee89ded1a5c987c5f04e0f0bf#561751f09a3d9e02a084f385e9182f0184b50581_1065_1081)
The rationale is the same as for using `impl_from_*` helpers instead of `CONTAINING_RECORD` everywhere. It's fundamentally similar to regular casts: if they're needed in too many cases, it typically indicates either poor use of C types or insufficient abstraction helpers. In this case, I believe it was the latter.
Anyway, it looks much better now, thanks.