Re: [PATCH v4 0/9] MR3300: jscript: WeakMap implementation.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/dispex.c:
>                  break;
>          }
>
> -
>        /* For weak refs, traverse paths accessible from it via the WeakMaps, if the WeakMaps are alive at this point.
> -
>           We need both the key and the WeakMap for the entry to actually be accessible (and thus traversed). */
> -
>        if(obj2->has_weak_refs) {
> -
>            struct list *list = &RB_ENTRY_VALUE(rb_get(&ctx->weak_refs, obj2), struct weak_refs_entry, entry)->list;
> -
>            struct weakmap_entry *entry;
> -
> -
>            LIST_FOR_EACH_ENTRY(entry, list, struct weakmap_entry, weak_refs_entry) {
> -
>                if(!entry->weakmap->gc_marked && is_object_instance(entry->value) && (link = to_jsdisp(get_object(entry->value)))) {

Shouldn't we check for true gc_marked here?