Re: [PATCH v4 0/5] MR3607: apisetschema: Add ext-ms-win-dxcore-l1-1-0.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about include/dxcore_interface.h:
> +DEFINE_GUID(DXCORE_ADAPTER_ATTRIBUTE_D3D12_GRAPHICS, 0x0c9ece4d, 0x2f6e, 0x4f01, 0x8c, 0x96, 0xe8, 0x9e, 0x33, 0x1b, 0x47, 0xb1);
> +DEFINE_GUID(DXCORE_ADAPTER_ATTRIBUTE_D3D12_CORE_COMPUTE, 0x248e2800, 0xa793, 0x4724, 0xab, 0xaa, 0x23, 0xa6, 0xde, 0x1b, 0xe0, 0x90);
> -
>
> +#undef INTERFACE
> +#define INTERFACE IDXCoreAdapter
> +DECLARE_INTERFACE_IID_(IDXCoreAdapter, IUnknown, "526c7776-40e9-459b-b711-f32ad76dfc28")
> +{
> - /* IUnknown methods */
> - STDMETHOD(QueryInterface) (THIS_ REFIID riid, void **ppv) PURE;
> - STDMETHOD_(ULONG, AddRef) (THIS) PURE;
> - STDMETHOD_(ULONG, Release) (THIS) PURE;
> - /* IDXCoreAdapter methods */
> - STDMETHOD_(BOOL, IsValid) (THIS) PURE;
> - STDMETHOD_(BOOL, IsAttributeSupported) (THIS_ GUID attribute) PURE;
> - STDMETHOD_(BOOL, IsPropertySupported) (THIS_ DXCoreAdapterProperty property) PURE;
> - STDMETHOD(GetProperty) (THIS_ DXCoreAdapterProperty property, size_t *buffer_size, void *buffer) PURE;

```suggestion:-0+0
    STDMETHOD(GetProperty) (THIS_ DXCoreAdapterProperty property, size_t buffer_size, void *buffer) PURE;
```