On Wed Mar 22 17:40:43 2023 +0000, Zebediah Figura wrote:
Do we still need the changes to quartz_parser.c or wg_format.c in
patch 3/5?
WMV decoder currently works without the changes to quartz_parser.c and
wg_format.c in patch 3/5. But I think it would be better to have these changes. What do you think of it? Do we keep the changes or not? If not, I'll submit a new version later. I don't think the changes to amt_to_wg_format_video() should be committed without first understanding whether they're correct (e.g. what *should* quartz do when given a zero AvgTimePerFrame?) And the changes to wg_format_to_caps() seem questionable largely because they're basically doing the same thing as the changes to amt_to_wg_format_video() but in a different place, but that change is correct, I prefer the way it's done in amt_to_wg_format_video(), on the grounds that the latter is more explicit.
So we discard the changes to amt_to_wg_format_video() and wg_format_to_caps() for now?