Re: [PATCH v3 0/4] MR5156: mshtml: Always use the event target dispex

[Jacek Caban (＠jacek)]

On Tue Feb 27 19:57:06 2024 +0000, Brendan McGrath wrote:
> I just tried making this change, but it seems to be a breaking change.
> The test at line 88 in `documentmode.js` started failing:
> ok(performance.timing.domContentLoadedEventStart >=
> performance.timing.domInteractive, "domContentLoadedEventStart < domInteractive");
>
> I confirmed the old code was doing this when trusted was false, and
> given the tests pass on Windows, I'm guessing Windows does too.

That doesn't prove that we should update times on custom events. To prove that, you'd need to use `dispatchEvent()` to dispatch a custom event and see if `domContentLoadedEventStart` value changes (and I'd expect not).

Did you use `nsIDOMEvent` for that? I don't remember details, but there were reasons it's not used for our `IDOMEvent::get_isTrusted()`, so please try `DOMEvent.trusted` if you didn't.