On Tue May 16 18:30:55 2023 +0000, Zebediah Figura wrote:
I won't ask for it for this patch, since I've already reviewed it, but in the future, please try to split up commits more. It's a lot easier to review with granular changes. E.g. in this case we could have had:
- change "lod" to "params"
- parse SamplerComparisonState
- parse the SampleCmp() function
- emit sm4 for HLSL_RESOURCE_SAMPLE_CMP
I'll split it, no problem.