Re: [PATCH v3 0/1] MR2471: winegstreamer: In video_processor, activate a videoflip converter.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/mf/tests/transform.c:
>  ok(ref == 1, "Release returned %ld\n", ref);
>
>  ret = check_mf_sample_collection(output_samples, &output_sample_desc, L"rgb32frame-vp.bmp");
> - todo_wine
> - ok(ret == 0 || broken(ret == 25) /* w1064v1507 / w1064v1809 incorrectly rescale */, "got %lu%% diff\n", ret);
> - /* Color transformation in gstreamer doesn't exactly match Windows' implementation.
> -
> * Tolerate some variation in Wine.
> -
> */
> - ok(ret == 0 ||
> -
>   (!strcmp(winetest_platform, "wine") && ret <= 2) ||
> -
>   broken(ret == 25) /* w1064v1507 / w1064v1809 incorrectly rescale */, "got %lu%% diff\n", ret);

Imho we could unconditionally relax this to accept up to 2% difference. The purpose of the test was to catch vertical flips and invalid cropping, not to be pixel perfect.