Re: [PATCH v43 0/6] MR6766: wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/wintypes/tests/wintypes.c:
>  hr = RoGetActivationFactory( name, &IID_IActivationFactory, (void **)&propset_factory );
>  WindowsDeleteString( name );
> -
>
> todo_wine
> ok( hr == S_OK || broken( hr == REGDB_E_CLASSNOTREG ), "RoGetActivationFactory failed, hr %#lx.\n", hr );
> if (hr != S_OK)
> {
> -
>    todo_wine
>    win_skip( "%s runtimeclass not registered, skipping tests.\n", wine_dbgstr_w( class_name ) );
>    goto done;
>
> }
>
> hr = IActivationFactory_ActivateInstance( propset_factory, &inspectable );
>    IActivationFactory_Release( propset_factory );
> -
>
> todo_wine
> ok( hr == S_OK, "got %#lx\n", hr );
> if (FAILED( hr ))

There is no error on Windows for this test, right? So you can delete the "if (FAILED( hr ))" branch after you add the stubs. This will make the tests cleaner. Same for other places and patches.