Re: [PATCH v5 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c:
> -
>    /* We try to intercept buffers produced by the parser, so if we push a large buffer into the
> -
>     * parser, it won't push everything into the decoder all in one go.
> -
>     */
> -
>    if ((element = create_element("hold", NULL)))
> -
>    {
> -
>        if (!append_element(transform->container, element, first, last))
> -
>        {
> -
>            GST_ERROR("Failed to append a hold element to the parser");
> -
>            g_object_unref(element);
> -
>        }
> -
>        else
> -
>            /* element is owned by the container */
> -
>            transform->hold = GST_HOLD(element);
> -
>    }
> -
>    else
> -
>        GST_ERROR("Failed to create a hold element");

```suggestion:-12+0
        if (!(element = create_element("hold", NULL))
                || !append_element(transform->container, element, first, last))
            goto done;
        /* element is owned by the container */
        transform->hold = GST_HOLD(element);
```

Error messages are already printed by create_element/append_element.