Rémi Bernon (@rbernon) commented about dlls/ntdll/unix/sync.c:
- return STATUS_SUCCESS;
+}
+static NTSTATUS linux_release_semaphore_obj( int obj, ULONG count, ULONG *prev_count ) +{
- NTSTATUS ret;
- ret = ioctl( obj, NTSYNC_IOC_SEM_RELEASE, &count );
- if (ret < 0)
- {
if (errno == EOVERFLOW)
return STATUS_SEMAPHORE_LIMIT_EXCEEDED;
else
return errno_to_status( errno );
The else is unnecessary after return, and I think these short ifs should be kept one-liner as there are other instance of one-liners in the same function (and file).
```suggestion:-3+0 if (errno == EOVERFLOW) return STATUS_SEMAPHORE_LIMIT_EXCEEDED; return errno_to_status( errno ); ```