Re: [PATCH v2 0/11] MR1526: mshtml: Misc improvements.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmlimg.c:
> -
>
> HRESULT hres;
>
> TRACE("(%p)->(%s)\n", This, debugstr_w(v));
> -
>
> nsAString_Init(&src_str, NULL);
> -
>
> nsres = nsIDOMHTMLImageElement_GetSrc(This->nsimg, &src_str);
> -
>
> if(NS_SUCCEEDED(nsres)) {
> -
>    const PRUnichar *src;
> -
>    DOMEvent *event;
> -
>    VARIANT_BOOL b;
> -
>    BOOL same;
> -
> -
>    nsAString_GetData(&src_str, &src);
> -
>    same = !wcscmp(v, src);
> -
>    nsAString_Finish(&src_str);
> -
>    if(same) {

This looks suspicious, the image could have changed on the server and the test is not really convincing. One way to explain what you see in tests would be that we should start loading immediately and finish immediately if the image from http protocol is cached. One hint that it's the case is in onerror tests: `pump_msgs(&called_img_onerror); /* FIXME: should not be needed */`.