From 8f68f5bc759411667c1db9a050aa9ba2ebb5a958 Mon Sep 17 00:00:00 2001 From: Zebediah Figura <zfigura@codeweavers.com> Date: Mon, 31 Jul 2023 19:52:16 -0500 Subject: [PATCH 06/10] vkd3d-shader: Pass a complete vkd3d_shader_descriptor_info1 to vkd3d_shader_scan_add_descriptor(). Adding more parameters, especially bare numeric parameters, gets unwieldy.
Sure, though for the things added in this MR, we could also do something like this: ```c descriptor = vkd3d_shader_scan_add_descriptor(...); descriptor->sample_count = sample_count; descriptor->structure_stride = structure_stride; ``` or take it a step further, and do this: ```c descriptor = vkd3d_shader_scan_resource_declaration(...); descriptor->sample_count = semantic->sample_count; ... descriptor = vkd3d_shader_scan_resource_declaration(...); descriptor->structure_stride = instruction->declaration.structured_resource.byte_stride; ``` and so on. I don't have a strong preference, but the resulting code may be slightly more compact, and the second variant would avoid passing some optional parameters through vkd3d_shader_scan_resource_declaration() as well.
+ /** The descriptor is a raw (byte-addressed) buffer. */ + VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_RAW_BUFFER = 0x00000010,
That needs a \since.