On Wed Mar 13 19:53:48 2024 +0000, Zebediah Figura wrote:
This is an even worse case, because if I'm not mistaken we can write zero annotations and succeed even when there should be some. I know it's part of the initial fx bringup, and there's other similar problems, but at least in this case it seems easy enough to replace the single "FIXME" comment with something like "if (!list_empty(var->annotations->vars)) hlsl_fixme(...)", and that would avoid that problem.
Yes, that makes sense. I'll do that as a separate patch.