Re: [PATCH v14 0/3] MR6737: comctl32/toolbar: forward WM_NOTIFY CBEN_ENDEDITW

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c:
>  DestroyWindow(hwnd);
>
> }
>
> +static void test_WM_NOTIFY(void)
> +{
> - HWND toolbar = NULL;
> - LRESULT ret;
> -
> - parent_WM_NOTIFYFORMAT_return = NFR_UNICODE;
> - rebuild_toolbar(&toolbar);
> - parent_WM_NOTIFYFORMAT_return = NFR_ANSI;

This is not clear. NFR_UNICODE only takes effect when creating a new toolbar. So setting parent_WM_NOTIFYFORMAT_return to NFR_ANSI is actually for the rebuild_toolbar() at line 2902. What you should do is create a toolbar expecting Unicode notifications, send CBEN_ENDEDITW and CBEN_ENDEDITA, and then create a new toolbar expecting ASCII notifications, then send CBEN_ENDEDITW and CBEN_ENDEDITA.

And let's send CBEN_ENDEDITW with SendMessageW() instead of SendMessageA().