On Mon Aug 7 17:03:28 2023 +0000, Esme Povirk wrote:
I could see an argument, separately, for making `dump_sequence` print only the actual messages, since the expected messages are in the test itself, and doing so for any non-todo Wine tests. But given that I plan on spending time with these tests, I don't want to manually compare sequences if I don't have to.
If all you get is a dumped message sequence, you have to manually compare everything (at least starting from the first expected message that failed, and often starting with the optional messages before that). This includes looking up different types of message constants for every message. And, not being a computer, it's easy to make mistakes or lose your place.
Maybe for some reason I don't understand, it's easier for you, but *for me* this makes understanding what happened much easier. Assuming it doesn't actively make things more difficult for you (and I don't see why it would - it's not mutually exclusive with the other changes you want), or significantly increase the code complexity (again, I don't think it does), isn't that enough for it to be worth having?