Re: [PATCH 0/2] MR5385: winebus: ignore udev events of devices which do not have devnodes

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winebus.sys/bus_udev.c:
> {
>      struct base_device *impl;
> - if (!path)
> - {
> -
>    FIXME("called find_device_from_devnode(NULL)\n");
> -
>    return NULL;
> - }
> -

You're checking for the same condition in the next commit, so this one then becomes unnecessary. I'd also prefer to only check for this in the callers.

As a side note, FIXME is supposed to be used for things that are not implemented yet, not for bugs. It's better to use WARN or ERR (the latter in the case of a programming or irrecoverable error, the former in the case of an error that can genuinely happen under some circumstances).