On Tue Apr 25 00:52:33 2023 +0000, Huw Davies wrote:
I've not really been following this, but why doesn't `SHBindToParent()` call `SHBindToFolderIDListParent()`? What you want to do is to implement `SHBindToFolderIDListParent()` using the code in `SHBindToParent()` as a start, adding the code to deal with the passed in `IShellFolder`. Then **in the same commit** change `SHBindToParent()` to call `SHBindToFolderIDListParent()`. With careful choice of the positioning of the second function with respect to first one, the diff should be quite small.
There were some comments regarding how the changes should be committed and it wasn't really clear to me what was requested so I ultimately decided to just implement `SHBindToFolderIDListParent()` on its own.
I've done as you suggested and implemented `SHBindToFolderIDListParent()` using the code in `SHBindToParent()` in the first commit. I added tests for how the last parameter is handled in Windows in the third commit and fixed it in the last commit.
Regarding the diff, there weren't any significant differences if `SHBindToFolderIDListParent()` was added above `SHBindToParent()` or below it.
Thanks so much for the review!