Re: [PATCH v2 0/2] MR6827: msi: Fix MsiSummaryInfoPersist not saving data to disk

[Hans Leidekker (＠hans)]

On Tue Nov 19 01:42:52 2024 +0000, Fabian Maurer wrote:
> Not sure what you mean, my first test checked what happens if you try to
> persist on a transacted handle. I added another test for persisting on a
> directly opened database for completeness.
> What exactly should I change here?

Your test shows that calling MsiSummaryInfoPersist() has no effect if the database is transacted. That makes sense because changes should only be stored when MsiDatabaseCommit() is called. It would be nice if you could add a test that shows this. Then the commit message 'Fix MsiSummaryInfoPersist not saving data to disk' should be more specific. Your patch only handles the case where MsiGetSummaryInformationW() opens the database.