Re: [PATCH 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
> -
> -
>    /*
> -
>     * Footer offsets do not seem to be validated. Possible that footer
> -
>     * isn't even checked for.
> -
>     */
> -
>    tmp_footer = default_tga_footer;
> -
>    tmp_footer.extension_area_offset = 65536;
> -
>    memcpy(&tga->data[info_tests[i].extra_header_size], &tmp_footer, sizeof(tmp_footer));
> -
>    check_tga_image_info(tga, file_size + sizeof(tmp_footer), info_tests[i].expected.width, info_tests[i].expected.height,
> -
>            info_tests[i].expected.format, info_tests[i].expected.hr, TRUE, info_tests[i].todo_info);
> -
> -
>    /* Check RLE type. */
> -
>    tga->header.image_type |= IMAGETYPE_RLE;
> -
>    check_tga_image_info(tga, file_size, info_tests[i].expected.width, info_tests[i].expected.height,
> -
>            info_tests[i].expected.format, info_tests[i].expected.hr, TRUE, info_tests[i].todo_info);
> -
>    tga->header.image_type &= ~IMAGETYPE_RLE;

Oh wow, I didn't expect that.