May 2016 - Wine-commits - list.winehq.org

Jacek Caban : mshtml: Added IHTMLElement::put_onkeyup implementation.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 4d1194d1047939dd9cba8df5d6bd8ad60a9ff7e5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4d1194d1047939dd9cba8df5d… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun May 22 13:25:53 2016 +0200 mshtml: Added IHTMLElement::put_onkeyup implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 9456759..7abd727 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -979,8 +979,10 @@ static HRESULT WINAPI HTMLElement_put_onkeyup(IHTMLElement *iface, VARIANT v) static HRESULT WINAPI HTMLElement_get_onkeyup(IHTMLElement *iface, VARIANT *p) { HTMLElement *This = impl_from_IHTMLElement(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_node_event(&This->node, EVENTID_KEYUP, p); } static HRESULT WINAPI HTMLElement_put_onkeypress(IHTMLElement *iface, VARIANT v)

1 0

Frédéric Delanoy : advapi32: Use dbgstr_a() to print string in a FIXME.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 1d131cff6eefce5d3f797a1b69dbbe2c4b2e962e URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d131cff6eefce5d3f797a1b6… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sun May 22 15:39:17 2016 +0200 advapi32: Use dbgstr_a() to print string in a FIXME. Signed-off-by: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/advapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/advapi32/advapi.c b/dlls/advapi32/advapi.c index 748a5df..def40e5 100644 --- a/dlls/advapi32/advapi.c +++ b/dlls/advapi32/advapi.c @@ -188,7 +188,7 @@ BOOL WINAPI IsTextUnicode( LPCVOID buf, INT len, LPINT flags ) */ BOOL WINAPI AbortSystemShutdownA( LPSTR lpMachineName ) { - TRACE("stub %s (harmless)\n", lpMachineName); + TRACE("stub %s (harmless)\n", debugstr_a(lpMachineName)); return TRUE; }

1 0

Nikolay Sivov : rpcss: Fix potential leaks when removing endpoint ( Coverity).
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: a87c510e9a7ff3fd748920525425b7e317a0bbdf URL: http://source.winehq.org/git/wine.git/?a=commit;h=a87c510e9a7ff3fd748920525… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun May 22 21:44:47 2016 +0300 rpcss: Fix potential leaks when removing endpoint (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/rpcss/epmp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/programs/rpcss/epmp.c b/programs/rpcss/epmp.c index 2eb6039..3243192 100644 --- a/programs/rpcss/epmp.c +++ b/programs/rpcss/epmp.c @@ -165,6 +165,11 @@ void __cdecl ept_delete(handle_t h, if (rpc_status != RPC_S_OK) break; entry = find_ept_entry(&iface, &syntax, protseq, endpoint, address, &entries[i].object); + + I_RpcFree(protseq); + I_RpcFree(endpoint); + I_RpcFree(address); + if (entry) delete_registered_ept_entry(entry); else @@ -172,9 +177,6 @@ void __cdecl ept_delete(handle_t h, *status = EPT_S_NOT_REGISTERED; break; } - I_RpcFree(protseq); - I_RpcFree(endpoint); - I_RpcFree(address); } LeaveCriticalSection(&csEpm);

1 0

Nikolay Sivov : rpcss: Fix a leak when TowerExplode() fails on endpoint insertion (Coverity).
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 5b406f896399a7783d1297c2ac4fe1c4c8f7f9c5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5b406f896399a7783d1297c2a… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun May 22 21:44:48 2016 +0300 rpcss: Fix a leak when TowerExplode() fails on endpoint insertion (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/rpcss/epmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/programs/rpcss/epmp.c b/programs/rpcss/epmp.c index 3243192..1acefa2 100644 --- a/programs/rpcss/epmp.c +++ b/programs/rpcss/epmp.c @@ -122,6 +122,7 @@ void __cdecl ept_insert(handle_t h, { WINE_WARN("TowerExplode failed %u\n", rpc_status); *status = rpc_status; + HeapFree(GetProcessHeap(), 0, entry); break; /* FIXME: more cleanup? */ }

1 0

Nikolay Sivov : rpcss: No need to initialize entry list pointers.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 42a6fc28c808ddc8921dba306f2444c2a3d0fa24 URL: http://source.winehq.org/git/wine.git/?a=commit;h=42a6fc28c808ddc8921dba306… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun May 22 21:44:49 2016 +0300 rpcss: No need to initialize entry list pointers. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/rpcss/epmp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/programs/rpcss/epmp.c b/programs/rpcss/epmp.c index 1acefa2..656fa9c 100644 --- a/programs/rpcss/epmp.c +++ b/programs/rpcss/epmp.c @@ -113,7 +113,6 @@ void __cdecl ept_insert(handle_t h, *status = EPT_S_CANT_PERFORM_OP; break; } - list_init(&entry->entry); memcpy(entry->annotation, entries[i].annotation, sizeof(entries[i].annotation)); rpc_status = TowerExplode(entries[i].tower, &entry->iface, &entry->syntax, &entry->protseq, &entry->endpoint,

1 0

Nikolay Sivov : crypt32: No need to init entry fields when it' s about to be added to a list.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 4ec1ca5a0ff3b3c6adbd458b166a865132e5b984 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4ec1ca5a0ff3b3c6adbd458b1… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun May 22 21:45:51 2016 +0300 crypt32: No need to init entry fields when it's about to be added to a list. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/collectionstore.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/crypt32/collectionstore.c b/dlls/crypt32/collectionstore.c index bfb83d1..f565745 100644 --- a/dlls/crypt32/collectionstore.c +++ b/dlls/crypt32/collectionstore.c @@ -524,7 +524,6 @@ BOOL WINAPI CertAddStoreToCollection(HCERTSTORE hCollectionStore, entry->store = sibling; entry->dwUpdateFlags = dwUpdateFlags; entry->dwPriority = dwPriority; - list_init(&entry->entry); TRACE("%p: adding %p, priority %d\n", collection, entry, dwPriority); EnterCriticalSection(&collection->cs); if (dwPriority)

1 0

Andrey Gusev : shell32: Fix a typo in TRACE format in SHPathPrepareForWriteW.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 7f64817e5ed3a982bc57ddb603e96de8ab327715 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f64817e5ed3a982bc57ddb60… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Sun May 22 16:57:58 2016 +0300 shell32: Fix a typo in TRACE format in SHPathPrepareForWriteW. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shlfileop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c index 6f20181..3c18066 100644 --- a/dlls/shell32/shlfileop.c +++ b/dlls/shell32/shlfileop.c @@ -1744,7 +1744,7 @@ HRESULT WINAPI SHPathPrepareForWriteW(HWND hwnd, IUnknown *modless, LPCWSTR path WCHAR* last_slash; WCHAR* temppath=NULL; - TRACE("%p %p %s 0x%80x\n", hwnd, modless, debugstr_w(path), flags); + TRACE("%p %p %s 0x%08x\n", hwnd, modless, debugstr_w(path), flags); if (flags & ~(SHPPFW_DIRCREATE|SHPPFW_ASKDIRCREATE|SHPPFW_IGNOREFILENAME)) FIXME("unimplemented flags 0x%08x\n", flags);

1 0

Andrey Gusev : secur32/tests: Fix a typo in ok() messages.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: fd040fc9d9a84343c061755fcc313c5d994ec8b5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd040fc9d9a84343c061755fc… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Sun May 22 23:05:13 2016 +0300 secur32/tests: Fix a typo in ok() messages. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/secur32/tests/ntlm.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/secur32/tests/ntlm.c b/dlls/secur32/tests/ntlm.c index 154d86b..4147ac7 100644 --- a/dlls/secur32/tests/ntlm.c +++ b/dlls/secur32/tests/ntlm.c @@ -327,7 +327,7 @@ static SECURITY_STATUS setupClient(SspiData *sspi_data, SEC_CHAR *provider) trace("AcquireCredentialsHandle() returned %s\n", getSecError(ret)); } - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); return ret; @@ -355,7 +355,7 @@ static SECURITY_STATUS setupServer(SspiData *sspi_data, SEC_CHAR *provider) trace("AcquireCredentialsHandle() returned %s\n", getSecError(ret)); } - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); return ret; @@ -1211,21 +1211,21 @@ static BOOL testAcquireCredentialsHandle(void) ret = pAcquireCredentialsHandleA(NULL, sec_pkg_name, SECPKG_CRED_OUTBOUND, NULL, &id, NULL, NULL, &cred, &ttl); - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); pFreeCredentialsHandle(&cred); id.DomainLength = 0; ret = pAcquireCredentialsHandleA(NULL, sec_pkg_name, SECPKG_CRED_OUTBOUND, NULL, &id, NULL, NULL, &cred, &ttl); - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); pFreeCredentialsHandle(&cred); id.Domain = NULL; ret = pAcquireCredentialsHandleA(NULL, sec_pkg_name, SECPKG_CRED_OUTBOUND, NULL, &id, NULL, NULL, &cred, &ttl); - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); pFreeCredentialsHandle(&cred); @@ -1235,7 +1235,7 @@ static BOOL testAcquireCredentialsHandle(void) id.User = NULL; ret = pAcquireCredentialsHandleA(NULL, sec_pkg_name, SECPKG_CRED_OUTBOUND, NULL, &id, NULL, NULL, &cred, &ttl); - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); pFreeCredentialsHandle(&cred); @@ -1245,7 +1245,7 @@ static BOOL testAcquireCredentialsHandle(void) id.PasswordLength = 0; ret = pAcquireCredentialsHandleA(NULL, sec_pkg_name, SECPKG_CRED_OUTBOUND, NULL, &id, NULL, NULL, &cred, &ttl); - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); pFreeCredentialsHandle(&cred); return TRUE; @@ -1289,7 +1289,7 @@ static void test_cred_multiple_use(void) ret = pAcquireCredentialsHandleA(NULL, sec_pkg_name, SECPKG_CRED_OUTBOUND, NULL, &id, NULL, NULL, &cred, &ttl); - ok(ret == SEC_E_OK, "AcquireCredentialsHande() returned %s\n", + ok(ret == SEC_E_OK, "AcquireCredentialsHandle() returned %s\n", getSecError(ret)); buffer_desc.ulVersion = SECBUFFER_VERSION; @@ -1337,7 +1337,7 @@ static void test_null_auth_data(void) status = pAcquireCredentialsHandleA(NULL, (SEC_CHAR *)"NTLM", SECPKG_CRED_OUTBOUND, NULL, NULL, NULL, NULL, &cred, &ttl); - ok(status == SEC_E_OK, "AcquireCredentialsHande() failed %s\n", getSecError(status)); + ok(status == SEC_E_OK, "AcquireCredentialsHandle() failed %s\n", getSecError(status)); buffers[0].cbBuffer = info->cbMaxToken; buffers[0].BufferType = SECBUFFER_TOKEN;

1 0

Thomas Faber : qmgr: Fully initialize URL_COMPONENTSW structure before calling WinHttpCrackUrl.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: d0b72cee0dee7548731bb2b9ba4f6f39a3fdede8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d0b72cee0dee7548731bb2b9b… Author: Thomas Faber <thomas.faber(a)reactos.org> Date: Sun May 22 21:13:55 2016 +0200 qmgr: Fully initialize URL_COMPONENTSW structure before calling WinHttpCrackUrl. Signed-off-by: Thomas Faber <thomas.faber(a)reactos.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qmgr/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/qmgr/file.c b/dlls/qmgr/file.c index 302f407..cdea329 100644 --- a/dlls/qmgr/file.c +++ b/dlls/qmgr/file.c @@ -522,6 +522,8 @@ BOOL processFile(BackgroundCopyFileImpl *file, BackgroundCopyJobImpl *job) uc.nPort = 0; uc.lpszUrlPath = NULL; uc.dwUrlPathLength = ~0u; + uc.lpszExtraInfo = NULL; + uc.dwExtraInfoLength = 0; ret = WinHttpCrackUrl(file->info.RemoteName, 0, 0, &uc); if (!ret) {

1 0

Andrey Gusev : include: Fix a typo in IDirect3D9Ex method.
by Alexandre Julliard 23 May '16

23 May '16

Module: wine Branch: master Commit: 7372e704d031a0953434b9c4f7d59baa102acbad URL: http://source.winehq.org/git/wine.git/?a=commit;h=7372e704d031a0953434b9c4f… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Sun May 22 22:42:28 2016 +0300 include: Fix a typo in IDirect3D9Ex method. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d3d9.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/d3d9.h b/include/d3d9.h index 24d2968..7ad7138 100644 --- a/include/d3d9.h +++ b/include/d3d9.h @@ -290,7 +290,7 @@ DECLARE_INTERFACE_(IDirect3D9Ex,IDirect3D9) UINT mode_idx, D3DDISPLAYMODEEX *mode) PURE; STDMETHOD(GetAdapterDisplayModeEx)(THIS_ UINT Adapter, D3DDISPLAYMODEEX *pMode, D3DDISPLAYROTATION *pRotation); STDMETHOD(CreateDeviceEx)(THIS_ UINT Adapter, D3DDEVTYPE DeviceType, HWND hFocusWindow, DWORD BehaviorFlags, D3DPRESENT_PARAMETERS* pPresentationParameters, D3DDISPLAYMODEEX* pFullscreenDisplayMode, struct IDirect3DDevice9Ex **ppReturnedDeviceInterface) PURE; - STDMETHOD(GetAdapterLUID)(THIS_ UINT Adatper, LUID *pLUID) PURE; + STDMETHOD(GetAdapterLUID)(THIS_ UINT adapter, LUID *luid) PURE; }; #undef INTERFACE

1 0