October 2018 - Wine-commits

Józef Kucia : vkd3d-shader: Add structure type fields to public API structures.
by Alexandre Julliard 30 Oct '18

30 Oct '18

Module: vkd3d Branch: master Commit: f97b745ae7587166ee177f634721fc7a6bc10858 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=f97b745ae7587166ee177f6… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Oct 30 15:22:53 2018 +0100 vkd3d-shader: Add structure type fields to public API structures. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/private/vkd3d_shader.h | 20 +++++++++++++++++++- libs/vkd3d-shader/vkd3d_shader_main.c | 20 ++++++++++++++++++++ libs/vkd3d/state.c | 10 +++++++++- 3 files changed, 48 insertions(+), 2 deletions(-) diff --git a/include/private/vkd3d_shader.h b/include/private/vkd3d_shader.h index e97e185..f96e505 100644 --- a/include/private/vkd3d_shader.h +++ b/include/private/vkd3d_shader.h @@ -25,6 +25,15 @@ extern "C" { #define VKD3D_FORCE_32_BIT_ENUM(name) name##_FORCE_32BIT = 0x7fffffff +enum vkd3d_shader_structure_type +{ + VKD3D_SHADER_STRUCTURE_TYPE_SHADER_INTERFACE, + VKD3D_SHADER_STRUCTURE_TYPE_COMPILE_ARGUMENTS, + VKD3D_SHADER_STRUCTURE_TYPE_SCAN_INFO, + + VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_STRUCTURE_TYPE), +}; + enum vkd3d_result { VKD3D_OK = 0, @@ -130,6 +139,9 @@ struct vkd3d_shader_push_constant_buffer struct vkd3d_shader_interface { + enum vkd3d_shader_structure_type type; + const void *next; + const struct vkd3d_shader_resource_binding *bindings; unsigned int binding_count; @@ -160,8 +172,11 @@ enum vkd3d_shader_target struct vkd3d_shader_compile_arguments { + enum vkd3d_shader_structure_type type; + const void *next; + enum vkd3d_shader_target target; - unsigned int *output_swizzles; + const unsigned int *output_swizzles; unsigned int output_swizzle_count; }; @@ -366,6 +381,9 @@ int vkd3d_shader_serialize_root_signature(const struct vkd3d_root_signature_desc struct vkd3d_shader_scan_info { + enum vkd3d_shader_structure_type type; + void *next; + unsigned int uav_read_mask : VKD3D_SHADER_MAX_UNORDERED_ACCESS_VIEWS; unsigned int uav_counter_mask : VKD3D_SHADER_MAX_UNORDERED_ACCESS_VIEWS; unsigned int sampler_comparison_mode_mask; diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index f813208..5e292c7 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -61,6 +61,12 @@ static int vkd3d_shader_validate_compile_args(const struct vkd3d_shader_compile_ if (!compile_args) return VKD3D_OK; + if (compile_args->type != VKD3D_SHADER_STRUCTURE_TYPE_COMPILE_ARGUMENTS) + { + WARN("Invalid structure type %#x.\n", compile_args->type); + return VKD3D_ERROR_INVALID_ARGUMENT; + } + switch (compile_args->target) { case VKD3D_SHADER_TARGET_SPIRV_OPENGL_4_5: @@ -88,9 +94,17 @@ int vkd3d_shader_compile_dxbc(const struct vkd3d_shader_code *dxbc, TRACE("dxbc {%p, %zu}, spirv %p, compiler_options %#x, shader_interface %p, compile_args %p.\n", dxbc->code, dxbc->size, spirv, compiler_options, shader_interface, compile_args); + if (shader_interface && shader_interface->type != VKD3D_SHADER_STRUCTURE_TYPE_SHADER_INTERFACE) + { + WARN("Invalid structure type %#x.\n", shader_interface->type); + return VKD3D_ERROR_INVALID_ARGUMENT; + } + if ((ret = vkd3d_shader_validate_compile_args(compile_args)) < 0) return ret; + scan_info.type = VKD3D_SHADER_STRUCTURE_TYPE_SCAN_INFO; + scan_info.next = NULL; if ((ret = vkd3d_shader_scan_dxbc(dxbc, &scan_info)) < 0) return ret; @@ -209,6 +223,12 @@ int vkd3d_shader_scan_dxbc(const struct vkd3d_shader_code *dxbc, TRACE("dxbc {%p, %zu}, scan_info %p.\n", dxbc->code, dxbc->size, scan_info); + if (scan_info->type != VKD3D_SHADER_STRUCTURE_TYPE_SCAN_INFO) + { + WARN("Invalid structure type %#x.\n", scan_info->type); + return VKD3D_ERROR_INVALID_ARGUMENT; + } + if ((ret = vkd3d_shader_parser_init(&parser, dxbc)) < 0) return ret; diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 4800ff3..3f3de4d 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -1439,6 +1439,8 @@ static HRESULT d3d12_pipeline_state_init_compute(struct d3d12_pipeline_state *st dxbc.code = desc->CS.pShaderBytecode; dxbc.size = desc->CS.BytecodeLength; + shader_info.type = VKD3D_SHADER_STRUCTURE_TYPE_SCAN_INFO; + shader_info.next = NULL; if ((ret = vkd3d_shader_scan_dxbc(&dxbc, &shader_info)) < 0) { WARN("Failed to scan shader bytecode, vkd3d result %d.\n", ret); @@ -1452,6 +1454,8 @@ static HRESULT d3d12_pipeline_state_init_compute(struct d3d12_pipeline_state *st return hr; } + shader_interface.type = VKD3D_SHADER_STRUCTURE_TYPE_SHADER_INTERFACE; + shader_interface.next = NULL; shader_interface.bindings = root_signature->descriptor_mapping; shader_interface.binding_count = root_signature->descriptor_count; shader_interface.push_constant_buffers = root_signature->root_constants; @@ -2027,10 +2031,14 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s } graphics->attachment_count = graphics->rt_idx + rt_count; + ps_compile_args.type = VKD3D_SHADER_STRUCTURE_TYPE_COMPILE_ARGUMENTS; + ps_compile_args.next = NULL; ps_compile_args.target = VKD3D_SHADER_TARGET_SPIRV_VULKAN_1_0; ps_compile_args.output_swizzles = ps_output_swizzle; ps_compile_args.output_swizzle_count = rt_count; + shader_interface.type = VKD3D_SHADER_STRUCTURE_TYPE_SHADER_INTERFACE; + shader_interface.next = NULL; shader_interface.bindings = root_signature->descriptor_mapping; shader_interface.binding_count = root_signature->descriptor_count; shader_interface.push_constant_buffers = root_signature->root_constants; @@ -2044,8 +2052,8 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s for (i = 0; i < ARRAY_SIZE(shader_stages); ++i) { const D3D12_SHADER_BYTECODE *b = (const void *)((uintptr_t)desc + shader_stages[i].offset); + struct vkd3d_shader_scan_info shader_info = {VKD3D_SHADER_STRUCTURE_TYPE_SCAN_INFO}; const struct vkd3d_shader_code dxbc = {b->pShaderBytecode, b->BytecodeLength}; - struct vkd3d_shader_scan_info shader_info; if (!b->pShaderBytecode) continue;

1 0

Francois Gouget : testbot: Build the list of test units impacted by module patches.
by Alexandre Julliard 30 Oct '18

30 Oct '18

Module: tools Branch: master Commit: 954f6a7bfa64851fb43349b268095569e3eda2df URL: https://source.winehq.org/git/tools.git/?a=commit;h=954f6a7bfa64851fb43349b… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Oct 30 03:42:20 2018 +0100 testbot: Build the list of test units impacted by module patches. A patch to a dll or program is likely to impact its test units. This makes it possible to know which tests units to rerun. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/PatchUtils.pm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm index 444ffaf..fb4f886 100644 --- a/testbot/lib/WineTestBot/PatchUtils.pm +++ b/testbot/lib/WineTestBot/PatchUtils.pm @@ -216,6 +216,7 @@ sub _HandleFile($$$) my $Module = _CreateTestInfo($Impacts, $Root, $Dir); $Impacts->{PatchedModules} = 1; + $Impacts->{Tests}->{$Module}->{PatchedModule} = 1; if ($File eq "Makefile.in" and $Change ne "modify") { @@ -407,20 +408,23 @@ sub GetPatchImpacts($) $TestInfo->{Units} = {}; foreach my $File (keys %{$TestInfo->{Files}}) { - # Skip unmodified files - next if (!$TestInfo->{All} and !$TestInfo->{Files}->{$File}); - my $Base = $File; # Non-C files are not test units next if ($Base !~ s/(?:\.c|\.spec)$//); # Helper dlls are not test units next if (exists $TestInfo->{Files}->{"$Base.spec"}); + # Don't try running a deleted test unit obviously + next if ($TestInfo->{Files}->{$File} eq "rm"); - if (($TestInfo->{All} or $TestInfo->{Files}->{$File}) and - $TestInfo->{Files}->{$File} ne "rm") + if ($TestInfo->{All} or $TestInfo->{Files}->{$File}) { - # Only new/modified test units are impacted $TestInfo->{Units}->{$Base} = 1; + $Impacts->{ModuleUnitCount}++; + } + elsif ($TestInfo->{PatchedModule}) + { + # The module has been patched so this test unit is impacted indirectly. + $Impacts->{ModuleUnitCount}++; } }

1 0

Alexandre Julliard : testbot: Fix a typo.
by Alexandre Julliard 30 Oct '18

30 Oct '18

Module: tools Branch: master Commit: bc07efbfad4e99e79b5da212c88e0d56feefad64 URL: https://source.winehq.org/git/tools.git/?a=commit;h=bc07efbfad4e99e79b5da21… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 30 09:22:28 2018 +0100 testbot: Fix a typo. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/build/WineTest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/bin/build/WineTest.pl b/testbot/bin/build/WineTest.pl index 0b14b68..ecb3299 100755 --- a/testbot/bin/build/WineTest.pl +++ b/testbot/bin/build/WineTest.pl @@ -84,7 +84,7 @@ sub SetupTest($$) LogMsg "tests\n" if (!$InTests); $InTests = 1; - InfoMsg "\n$Running $Test in the $Mission->{Build} Wine\n"; + InfoMsg "\nRunning $Test in the $Mission->{Build} Wine\n"; SetupWineEnvironment($Mission->{Build}); }

1 0

Francois Gouget : testbot/testagentd: Fix the SetTime() RPC on Unix.
by Alexandre Julliard 30 Oct '18

30 Oct '18

Module: tools Branch: master Commit: 13300521cc65ccb137195cbdf8416e83e8a5d351 URL: https://source.winehq.org/git/tools.git/?a=commit;h=13300521cc65ccb137195cb… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Oct 30 03:41:51 2018 +0100 testbot/testagentd: Fix the SetTime() RPC on Unix. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/src/testagentd/platform_unix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/src/testagentd/platform_unix.c b/testbot/src/testagentd/platform_unix.c index 7a3a8f8..560d121 100644 --- a/testbot/src/testagentd/platform_unix.c +++ b/testbot/src/testagentd/platform_unix.c @@ -231,7 +231,7 @@ int platform_settime(uint64_t epoch, uint32_t leeway) tv.tv_sec = epoch; tv.tv_usec = 0; - if (!settimeofday(&tv, NULL)) + if (settimeofday(&tv, NULL)) { set_status(ST_ERROR, "failed to set the time: %s", strerror(errno)); return 0;

1 0

Francois Gouget : testbot/WineRunWineTest: Remove support for the build Step type.
by Alexandre Julliard 30 Oct '18

30 Oct '18

Module: tools Branch: master Commit: c4f54ba61543016f0922a22170538e4b3e0f66c8 URL: https://source.winehq.org/git/tools.git/?a=commit;h=c4f54ba61543016f0922a22… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Oct 30 03:42:02 2018 +0100 testbot/WineRunWineTest: Remove support for the build Step type. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WineRunWineTest.pl | 75 ++++++++++++++++++++---------------------- 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/testbot/bin/WineRunWineTest.pl b/testbot/bin/WineRunWineTest.pl index 5b6eb33..3784ef0 100755 --- a/testbot/bin/WineRunWineTest.pl +++ b/testbot/bin/WineRunWineTest.pl @@ -383,7 +383,7 @@ if (!$VM->GetDomain()->IsPoweredOn()) FatalError("The VM is not powered on\n"); } -if ($Step->Type ne "build" and $Step->Type ne "suite" and $Step->Type ne "single") +if ($Step->Type ne "suite" and $Step->Type ne "single") { FatalError("Unexpected step type '". $Step->Type ."' found\n"); } @@ -497,7 +497,7 @@ if (!defined $TA->Wait($Pid, $Task->Timeout, 60)) } else { - $PossibleCrash = 1 if ($Step->Type ne "build"); + $PossibleCrash = 1; $TAError = "An error occurred while waiting for the task to complete: $ErrMessage"; $ErrMessage = undef; } @@ -549,49 +549,46 @@ elsif (!defined $TAError) # Grab the test reports if any # -if ($Step->Type ne "build") +foreach my $Build (keys %{$TaskMissions->{Builds}}) { - foreach my $Build (keys %{$TaskMissions->{Builds}}) + my $RptFileName = "$Build.report"; + Debug(Elapsed($Start), " Retrieving '$RptFileName'\n"); + if ($TA->GetFile($RptFileName, "$TaskDir/$RptFileName")) { - my $RptFileName = "$Build.report"; - Debug(Elapsed($Start), " Retrieving '$RptFileName'\n"); - if ($TA->GetFile($RptFileName, "$TaskDir/$RptFileName")) - { - chmod 0664, "$TaskDir/$RptFileName"; + chmod 0664, "$TaskDir/$RptFileName"; - my ($TestUnitCount, $TimeoutCount, $LogFailures, $LogErrors) = ParseWineTestReport("$TaskDir/$RptFileName", 1, $TaskTimedOut); - $TaskTimedOut = 1 if ($TestUnitCount == $TimeoutCount); - if (!defined $LogFailures and @$LogErrors == 1) - { - # Could not open the file - $NewStatus = 'boterror'; - Error "Unable to open '$RptFileName' for reading: $!\n"; - LogTaskError("Unable to open '$RptFileName' for reading: $!\n"); - } - else - { - # $LogFailures can legitimately be undefined in case of a timeout - $TaskFailures += $LogFailures || 0; - if (@$LogErrors and open(my $Log, ">", "$TaskDir/$RptFileName.err")) - { - # Save the extra errors detected by ParseWineTestReport() in - # $RptFileName.err: - # - This keep the .report file clean. - # - Each .err file can be matched to its corresponding .report, even - # if there are multiple .report files in the directory. - # - The .err file can be moved to the latest directory next to the - # reference report. - print $Log "$_\n" for (@$LogErrors); - close($Log); - } - } - } - elsif (!defined $TAError and - $TA->GetLastError() !~ /: No such file or directory/) + my ($TestUnitCount, $TimeoutCount, $LogFailures, $LogErrors) = ParseWineTestReport("$TaskDir/$RptFileName", 1, $TaskTimedOut); + $TaskTimedOut = 1 if ($TestUnitCount == $TimeoutCount); + if (!defined $LogFailures and @$LogErrors == 1) { - $TAError = "An error occurred while retrieving $RptFileName: ". $TA->GetLastError(); + # Could not open the file $NewStatus = 'boterror'; + Error "Unable to open '$RptFileName' for reading: $!\n"; + LogTaskError("Unable to open '$RptFileName' for reading: $!\n"); } + else + { + # $LogFailures can legitimately be undefined in case of a timeout + $TaskFailures += $LogFailures || 0; + if (@$LogErrors and open(my $Log, ">", "$TaskDir/$RptFileName.err")) + { + # Save the extra errors detected by ParseWineTestReport() in + # $RptFileName.err: + # - This keep the .report file clean. + # - Each .err file can be matched to its corresponding .report, even + # if there are multiple .report files in the directory. + # - The .err file can be moved to the latest directory next to the + # reference report. + print $Log "$_\n" for (@$LogErrors); + close($Log); + } + } + } + elsif (!defined $TAError and + $TA->GetLastError() !~ /: No such file or directory/) + { + $TAError = "An error occurred while retrieving $RptFileName: ". $TA->GetLastError(); + $NewStatus = 'boterror'; } }

1 0

Zhiyi Zhang : include: Fix wrong argument attribute for IFileDialog:: GetOptions.
by Alexandre Julliard 29 Oct '18

29 Oct '18

Module: wine Branch: master Commit: 4e90bddcdded52b3a4df52cd92edc987c8553959 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4e90bddcdded52b3a4df52cd… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Oct 29 17:07:47 2018 +0800 include: Fix wrong argument attribute for IFileDialog::GetOptions. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/shobjidl.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 73278e4..d459272 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -2889,7 +2889,7 @@ interface IFileDialog : IModalWindow [in] FILEOPENDIALOGOPTIONS fos); HRESULT GetOptions( - [in] FILEOPENDIALOGOPTIONS *pfos); + [out] FILEOPENDIALOGOPTIONS *pfos); HRESULT SetDefaultFolder( [in] IShellItem *psi);

1 0

Byeongsik Jeon : gdi32: Support other settings for obtaining the default_aa_flags value.
by Alexandre Julliard 29 Oct '18

29 Oct '18

Module: wine Branch: master Commit: 2fe859b8ef0344d216b585baade6070f574a3dcb URL: https://source.winehq.org/git/wine.git/?a=commit;h=2fe859b8ef0344d216b585ba… Author: Byeongsik Jeon <bsjeon(a)hanmail.net> Date: Wed Oct 24 01:07:11 2018 +0900 gdi32: Support other settings for obtaining the default_aa_flags value. Signed-off-by: Byeongsik Jeon <bsjeon(a)hanmail.net> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/freetype.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 5b1a23b..7cc42b2 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2812,6 +2812,15 @@ static void init_fontconfig(void) pFcConfigSubstitute( NULL, pattern, FcMatchFont ); default_aa_flags = parse_aa_pattern( pattern ); pFcPatternDestroy( pattern ); + + if (!default_aa_flags) + { + FcPattern *pattern = pFcPatternCreate(); + pFcConfigSubstitute( NULL, pattern, FcMatchPattern ); + default_aa_flags = parse_aa_pattern( pattern ); + pFcPatternDestroy( pattern ); + } + TRACE( "enabled, default flags = %x\n", default_aa_flags ); fontconfig_enabled = TRUE; }

1 0

Byeongsik Jeon : gdi32: Remove the code that doesn' t work as intended around FcFontList().
by Alexandre Julliard 29 Oct '18

29 Oct '18

Module: wine Branch: master Commit: af90ab3259f6cd3c95b21dccdfd77c4db27db345 URL: https://source.winehq.org/git/wine.git/?a=commit;h=af90ab3259f6cd3c95b21dcc… Author: Byeongsik Jeon <bsjeon(a)hanmail.net> Date: Mon Oct 29 21:50:20 2018 +0900 gdi32: Remove the code that doesn't work as intended around FcFontList(). Signed-off-by: Byeongsik Jeon <bsjeon(a)hanmail.net> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/freetype.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 7cc42b2..e37880a 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -176,9 +176,6 @@ MAKE_FUNCPTR(FcConfigSubstitute); MAKE_FUNCPTR(FcFontList); MAKE_FUNCPTR(FcFontSetDestroy); MAKE_FUNCPTR(FcInit); -MAKE_FUNCPTR(FcObjectSetAdd); -MAKE_FUNCPTR(FcObjectSetCreate); -MAKE_FUNCPTR(FcObjectSetDestroy); MAKE_FUNCPTR(FcPatternCreate); MAKE_FUNCPTR(FcPatternDestroy); MAKE_FUNCPTR(FcPatternGetBool); @@ -2796,9 +2793,6 @@ static void init_fontconfig(void) LOAD_FUNCPTR(FcFontList); LOAD_FUNCPTR(FcFontSetDestroy); LOAD_FUNCPTR(FcInit); - LOAD_FUNCPTR(FcObjectSetAdd); - LOAD_FUNCPTR(FcObjectSetCreate); - LOAD_FUNCPTR(FcObjectSetDestroy); LOAD_FUNCPTR(FcPatternCreate); LOAD_FUNCPTR(FcPatternDestroy); LOAD_FUNCPTR(FcPatternGetBool); @@ -2829,7 +2823,6 @@ static void init_fontconfig(void) static void load_fontconfig_fonts(void) { FcPattern *pat; - FcObjectSet *os; FcFontSet *fontset; int i, len; char *file; @@ -2838,13 +2831,15 @@ static void load_fontconfig_fonts(void) if (!fontconfig_enabled) return; pat = pFcPatternCreate(); - os = pFcObjectSetCreate(); - pFcObjectSetAdd(os, FC_FILE); - pFcObjectSetAdd(os, FC_SCALABLE); - pFcObjectSetAdd(os, FC_ANTIALIAS); - pFcObjectSetAdd(os, FC_RGBA); - fontset = pFcFontList(NULL, pat, os); - if(!fontset) return; + if (!pat) return; + + fontset = pFcFontList(NULL, pat, NULL); + if (!fontset) + { + pFcPatternDestroy(pat); + return; + } + for(i = 0; i < fontset->nfont; i++) { FcBool scalable; DWORD aa_flags; @@ -2875,7 +2870,6 @@ static void load_fontconfig_fonts(void) ADDFONT_EXTERNAL_FONT | ADDFONT_ADD_TO_CACHE | ADDFONT_AA_FLAGS(aa_flags) ); } pFcFontSetDestroy(fontset); - pFcObjectSetDestroy(os); pFcPatternDestroy(pat); }

1 0

Byeongsik Jeon : gdi32: Respect the FC_ANTIALIAS setting for the FC_RGBA_NONE case.
by Alexandre Julliard 29 Oct '18

29 Oct '18

Module: wine Branch: master Commit: 2b52474fdd192d466f3ccf24bf6ad623eff6a659 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2b52474fdd192d466f3ccf24… Author: Byeongsik Jeon <bsjeon(a)hanmail.net> Date: Mon Oct 29 21:50:21 2018 +0900 gdi32: Respect the FC_ANTIALIAS setting for the FC_RGBA_NONE case. Signed-off-by: Byeongsik Jeon <bsjeon(a)hanmail.net> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/freetype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index e37880a..b62288c 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2772,7 +2772,7 @@ static UINT parse_aa_pattern( FcPattern *pattern ) case FC_RGBA_BGR: aa_flags = WINE_GGO_HBGR_BITMAP; break; case FC_RGBA_VRGB: aa_flags = WINE_GGO_VRGB_BITMAP; break; case FC_RGBA_VBGR: aa_flags = WINE_GGO_VBGR_BITMAP; break; - case FC_RGBA_NONE: aa_flags = GGO_GRAY4_BITMAP; break; + case FC_RGBA_NONE: aa_flags = aa_flags ? aa_flags : GGO_GRAY4_BITMAP; break; } } return aa_flags;

1 0

Byeongsik Jeon : po: Update Korean translation.
by Alexandre Julliard 29 Oct '18

29 Oct '18

Module: wine Branch: master Commit: 7b5160d4fe3ccd61291bc9ce68e3309b434aac94 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7b5160d4fe3ccd61291bc9ce… Author: Byeongsik Jeon <bsjeon(a)hanmail.net> Date: Mon Oct 29 22:12:13 2018 +0900 po: Update Korean translation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46050 Signed-off-by: Byeongsik Jeon <bsjeon(a)hanmail.net> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ko.po | 2644 ++++++++++++++++++++++++++++---------------------------------- 1 file changed, 1207 insertions(+), 1437 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=7b5160d4fe3ccd61291b…

1 0