October 2007 - Wine-devel - list.winehq.org

Re: user32: Add more listbox message tests, make them pass under Wine
by Alexandre Julliard 16 Oct '07

16 Oct '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -533,8 +538,11 @@ static INT LISTBOX_GetItemFromPoint( LB_DESCR *descr, INT x, INT y ) > static void LISTBOX_PaintItem( LB_DESCR *descr, HDC hdc, const RECT *rect, > INT index, UINT action, BOOL ignoreFocus ) > { > - LB_ITEMDATA *item = NULL; > - if (index < descr->nb_items) item = &descr->items[index]; > + LB_ITEMDATA *item; > + > + if (index >= descr->nb_items) return; > + > + item = &descr->items[index]; This will break the painting of a focus rect for an empy listbox. We are supposed to show a focus rect on the first item when the listbox has focus, even if there are no items. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [SPAM] Re: USER32: fix EM_SETLIMITTEXT with zeroed args (with tests)
by Alexandre Julliard 16 Oct '07

16 Oct '07

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > * Implement OS version-dependent behavior for EM_SETTEXTLIMIT There's no reason to make this OS-dependent, unless you really have an app that checks the version and breaks if the limit is too high. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wordpad: Refuse to load OLE compound storage files like Windows does
by Alexandre Julliard 16 Oct '07

16 Oct '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + IStorage *stg; > + > + if (StgOpenStorage(szOpenFileName, NULL, STGM_SHARE_DENY_WRITE | STGM_READ, > + NULL, 0, &stg) == S_OK) > + { > + IStorage_Release(stg); > + MessageBoxW(hMainWnd, MAKEINTRESOURCEW(STRING_OLE_STORAGE_NOT_SUPPORTED), wszAppTitle, > + MB_OK | MB_ICONEXCLAMATION); > + return; > + } It would be more efficient to simply check the magic number, particularly since we already have support for doing that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: Fix NtAccessCheck for NULL, but present SACLs and DACLs.
by Juan Lang 15 Oct '07

15 Oct '07

Hi Rob, - sd.sacl_len = (present ? sacl->AclSize : 0); + sd.sacl_len = ((present && dacl) ? sacl->AclSize : 0); Shouldn't that be ((present && sacl) ? sacl->AclSize : 0); ? --Juan

2 1

re: Make test drill, next steps, call for help with Winetest
by Dan Kegel 15 Oct '07

15 Oct '07

>> There is a headless operation mode already, it detects >> if you run it as a service, and skips appropriate tests. > > Perhaps on Windows; I'm focused on Linux. How about wine net start winetest? <ducks> - Dan

1 0

Re: Have `make distclean` also remove .i and .s files
by Alexandre Julliard 15 Oct '07

15 Oct '07

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > After using GCC's -save-temps option to debug something, I noticed > that `make distclean` fails to actually remove .i and .s files. > > This patch fixes it. I hope it's the right place to make this change? It would be, but I don't think we want make clean to remove all possible output files from all possible tools. The current list is probably too much already, it should really be limited to files that are generated as part of the normal build process. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: First batch of Swedish translation patches
by James Hawkins 15 Oct '07

15 Oct '07

On 10/15/07, Daniel Nylander <po(a)danielnylander.se> wrote: > > Here is the first batch of Swedish translation patches. > One patch per email. -- James Hawkins

1 0

Re: Patch for adding Swedish localization
by Robert Shearman 15 Oct '07

15 Oct '07

Daniel Nylander wrote: > Here is the patch to add Swedish localization files to Wine. > Sorry, this is my first patch using git and I'm really unsure if I did > it correctly. > You need to use git-add to include the new files in the commit/patch you sent. -- Rob Shearman

3 6

make crosstest - a catastrophic saga
by Pedro Araújo 15 Oct '07

15 Oct '07

Hi all, I've been consistently failing to 'make crosstest'... I've already tried my distro's repositories, Hans Leidekker's patches, all to no avail. I wish I could use the test suite, but I need some custom local tests and therefore I need to be able to build win32 executables. However, I'm stuck getting this: > security.cross.o: In function `test_ConvertSecurityDescriptorToString':/home/foo/Wine/dlls/advapi32/tests/security.c:1996: undefined reference to `_CreateWellKnownSid(a)16' > :/home/foo/Wine/dlls/advapi32/tests/security.c:2006: undefined reference to `_CreateWellKnownSid(a)16' > collect2: ld returned 1 exit status > make[2]: *** [advapi32_crosstest.exe] Error 1 > make[2]: Leaving directory `/home/fooer/Wine/dlls/advapi32/tests' > make[1]: *** [advapi32/tests/__crosstest__] Error 2 > make[1]: Leaving directory `/home/fooer/Wine/dlls' > make: *** [dlls/__crosstest__] Error 2 or this, if I 'make crosstest -C dlls/gdi32/tests/': > bitmap.cross.o: In function `test_GdiAlphaBlend':/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1870: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1872: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1874: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1875: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1876: undefined reference to `_GdiAlphaBlend(a)44' > bitmap.cross.o:/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1877: more undefined references to `_GdiAlphaBlend(a)44' follow > collect2: ld returned 1 exit status > make: *** [gdi32_crosstest.exe] Error 1 > make: Leaving directory `/home/fooer/Wine/dlls/gdi32/tests' What am I doing wrong? - Pedro. -- "Compatibility means deliberately repeating other people's mistakes." (David J. Wheeler)

2 1

Re: RICHED20: EM_SETTEXTEX must support RTF strings too
by Daniel Remenak 15 Oct '07

15 Oct '07

When you fix bugs that are documented in comments, please fix the comments also. At the top of the file: EM_SETTEXTEX 3.0 (no rich text insertion handling, proper style?) And in the case itself /* FIXME: this should support RTF strings too, according to MSDN */ Thanks, Daniel Remenak On 10/13/07, a_villacis(a)palosanto.com <a_villacis(a)palosanto.com> wrote: > Another fix for Zoiper (www.zoiper.com) This app can display an About dialog > with a richedit control that displays program credits. The text is a RTF > string pasted with EM_SETTEXTEX, which should result in formatted text being > displayed, but instead results in raw display of RTF codes. The attached > patch fixes this. > > Changelog: > * EM_SETTEXTEX should also support RTF strings, just like WM_SETTEXT > > > >

1 0