October 2007 - Wine-devel - list.winehq.org

Re: [PATCH] wininet: Close sockets open in http requests
by Nigel Liang 17 Oct '07

17 Oct '07

On 10/13/07, Nigel Liang <ncliang(a)gmail.com> wrote: > Hi, > > Http requests open sockets and forget to close them. Left running over a long > period, the socket file descriptor starts getting large. Once it exceeds > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > > -Nigel > > --- > dlls/wininet/internet.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 0edca74..8e3a98e 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -1014,6 +1014,9 @@ BOOL WINAPI InternetCloseHandle(HINTERNE > return FALSE; > } > > + if (lpwh->htype == WH_HHTTPREQ) > + NETCON_close(&((LPWININETHTTPREQW)lpwh)->netConnection); > + > WININET_Release( lpwh ); > WININET_FreeHandle( hInternet ); > > -- > 1.4.1 > > Hi, This patch was sent 4 days ago and it hasn't gone in yet. Could anyone give me some comments on it? Dan filed bug 10032 which is related to this. While we shouldn't be using select() on high FDs for networking, this patch closes the sockets that were open by http requests to avoid getting to high FDs... Thanks, -Nigel

1 0

wnaspi and DVD Burner
by Stefan Leichter 17 Oct '07

17 Oct '07

Hello, i tried to make some progress with Ahead Nero, but now i'm stuck. I found the NeroSDK-1.08.zip and inside the comand line tool NeroAPITest.exe. The source code of NeroAPITest.exe is in the archive too. This makes finding the problems easier. Executing the comand 'wine NeroAPITest.exe --listdrives' the open function in SCSI_OpenDevice fails first with ENOMEDIUM. Putting a disk into the drive the command fails with errno 30 (Read-only). Opening the drive read only works, but next is a write on the file descriptor that fails because it was opened readonly ... The scenario above fails only for my PATA DVD burner. My SCSI DVD reader and my SCSI CD reader are working well with the command sequence listed above. My OS is Debian etch (32bit) the burner is a Plextor PX-716A. Is the reason for this the difference between IDE and SCSI in the kernel? Is it a fault of the DVD burner device (firmware)? What might be a workaround for the problem? Thanks for your thought Stefan

1 0

Wine Stats Malfunctioning
by luis.busquets＠ilidium.com 17 Oct '07

17 Oct '07

Web page: http://www.winehq.org/site/winapi_stats on wine statistics does not work.

2 1

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW.txt
by Frank Richter 17 Oct '07

17 Oct '07

On 17.10.2007 06:49, Nigel Liang wrote: > Hi, > > strchrW assumes a NULL-terminated string. May crash if terminating character is > not found. memchrW is better because you can specify the maximum number of > bytes to search. On the flipside, memchrW() doesn't stop at a NUL... -f.r.

2 1

Possible WIne regression with Warcraft
by Michael Lothian 17 Oct '07

17 Oct '07

Hi I've noticed a problem in wine recently. When I try and join a network game in Warcraft I can see the game but I'm unable to join it. These errors are printing out: fireburn(a)tau ~/.wine/drive_c/Program Files/Warcraft III $ wine Frozen\ Throne.exe ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib control.c:909:(snd_ctl_open_noupdate) Invalid CTL default:0 err:ole:CoCreateInstance apartment not initialised fixme:advapi:SetSecurityInfo stub fixme:win:EnumDisplayDevicesW ((null),0,0x34f3d8,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f7b0,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f3bc,0x00000000), stub! fireburn(a)tau ~/.wine/drive_c/Program Files/Warcraft III $ fixme:winsock:WSAIoctl unsupported WS_IOCTL cmd (9800000c) fixme:mswsock:AcceptEx (listen=8552, accept=8564, 0x31100e8, 0, 32, 32, 0x34f498, 0x31100b8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8568, 0x3110170, 0, 32, 32, 0x34f498, 0x3110140), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8572, 0x31101f8, 0, 32, 32, 0x34f498, 0x31101c8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8576, 0x3110280, 0, 32, 32, 0x34f498, 0x3110250), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8580, 0x3110308, 0, 32, 32, 0x34f498, 0x31102d8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8584, 0x3110390, 0, 32, 32, 0x34f498, 0x3110360), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8588, 0x3110418, 0, 32, 32, 0x34f498, 0x31103e8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8592, 0x31104a0, 0, 32, 32, 0x34f498, 0x3110470), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8596, 0x3110528, 0, 32, 32, 0x34f498, 0x31104f8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8600, 0x31105b0, 0, 32, 32, 0x34f498, 0x3110580), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8604, 0x3110638, 0, 32, 32, 0x34f498, 0x3110608), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8608, 0x31106c0, 0, 32, 32, 0x34f498, 0x3110690), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8612, 0x3110748, 0, 32, 32, 0x34f498, 0x3110718), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8616, 0x31107d0, 0, 32, 32, 0x34f498, 0x31107a0), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8620, 0x3110858, 0, 32, 32, 0x34f498, 0x3110828), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8624, 0x31108e0, 0, 32, 32, 0x34f498, 0x31108b0), not implemented fixme:imm:ImmAssociateContextEx (0x30028, (nil), 16): stub I'm going to try rolling back to an old version of Wine, I currently use the latest git. I'll post back if it does work. Mike

4 7

Re: widl [1/2]: Improve file cleanup when errors occur
by Alexandre Julliard 17 Oct '07

17 Oct '07

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -446,10 +441,18 @@ static void rm_tempfile(void) > abort_import(); > if(temp_name) > unlink(temp_name); > - if (header_name) > - unlink(header_name); > - if (client_name) > - unlink(client_name); > - if (server_name) > - unlink(server_name); > + if (nerrors) { > + if (do_header) > + unlink(header_name); > + if (do_client) > + unlink(client_name); > + if (do_server) > + unlink(server_name); > + if (do_idfile) > + unlink(idfile_name); > + if (do_proxies) > + unlink(proxy_name); > + if (do_typelib) > + unlink(typelib_name); > + } This will break cleanup on signals. I think it's better to always remove the files instead of relying on the error count being set correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

"make test" failure in gdi32/bitmap.c
by Dan Kegel 17 Oct '07

17 Oct '07

"make test" fails for me with: bitmap.c:1113: Test failed: GetDIBits with 4 bpp DIB selected in DC: Invalid DIB bits bitmap.c:1113: Test failed: GetDIBits with 8 bpp DIB selected in DC: Invalid DIB bits err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=24 err:bitmap:DIB_GetBitmapInfo (39): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (11): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (13): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (16): unknown/wrong size for header make[2]: *** [bitmap.ok] Error 2 make[2]: Leaving directory `/home/dank/wine-git/dlls/gdi32/tests' I think this is new since I last ran the tests (at wineconf)...?

3 2

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA.txt
by Dmitry Timoshkov 17 Oct '07

17 Oct '07

"Nigel Liang" <ncliang(a)gmail.com> wrote: > + ok( GetLastError() == ERROR_INVALID_PARAMETER, "Last error wrong: %p\n", > + GetLastError()); GetLastError() returns not a pointer. -- Dmitry.

1 0

Wine 1.0 bugs, release criteria
by Denali Coldstar 16 Oct '07

16 Oct '07

Dan Kegel <dank <at> kegel.com> writes: >* *>* At Wineconf 2007, I was appointed to be the guy who decides *>* (with Alexandre's approval) what bugs are 1.0 bugs and what aren't. *>* So I've started adjusting the "Target Release" fields on a few *>* bugs in Bugzilla. *>* Over the next month or so, I'd like Wine developers to nominate important * >* Comments? *>* - Dan *>* *> === Good Afternoon, I believe Ventrilo meets the criteria set forth in http://wiki.winehq.org/WineReleaseCriteria. In the gaming community, when you use VOIP applications, it generally boils down to TeamSpeak and Ventrilo. While TeamSpeak has a Linux native client, Ventrilo doesn't. I can't necessarily say Vent holds 50% of the market, but I feel safe in saying it holds a significant share of it. This is mainly based on the fact several companies have sprung up over the years to offer hosting of Vent servers. The client can be freely downloaded from the Ventrilo website ( http://www.ventrilo.com/download.php) but I'm not sure if it can be grabbed with wget. Lastly, it does not have an autoupdate but it will pop up a notice if a new version is available. If it is found that Ventrilo would be a suitable program for consideration in the 1.0 release, the following issues would need to be addressed: http://bugs.winehq.org/show_bug.cgi?id=1348 http://bugs.winehq.org/show_bug.cgi?id=5178 http://bugs.winehq.org/show_bug.cgi?id=5924 http://bugs.winehq.org/show_bug.cgi?id=5978 Thank you for reading this post. Steve

2 1

Error compiling progman
by Daniel Nylander 16 Oct '07

16 Oct '07

I have some problems compiling progman. gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o string.o string.c ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -forsrc.res rsrc.rc Xx.rc:23:8: Error: syntax error make: *** [rsrc.res] Error 1 Line 23 in Xx.rc looks like this: CONCAT(MENU_, LANGUAGE_ID) MENU What could be the problem? -- Daniel Nylander (CISSP, GCUX, GCFA) Stockholm, Sweden http://www.DanielNylander.se info(a)danielnylander.se yeager(a)ubuntu.com dnylande(a)gnome.org

2 1