October 2007 - Wine-devel - list.winehq.org

Direct3D Game test framework
by Stefan Dösinger 21 Dec '07

21 Dec '07

Hi, Now that we're facing Direct3D 9 feature completion soon - VTF support coming in from Henri, High order patches and thread safety from me - the d3d work will change a bit soon. Instead of adding new features we'll debug games and improve performance. It would be good if we had some automated testing framework to support the process :-) Unfortunately this isn't easy. Games do not render exactly, so verifying that a game doesn't show any visual regressions automatically may be more effort than reward. Here I think we'll have to rely on users testing the games regularly and testing regressions. I am more concerned about the performance thing. It is very easy to make some performance improvement that does more harm than good. Also benchmarks take quite some time and are affected by many external parameters. So I'd like some automated and controlled performance testing environment. Instead of building one from scratch it would be cool if we could reuse existing software. cxtest comes to my mind(www.cxtest.org). It is a test suit built by codeweavers for running regression tests on Windows apps. It can remote control applications using keyboard input and compares screenshots to reference ones. It could be used to start benchmarks automatically. A plus here is that some machines run nightly tests. However, those are VMs, so no 3D acceleration. A problem is also reading back the results. Does anyone know some applications for doing that? Windows or Linux apps, commercial or open source ones(prefered, though). Then we need benchmarking apps. Here regular Windows benchmarks come to my mind(3DMarkXYZW), games with benchmark facilities(hl2, ut, ...). We can record tests, get a reference performance counter from windows and run nightly tests(or manually started tests). A problem we're facing is reading back the results. Taking screenshots and running OCR on them is error prone, we need a way to get the numbers from the benchmarks, not an image of the numbers. Now we need a concrete collection of benchmarks. A mixture of popular Benchmarks like 3DMark would be good, and some more cientific benchmarks. So far I have: 3DMark: Popular benchmark for testing the overall performance, doesn't give very detailed results though. Controlling: Standard windows controls, keyboard events should do the job Result readback: Can write results to a file, but must take care about the licensing. Not everything is free, most likely a license is needed. Half-Life 2: Nice facility of recordable timedemos. Can record average game demos, but also demos which stress specific features. Controlling: Command line parameters Result readback: Can be asked to copy the console into the clipboard UT2004: Popular engine. Has a Linux port, but many mods only ship the d3d renderer. Controlling: Unknown Result readback: unknown. DirectX sdk demos, nvidia / ati demos: Stress specific rendering features. Good for testing performance(with vsync removed), or a bad idea? Controlling, Readback: Source code is available and can be modified. License, especially possible benchmark clauses? Other suggestions? Another nice-to-have thing would be a game independent profiling method, simmilar to the +fps debug channel, just more detailed. Some games do not have built-in benchmarking, it would still be nice to use them. That means facing some new problems? How to tell loading from in-game rendering? How to remove control those games in a repeatable way, especially if there are some random elements in the game? More detailed data from wined3d could also be used to draw nice graphs for other benchmarks :-) We'll need some hardware diversity too. It would be nice if the tests worked on Linux and MacOS, and a variety of hardware was used. I want at least nvidia, ati and intel gpu's, older and newer ones. I could also revive my ATI mach64 :-) Any other comments or suggestions? I think once I'm done with the current exam season and my patch backlog is in I will retire from direct wined3d development for a few days / weeks to set up a testing environment, then start fixing games.

10 40

Work legalities
by Nathan Williams 11 Dec '07

11 Dec '07

Hey everyone, I have been planning to do some work on wine for a while now, but after I started working I got myself a new programming job. I'm worried about the copyright of any external work I do, so I need a little advice. What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? -- Nathan

10 12

Re: dlls/comctl32/listview.c warning elimination
by Alexandre Julliard 08 Dec '07

08 Dec '07

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Not a patch I am particularily proud of, but the best way I found to get > rid of > > listview.c:5043: warning: 'strW' might be used uninitialized in this function > > issued by GCC, and apart from the added cast it actually is simpler than > the original. It was done the way it is precisely to avoid the non-const cast, which triggers a warning too. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Patch: ntoskrnl.exe - Added PsCreateSystemThread
by Stefan Dösinger 15 Nov '07

15 Nov '07

Am Donnerstag, 20. September 2007 03:49:40 schrieb Carroll Vance: > I have tested this with a driver I made and it seemed to > work fine. I don't know much about ntoskrnl.exe, but if you have a test driver, you may want to include it in the patch. Other libraries have a set of regression tests in dlls/<lib>/tests . ntoskrnl.exe doesn't have any yet, but I don't know if that is a policy or just because no one started it yet.

2 1

alsa->pulseaudio->alsa directsound hang
by Al Tobey 10 Nov '07

10 Nov '07

I spent some time this evening playing around with trying to get wine sound output to go through pulseaudio on my fc8/rawhide (x86_64) box. I tried wine 0.9.43 (built), 0.9.47 (fc8 rpm), and Crossover 6.2.0. I was testing with Steam/TF2, but found that the same issue comes up with a install of Winamp Lite using its default DirectSound output plugin. If I configure nothing and let wine grab the soundcard (I have an Audigy, so it allows multiple streams), it works fine. If I configure it to use pulseaudio through the alsa plugin, it hangs. I see the stream show up in the pulseaudio volume control, but nothing plays and winamp's meter and progress bar are inactive. The "Test Sound" button in winecfg works and shows up in pavucontrol as a mono stream. I've tried numerous variations on emulation and bitrates with no change. I didn't have any luck getting the ESD support (which would go straight to PA) to even show up in winecfg, even after forcing it in regedit. I probably missed something obvious. I'll do some more debugging tomorrow, but I thought I'd throw my config out there for others to experiment with and ridicule. There isn't much out on Google about this kind of config yet, but I expect there will be more requests as the popularity of pulseaudio goes up, especially with the release of fc8. I think the latest Ubuntu has it enabled by default, too. Did anybody actually write a patch to directly support pulseaudio or was the earlier discussion devoid of code? My registry mods and .asoundrc for using the alsa/pulseaudio plugin are attached. Getting pulseaudio is left as an exercise to the reader ;) Thanks, -Al

3 4

CryptAcquireContext Failure, default/Type 024 requested
by Rob Seger 09 Nov '07

09 Nov '07

Wine currently supports types 001 and 012, but I have a new game attempting to use type 024 (Software\\Microsoft\\Cryptography\\Defaults \\Provider Types\\Type 024). I've googled, as well as searched MSDN, for a reference as to what the crypt provider type 024 even is with no success. Does anyone know? Looking through the advapi32.dll code, this looks like it might be a serious undertaking to implement. Is that estimation accurate? Does anyone have any tips or pointers about implementing an entire CSP in wine? I appreciate any help, keep up the good work all! Rob

3 7

Wine 1.0 bugs, release criteria
by Dan Kegel 04 Nov '07

04 Nov '07

At Wineconf 2007, I was appointed to be the guy who decides (with Alexandre's approval) what bugs are 1.0 bugs and what aren't. So I've started adjusting the "Target Release" fields on a few bugs in Bugzilla. Over the next month or so, I'd like Wine developers to nominate important bugs for 1.0 by setting their "target release" field to 1.0. Later on we'll clean up and freeze the list somehow. Also, I've put together a draft wiki page with our 1.0 release criteria; it's at http://wiki.winehq.org/WineReleaseCriteria Comments? - Dan

9 13

Generic text printer driver
by Juan Luis Ramos 02 Nov '07

02 Nov '07

Hi all, is there anybody working in the generic text printer driver o raw printer driver? I've a problem with a compatible Epson POS printer so, I've modified the text.c code inside wineps.drv to send the text to the printer without postscript processing. The function that send the data is PSDRV_ExtTextOut, but the LPCWSTR parameter passed (str) doesn't contain the ESCAPE codes sent to the printer. I don't find when does the program call the PSDRV_ExtTextOut function. Can anybody help me? Thanks.

2 1

Valgrind and structs with holes
by Dan Kegel 02 Nov '07

02 Nov '07

Valgrind is a great tool, but if there's a struct with a hole in it, and we write that struct to a socket (say, to send it to the server), valgrind will likely complain that the hole is uninitialized. For instance, the warning ==3415== Syscall param writev(vector[1]) points to uninitialised byte(s) ==3415== at 0x40007F2: (within /lib/ld-2.6.1.so) ==3415== by 0x4412E24: wine_server_call (server.c:244) ==3415== by 0x43EBA73: server_ioctl_file (file.c:1010) ==3415== by 0x43EC570: NtFsControlFile (file.c:1223) ==3415== by 0x45394C1: WaitNamedPipeW (sync.c:1298) ==3415== by 0x453963B: WaitNamedPipeA (sync.c:1225) ==3415== by 0x46490B5: test_CreateNamedPipe (pipe.c:97) in kernel32/tests/sync.c can be silenced either by appeasing Valgrind with a patch like --- a/dlls/kernel32/sync.c +++ b/dlls/kernel32/sync.c @@ -1285,6 +1285,12 @@ BOOL WINAPI WaitNamedPipeW (LPCWSTR name, DWORD nTimeOut) return FALSE; } + /* FILE_PIPE_WAIT_FOR_BUFFER has a hole after boolean TimeoutSpecified. + * Clear the hole so valgrind doesn't get upset about uninitialized bytes. + * No need to zero Name[1...], which is initialized ok later. + */ + memset(pipe_wait, 0, sizeof(FILE_PIPE_WAIT_FOR_BUFFER)); or by using a suppression like { wine_struct_hole_FILE_PIPE_WAIT_FOR_BUFFER Memcheck:Param writev(vector[1]) obj:* fun:wine_server_call fun:server_ioctl_file fun:NtFsControlFile fun:WaitNamedPipeW } Alexandre, which approach would you prefer? If you say #1, I'll eat my hat. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Wine Gecko packaging
by Jacek Caban 01 Nov '07

01 Nov '07

Hello, As you probably have noticed, downloading Gecko on first use confuses users. Now, with last week patches, there is an other way to do it, transparent for users. MSHTML code looks for cab file in $data_dir/gecko (that is usually /usr/share/wine/gecko). Alternatively, if you run Wine from build dir, it looks for $build_dir/../gecko. Wine checks it both in wineprefixcreate and, if Gecko is not installed, on first usage. It means that if you download wine_gecko-0.1.0.cab from SourceForge and put it in the right place, you will no longer have to care about installing Gecko. Now, it's time to consider Linux packages to simplify its use. In Gentoo it may be a separate USE flag, but for other distributions that don't support such things, we'll need a separate package. Such package will need only one file placed in the right place, so it should be easy to do and maintain (I don't expect versions to change often). Are Wine packagers interested in creating Gecko packages? Thanks, Jacek

4 6