October 2007 - Wine-devel - list.winehq.org

Compile error with current git
by Paul Vriens 30 Oct '07

30 Oct '07

Hi, Compiling gives (for me): [paul(a)penguin wine-git]$ cd /wine/wine-git/dlls/ntdll/ [paul(a)penguin ntdll]$ make depend && make ../../tools/makedep -C. -S../.. -T../.. actctx.c atom.c cdrom.c critsection.c debugbuffer.c debugtools.c directory.c env.c error.c exception.c file.c handletable.c heap.c large_int.c loader.c loadorder.c misc.c nt.c om.c path.c process.c reg.c relay.c resource.c rtl.c rtlbitmap.c rtlstr.c sec.c serial.c server.c signal_i386.c signal_powerpc.c signal_sparc.c signal_x86_64.c string.c sync.c tape.c thread.c threadpool.c time.c version.c virtual.c wcstring.c version.rc gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o file.o file.c file.c: In function ‘NtCreateFile’: file.c:199: error: ‘struct object_attributes’ has no member named ‘name_len’ make: *** [file.o] Error 1 This is after commit 5f5df83281a48df7746ff263b5047cffe4c3c1fa I guess. -- Cheers, Paul.

1 1

re: tools/widl/typegen.c pointer initialization
by Dan Kegel 30 Oct '07

30 Oct '07

Dan H. wrote: > If you tell me what options you build with and I can reproduce the > warning then I'll be more than happy to try to fix it. I build widl > with -W -Wall and get two warnings. To get uninitialized warnings, you have to also specify optimization (-O2). Without -O, gcc doesn't do the analysis that can detect uninitialized variables. - Dan

3 2

New Wine help and discussion forum
by Tom Wickline 30 Oct '07

30 Oct '07

Hello, There is a new Wine help and discussion forum at http://www.wine-forum.org/index.php that is meant to be a meeting place for anyone interested in Wine usage or development. In the past there there has never been a single forum dedicated solely to Wine. The lack of a single forum has left people to post Wine related help and discussions in other forums. At the moment most users turn to their Linux distribution forum where Wine is often a sub-forum at most and questions often go unanswered. My goal is to provide a forum to bring Wine users together into a single meeting place to discuss anything relevant to the daily happenings surrounding Wine. There are multiple categories/subforums to cover all aspects of using Wine (Applications, Games, 3rd Party Wine Utilities, Commercial Offerings, etc.). Cheers, Tom Wickline

8 9

Re: ntdll: RtlCreateAcl: initialize all the bytes passed by the user
by Alexandre Julliard 30 Oct '07

30 Oct '07

"Dan Kegel" <dank(a)kegel.com> writes: > Without this patch, NtAccessCheck() references uninitialized > memory (it seems to send the entire ACL with the user's > length to the server, not just sizeof(ACL)). This showed up as > valgrind errors when running "make test" in advapi32. > I suppose the right fix might be to send just sizeof(ACL) bytes > to the server, but I wouldn't know, and initializing all > the bytes given by the caller seems innocuous enough. It isn't innocuous, if Windows doesn't do it then it's quite likely that apps will pass a too large size, we've had that kind of problem in some other places already. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Resubmit]: Added wrapper dll for ct-api(CardTerminal API)
by Alexandre Julliard 30 Oct '07

30 Oct '07

"Christian Eggers" <ceggers(a)gmx.de> writes: > + /* Try to get name of low level library from registry */ > + /* UNICODE functions are not used here, because the final string is needed as ANSI */ Actually the final string should be in the Unix codepage, so you have to load it using Unicode and then convert to CP_UNIXCP. > + result = RegOpenKeyExA(HKEY_CURRENT_USER, "Software\\Wine\\DllWrappers", 0, KEY_READ, &key_handle); The key should go under Software\\Wine\\ctapi32, I don't think there's a need to add a generic mechanism here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Missing region invalidation in edit control
by Peter Åstrand 30 Oct '07

30 Oct '07

It seems like there's a missing region invalidation in the edit control somewhere; the background is not correctly updated, unless the window is moved or exposed to X11 exposes. See screenshot at http://www.cendio.com/~astrand/wine/46-textedit-color/nopaint.png. In this case, xclock has been dragged over the edit control area, which is then correctly painted white. Any ideas? Regards, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00 ThinLinc User Group 2007 Höstkonferens --- 15-16 november, Linköping. Program och anmälan: http://www.thinlincusergroup.se/aktiviteter

1 1

Re: widl: Add a --local-stubs option.
by Robert Shearman 30 Oct '07

30 Oct '07

Dan Hipschman wrote: > + write_type_decl_left(fp, mdef->type); > + fprintf(fp, " CALLBACK %s_", iface->name); > + write_name(fp, mdef); > + fprintf(fp, "_Proxy(\n"); > + write_args(fp, m->args, iface->name, 1, TRUE); > + fprintf(fp, ")"); > + if (body) { > + type_t *rt = mdef->type; > + fprintf(fp, "\n{\n"); > + fprintf(fp, " %s\n", comment); > + if (rt->name && strcmp(rt->name, "HRESULT") == 0) > + fprintf(fp, " return E_FAIL;\n"); > > It would be better to make the default implementation of the stubs return E_NOTIMPL instead of E_FAIL, since the former is a lot more specific and makes identifying the source of misbehaviour of an application easier. -- Rob Shearman

1 0

Re: oleaut32 [3/10]: Add a proxy for objidl.
by Robert Shearman 30 Oct '07

30 Oct '07

Dan Hipschman wrote: > This adds the objidl proxy to oleaut32. It also updates DllGetClassObject > to fall back on OLEAUTPS_DllGetClassObject. This is basically what would > happen if we had a dlldata.c file for oleaut32, but that's impossible > since oleaut32 is too special a case. > > --- > .gitignore | 2 ++ > dlls/oleaut32/Makefile.in | 3 ++- > dlls/oleaut32/oleaut.c | 3 +-- > dlls/oleaut32/oleaut32_objidl.idl | 25 +++++++++++++++++++++++++ > dlls/oleaut32/usrmarshal.c | 2 ++ > 5 files changed, 32 insertions(+), 3 deletions(-) > create mode 100644 dlls/oleaut32/oleaut32_objidl.idl > This should be implemented in ole32.dll, not oleaut32.dll, as should unknwn.idl and oleidl.idl. -- Rob Shearman

1 0

Re: New Wine help and discussion forum
by Dan Kegel 30 Oct '07

30 Oct '07

[Hmm, I thought you wanted to take the discussion offlist, but I see you forwarded to the list. Here's a catchup message.] On 10/29/07, Dan Kegel <dank06(a)kegel.com> wrote: > On 10/29/07, Tom Wickline <twickline(a)gmail.com> wrote: > > > My stated goal is to not increase the number of > > > discussion forums / mailing lists, yet still appeal > > > to the "I hate email" generation. I think the > > > google groups front end for the existing mailing > > > list comes pretty close to that... > > > > So your goal is to have a single point for discussion? > > No, my goal is simply to not make the situation worse. [There were more messages after that. Here's the key bit:] Tom wrote: > Whats so bad about both Google groups and a forum? If you try to pull > as many people as you can toward the groups and I do the same for the > forum. then if we get 90% of the discussion on two groups its better > then what the situation was yesterday... do you agree with that? I replied: Having one more forum dilutes the community. ... > If you try to pull > as many people as you can toward the groups and I do the same for the > forum. then if we get 90% of the discussion on two groups its better > then what the situation was yesterday... do you agree with that? Not really. That said, I can see your vision, and I agree there is some small chance it might succeed and improve the situation. The real issues are mixed up with a culture war (email vs. forum), which makes the discussion a bit murky. C'est la vie. - Dan

1 0

Trying to submit my first patch
by crwulff＠rochester.rr.com 29 Oct '07

29 Oct '07

So I tried to submit a patch (to the patch mailing list) a few days ago and got no response (or acceptance), so I'm guessing I need to do something different. It is just a few simple stubs for functions needed to get RO2 (a game) running. The original email is attached. If anyone could tell me what I did wrong it would be appreciated. I'm guessing either because (a) I actually changed the Changelog file and included that in the patch instead of putting it in the email body or (b) nobody is interested in just stubs and I should work on coding them up more (even though it isn't necessary to get the game running.) -- Chris Wulff

2 2