October 2007 - Wine-devel - list.winehq.org

Cleanup of riched20 tests - request for help on test_WM_PASTE
by Alex Villacís Lasso 01 Nov '07

01 Nov '07

I am currently trying to clean up the riched20 tests that are failing in WinXP. While doing this, I have encountered the following problem: on the function test_WM_PASTE() (at line 1959 of dlls/riched20/tests/editor.c in current git), the test is supposed to feed simulated keystrokes corresponding to Ctrl-C, Ctrl-V, and so on, supposedly to test copy and paste features via the keyboard. The problem is that the verification at line 1989 fails on WinXP, because the text on the control has not been modified - the control seems to disregard simulated WM_CHAR messages of the Ctrl-<keystroke> variety. The test at line 1977 succeeds accidentally, because the sequence of Ctrl-C, Ctrl-V, Ctrl-Z that is being tested is equivalent to not modifying the control text at all. A more through test would be to send WM_GETTEXT messages after each step to ensure that the text is actually being modified, but the bigger problem is how to make the control obey the keystrokes in the first place. If I place a message loop right before the DestroyWindow() call, I can send keystrokes manually and they work as expected. Only simulated WM_CHAR messages are being discarded. I have tried changing the SendMessage() calls into PostMessage() calls (since Visual Studio's Spy++ shows that WM_CHAR messages were posted, not sent), but to no avail. I have also tried placing message loops between messages, with no luck. I have even tried to simulate the WM_KEYDOWN and WM_KEYUP messages with parameters exactly as seen by Spy++, but this does not work either. So I am asking for help. What could be going wrong with this test? How can I feed the expected keystrokes so that the test works as expected? Has this test ever worked before? It fails in both WinXP (real machine) and inside a QEMU session running Win98. (All tests on WinXP were compiled with CygWin) -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

1 1

Re: Make test drill, next steps, call for help with Winetest
by Hans Leidekker 01 Nov '07

01 Nov '07

I have written attached script to facilitate automated winetest runs. It needs a VirtualBox virtual machine with either Windows or a Wine platform configured to run autorun.inf files. The script downloads the latest winetest binary and puts it in an iso image, along with an autorun file to trigger its execution when the image is 'inserted' into the virtual drive. A snapshot is used to revert the vm to its original state, so no need to worry about winetest screwing up your installation. -Hans #!/bin/bash if [ $# -lt 2 ]; then echo "Usage: $0 <vmname> <tag>" echo "" echo "vmname: Virtual machine to use (must be in suspended state). echo "tag: Tag built from [-.0-9a-zA-Z] to identify test report. exit 1 fi TMPDIR=/tmp/winetest$$ LOGFILE=$TMPDIR/log mkdir -p $TMPDIR/master echo "downloading winetest binary" wget -P $TMPDIR http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-latest.exe >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi mv $TMPDIR/winetest-latest.exe $TMPDIR/master/winetest.exe echo "creating autorun.inf" cat > $TMPDIR/master/autorun.inf <<_EOF_ [autorun] open=winetest.exe -q -t $2 _EOF_ echo "creating cd image" mkisofs -o $TMPDIR/winetest.iso $TMPDIR/master >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "checking vm $1 state" VBoxManage showvminfo $1 | grep "^State:" | grep "saved" >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "creating snapshot for vm $1" VBoxManage snapshot $1 take before-winetest >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "starting vm $1" VBoxManage startvm $1 >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "waiting until vm $1 is up and running" RUNNING="false" while [ $RUNNING != "true" ] do VBoxManage showvminfo $1 | grep "^State:" | grep "running" >> $LOGFILE 2>&1 if [ $? -eq 0 ]; then RUNNING="true" fi sleep 1 done echo "attaching cd image to vm $1" VBoxManage controlvm $1 dvdattach $TMPDIR/winetest.iso >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "sleeping while vm $1 runs winetest" sleep 1800 # 30 minutes should be enough for winetest to finish echo "suspending vm $1" VBoxManage controlvm $1 savestate >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "waiting until vm $1 is suspended" SAVED="false" while [ $SAVED != "true" ] do VBoxManage showvminfo $1 | grep "^State:" | grep "saved" >> $LOGFILE 2>&1 if [ $? -eq 0 ]; then SAVED="true" fi sleep 1 done echo "reverting vm $1 to previous state" VBoxManage snapshot $1 discardcurrent -all >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi rm -rf $TMPDIR exit 0

5 10

Bug in dlls/oleaut32/tests/vartype.c?
by Gerald Pfeifer 01 Nov '07

01 Nov '07

dlls/oleaut32/tests/vartype.c has the following snippet of code: + f = -1e-400; /* deliberately cause underflow */ + hres = pVarBstrFromR4(f, lcid, 0, &bstr); + ok(hres == S_OK, "got hres 0x%08lx\n", hres); + if (bstr) + { + todo_wine ok(memcmp(bstr, szZero, sizeof(szZero)) == 0, "negative zero (got %s)\n", wtoascii(bstr)); + } which was added in revision 1.27 Alex Villacís Lasso <a_villacis(a)palosanto.com> Test for behavior of negative underflow formatting. This doesn't seem to work as intended, because it is a floating point *constant* which current versions of GCC simply truncate to 0.0. Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 3

Re: wined3d: Enable clip planes with GLSL shader backend
by Stefan Dösinger 31 Oct '07

31 Oct '07

Am Mittwoch, 31. Oktober 2007 18:50:32 schrieb Fabian Bieler: > - glMatrixMode(GL_MODELVIEW); > - glPushMatrix(); > - glLoadMatrixf((float *) > &stateblock->transforms[WINED3DTS_VIEW].u.m[0][0]); + > if(!use_vs(stateblock->wineD3DDevice)) { > + /* Clip Plane settings are affected by the model view in OpenGL, > the View transform in direct3d */ + glMatrixMode(GL_MODELVIEW); > + glPushMatrix(); > + glLoadMatrixf((float *) > &stateblock->transforms[WINED3DTS_VIEW].u.m[0][0]); + } Isn't this going to cause problems with the glPopMatrix afterwards?

1 0

Tips needed for debugging Skype on Wine (Access violation)
by Paul Vriens 31 Oct '07

31 Oct '07

Hi, I'm trying to get Skype 3.5.0.39 running on Wine (latest Git). The app however throws an 'Access violation at address 00593AD1 in module "Skype.exe". Read of address FFFFFFFF'. I've set set the version to XP. I do find that when I apply this "patch": diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index a08235a..d4349d7 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2819,7 +2819,7 @@ BOOL WINAPI IsWow64Process(HANDLE hProcess, PBOOL Wow64Process) { FIXME("(%p %p) stub!\n", hProcess, Wow64Process); *Wow64Process = FALSE; - return TRUE; + return FALSE; } the application has no issues starting up (several other issues remain). Is this an exception that Windows catches and we don't perhaps? The application runs fine on my Windows XP box. Tried to use several debugchannels but to no avail. -- Cheers, Paul.

3 5

Convincing Valgrind to give a stack dump?
by Dan Kegel 31 Oct '07

31 Oct '07

Looking at the app in bug 10125, using warn+heap, I saw a few of those scary-but-sometimes-harmless warnings, so I thought I'd give it a shot under Valgrind. After applying enough suppressions, I did find three interesting valgrind warnings: 10 errors in context 5 of 9: Conditional jump or move depends on uninitialised value(s) at 0x477F7F6: RedrawWindow (painting.c:612) 29 errors in context 7 of 9: Conditional jump or move depends on uninitialised value(s) at 0x43E4E6D: HEAP_ValidateInUseArena (heap.c:917) 184 errors in context 9 of 9: Conditional jump or move depends on uninitialised value(s) at 0x61F3CD0: XcursorImageHash (in /usr/lib/libXcursor.so.1.0.2) The commandline I used was WINEDEBUG=+process valgrind -v --error-limit=no --trace-children=yes --suppressions=$HOME/suppressions ~/wine-git/wine Olb.exe (+process was used to show that the errors in question did indeed come from olb.exe and not something it launched.) But I couldn't coax Valgrind into giving stack dumps for those errors; it acted as if it had seen a few too many errors first, and only showed the one line. Grr. Anyone know how to coax valgrind into always giving a good stack dump? - Dan

2 2

Re: cabinet: fully initialize structs in FCICreate() and FCIAddFile()
by Alexandre Julliard 31 Oct '07

31 Oct '07

"Dan Kegel" <dank(a)kegel.com> writes: > Rather than hunt it down precisely, I applied > the old "memset the struct to zero when allocating" > meme, which in some circles is considered the "right" > way to avoid this kind of problem. (I halfway expect > Alexandre to say "don't be so lazy", but it's worth a try.) Don't be so lazy. ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Changes default socket behavior for WSASendTo function from overlapped to non-overlapped
by Alexandre Julliard 31 Oct '07

31 Oct '07

yurtk(a)mail15.com writes: > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 24a4a76..3697746 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -2662,7 +2662,8 @@ INT WINAPI WSASendTo( SOCKET s, LPWSABUF lpBuffers, DWORD dwBufferCount, > goto error; > } > > - if ((lpOverlapped || lpCompletionRoutine) && > + /* If no options specified, the socket assumed to be non-overlapped*/ > + if (options && (lpOverlapped || lpCompletionRoutine) && > !(options & (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT))) > { This is wrong, it will make all sockets non-overlapped. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11drv: Initialize real default mode in xrandr and xvidmode backends
by Chris Robinson 31 Oct '07

31 Oct '07

On Tuesday 30 October 2007 10:47:34 pm Dmitry Timoshkov wrote: > - X11DRV_Settings_SetDefaultMode(0); > + > + default_mode = X11DRV_XRandR_GetCurrentMode(); > + TRACE("default mode: %d\n", default_mode); > + X11DRV_Settings_SetDefaultMode(default_mode); This has been brought up on IRC before, and I believe the concensus was you can't rely on the current mode when starting the app because there's no way to tell if the current mode is the default or something another app set. As far as XRandR is concerned, mode 0 is always the default, but the desktop manager can set a different mode per user on login. The way to fix this would be to get some way to query the desktop manager for the default mode, or to extend XRandR to be able to change and report different defaults. Neither of which is possible right now.

2 1

advapi32: fix buffer overrun in tests/registry.c:wine_debugstr_wn(), try 2
by Dan Kegel 31 Oct '07

31 Oct '07

OK, my last try was ugly and deserved to be dropped. This one is a one-bit change, and easier to understand. Fixes an off-by-one buffer overflow in wine_debugstr_wn() in which the wchar after the end of the buffer was read.

1 0