April 2007 - Wine-devel - list.winehq.org

re: www.winehq.org resolves to smth strange.
by Dan Kegel 10 Apr '07

10 Apr '07

Kirill wrote: > I've noticed very strange thing today: www.winehq.org resolves to > http://searchportal.information.com/index.mas?epl=00630086VFAXVE0DWlgVVRBeV… > >This site claims to be winehq.org. > >"Winehq.org - What you need, when you need it" Two ideas. 1. Your ISP or browser has been programmed by your vendor to go to that portal whenever any DNS site can't be resolved, and you had a temporary name lookup problem. 2. Somebody poisoned a DNS cache somewhere. What happens if you go to http://www.nowaythisisvalid.com ?

2 1

Re: err:ddraw:IDirectDrawImpl_QueryInterface (0x1bdd28)
by Klaus Layer 10 Apr '07

10 Apr '07

Am Sonntag, 8. April 2007 12:55 schrieben Sie: > Hi, > Interestingly this application does nothing that would make ddraw return a > failure. Can you send a ddraw,d3d7 trace WITH the registry key set as a > reference? > > As far as I can see, this application is on its way to set up a Direct3D > Device for a surface which does NOT have DDSCAPS_3DDEVICE set - which is not > allowed, as far as I know, but I'd have to test that. But it stops right > before really creating the device by just exiting. Maybe it does not like our > 3DDevice's GUID. > Hi Stefan, attached you find the trace. I am wondering why it so much smaller. I was also able to get a proper callstack of the crash. thanks, Klaus

2 2

Re: [xcopy]New Korean Resource
by Duane Clark 10 Apr '07

10 Apr '07

Hwang YunSong(È²À±¼º) wrote: > Firest release > This might get accepted a little faster if you create them like this: diff -u /dev/null wine/programs/xcopy/Ko.rc > xcopy-ko.diff Of course, you should be in the directory where you have your Wine tree, for that to work. Patches should not be created from within the subdirectory that contains the file being patched.

1 0

wine-patches
by EA Durbin 10 Apr '07

10 Apr '07

Why do the patches I send to wine-patches never show up in the list? Are they being received? _________________________________________________________________ Mortgage rates near historic lows. Refinance $200,000 loan for as low as $771/month* https://www2.nextag.com/goto.jsp?product=100000035&url=%2fst.jsp&tm=y&searc…

3 3

Is Wine a platform for Codeweaver to make money?! Please help me understand.
by Sasan Iman 10 Apr '07

10 Apr '07

First of all, let me say that I am not a developer. But I have been interested in Wine since early 2003. The thing that has always made me scratch my head is that the Windows software that motivates me to install Wine on my linux system (i.e. MS OFfice, etc.) has never worked with wine in a reliable manner. Meanwhile, Codeweaver has always had MS Office working on Wine. Now shouldn't getting the most common windows software working on Wine in an idiot-proof (meaning I can get it to work) manner be the highest priority for Wine developers? Instead, this is left to CodeWeavers and others. I know that if you fiddle around with the stock release long enough you can get MS Office working on Wine as I have on a number of occasions, but shouldn't making this work for everyone be the highest priority for getting Wine to be adopted more widely?! Or is Wine more targeted to gamers which is mostly what I read about on WineHQ? I just can't understand why the more common application are left to a commercial company. My conspiratorial side makes me want to think this is a conspiracy but I am sure there is valid technical and logistical reasons for it so I am asking you guys. Thanks. Sasan

12 20

Re: quartz: Implement IAMFilterData for IFilterMapper
by Robert Shearman 10 Apr '07

10 Apr '07

Chris Robinson wrote: > +static HRESULT WINAPI AMFilterData_CreateFilterData(IAMFilterData* iface, > + REGFILTER2 *prf2, BYTE **pRegFilterData, ULONG *pcb) > +{ > + FilterMapper2Impl *This = impl_from_IAMFilterData(iface); > + int size = sizeof(struct REG_RF); > + unsigned int i; > + struct Vector mainStore = {NULL, 0, 0}; > + struct Vector clsidStore = {NULL, 0, 0}; > + struct REG_RF rrf; > + > + TRACE("(%p/%p)->(%p, %p, %p)\n", This, iface, prf2, pRegFilterData, pcb); > + > + if (prf2->dwVersion != 2) > + { > + FIXME("Filter registry version %d not supported\n", prf2->dwVersion); > + ZeroMemory(prf2, sizeof(*prf2)); > + return E_FAIL; > + } > + > + rrf.dwVersion = prf2->dwVersion; > + rrf.dwMerit = prf2->dwMerit; > + rrf.dwPins = prf2->u.s1.cPins2; > + rrf.dwUnused = 0; > + > You change FM2_WriteFilterData to be more suitable and then you should re-implement AMFilterData_CreateFilterData on top of this, not duplicate all of this code. -- Rob Shearman

1 0

Re: shell32: Since shlwapi imports ole32, there's no point in shell32 delay-importing ole32.
by Dmitry Timoshkov 10 Apr '07

10 Apr '07

"Robert Shearman" <rob(a)codeweavers.com> wrote: > shell32: Since shlwapi imports ole32, there's no point in shell32 delay-importing ole32. shlwapi has ole32 as a delay load, just like a native one does. Native shell32 also has ole32 as a delay loaded dependency. So, we might at least have ole32 as a delay loaded import just for compatibility with native dlls. -- Dmitry.

1 0

Re: [PATCH] handle some failed open conditions.
by Alexandre Julliard 10 Apr '07

10 Apr '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > spotted by Coverity. > > Not all might really happen, but check for it > anyway. I don't think there's much point in the check, but if you do check then you have to report a failure, you can't let the test silently succeed without doing anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: SoC Deadline: 07:00 UTC on April 10th
by Dan Kegel 10 Apr '07

10 Apr '07

Detlef wrote: >### >2. Make sure that all the applications that you *really* want have >mentors assigned to them as quickly as possible, certainly no later >than 12 midnight Pacific / 07:00 UTC on April 10th. >### > >Do we have assigned a mentor for all possible slots? I've assigned you one, but Rob and Jacek are still volunteering to mentor proposals that aren't going to be approved, they should pick different proposals asap. And I do think there are two alternate proposals worth funding; they'll see them straight off if they visit the list of proposals in the web app. - Dan

1 1

Re: respect unicode _ILCreateFromFindData
by Dmitry Timoshkov 10 Apr '07

10 Apr '07

"Aric Stewart" <aric(a)codeweavers.com> wrote: > + if (fs) > + { > + FileTimeToDosDateTime( &(stffile->ftLastWriteTime), > + &fs->uFileDate, &fs->uFileTime); > + fs->dwFileSize = stffile->nFileSizeLow; > + fs->uFileAttribs = (WORD)stffile->dwFileAttributes; > + > + memcpy(fs->szNames, name_buff, name_len); > + TRACE("-- Set Value: %s\n",debugstr_a(fs->szNames)); > + } Indentation above is not consistent. > LPITEMIDLIST _ILCreateFromFindDataW( WIN32_FIND_DATAW *wfd ) > { > - /* FIXME: should make unicode PIDLs */ > - WIN32_FIND_DATAA fda; > + char buff[MAX_PATH + 14 +1]; /* see WIN32_FIND_DATA */ > + char * pbuff = buff; > + size_t len, len1, wlen, alen; > + LPITEMIDLIST pidl; > + PIDLTYPE type; > + > + if (!wfd) > + return NULL; > + > + TRACE("(%s, %s)\n",debugstr_w(wfd->cAlternateFileName), debugstr_w(wfd->cFileName)); > + > + /* prepare buffer with both names */ > + len = WideCharToMultiByte(CP_ACP,0,wfd->cFileName,-1,NULL,0,NULL,NULL) + 1; > + WideCharToMultiByte(CP_ACP,0,wfd->cFileName,-1, pbuff, len, NULL, NULL); > + pbuff += len; Looks like 2 WideCharToMultiByte calls can be replaced by 1. > + > + len1 = WideCharToMultiByte(CP_ACP,0,wfd->cAlternateFileName,-1, NULL, 0, NULL, NULL) +1; > + WideCharToMultiByte(CP_ACP,0,wfd->cAlternateFileName,-1, pbuff, len1, NULL, NULL); > + alen = len + len1; Same here. > + > + type = (wfd->dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) ? PT_FOLDER : PT_VALUE; > + > + /* > + * FileStruct already has one byte for the first name, so use len - 1 in > + * size calculation > + */ > + wlen = lstrlenW(wfd->cFileName); > + pidl = _ILAlloc(type, sizeof(FileStruct) + (alen - 1) + (alen & 0x1) + > + sizeof(FileStructW) + wlen * sizeof(WCHAR) + sizeof(WORD)) ; What (alen & 0x1) is for? -- Dmitry.

2 1