April 2007 - Wine-devel - list.winehq.org

Advice on how to proceed - XKB keyboard handling
by Shachar Shemesh 09 Apr '07

09 Apr '07

Hi all, I put up an intermediate version of my XKB patch. It is the last attachment for bug #735 (http://bugs.winehq.org/show_bug.cgi?id=735) The patch, as is, solves bug 735, as can be tested by compiling the test program. However, it does not play well with other areas of the keyboard handling. I'm posting this here partly to draw attention for those who need bug #735 fixed and can live with the regression, and partly to get feedback on how best to proceed. Thanks, Shachar

1 0

wine latest packages for feisty
by Vijay Kiran Kamuju 08 Apr '07

08 Apr '07

Hi, Wherr can I get the 0.9.34 wine built for ubuntu feisty. I am currently using ubuntu's 0.9.33, they havent updated it (Idont they will update it as they are in rc1 freeze). Thanks, VJ

2 4

Any news on hiweedlayer?
by Stefan Dösinger 08 Apr '07

08 Apr '07

Hi, I was wondering if there was any news on this hiweedlayer program which was discussed earlier and turned out to be just a packed up wine archive? Dan said he was in contact with them. Has there been any outcome yet? Cheers, Stefan

2 1

Re: Is Wine a platform for Codeweaver to make money?! Please help me understand.
by Remco 08 Apr '07

08 Apr '07

Just an idea here from a non-developer... Maybe bug reports could be automated in such a way that all fixme's and err's are stored in a file, and that file gets sent to Wine's bugzilla in intervals. Then it is automatically analysed and split up by DLL. That would make it the task of the developers to force Wine to spit out errors with every little thing that could go wrong. But if that would be done right, every error would be reported. Of course there would have to be a popup asking if the bug report may be sent. ____________________________________________________________________________________ Sucker-punch spam with award-winning protection. Try the free Yahoo! Mail Beta. http://advision.webevents.yahoo.com/mailbeta/features_spam.html

3 2

Why double translation on keydown?
by Shachar Shemesh 08 Apr '07

08 Apr '07

Hi all, The current code for keyboard translation goes something like this, if I understood it correctly: * An X11 event arrives with the physical keycode for the key pressed. * Said code is translated into a VKey based on the current keyboard (fair enough) * Keycode is translated into a, well, keycode for Windows. 99% of the cases this is the same one, as it's the same PC keyboard as ever. * The vkey and translated keycode are sent as WM_KEYDOWN or WM_SYSKEYDOWN events. * In all probability, the process calls TranslateMessage * TranslateMessage calls (indirectly) X11DRV_ToUnicodeEx * X11DRV_ToUnicodeEx takes the virtual key, looks it up (using a for loop!!!!) in the same table consulted before to find out what the original X11 keycode was. * That vkey is passed, after some manipulation, to XKeysymToKeycode to produce a keycode * Said keycode is passed to XLookupString to get an actual key for it This process seems, to me, overly long and inefficient. It requires building fairly complex lookup tables for both vkey and Windows keycode. I fail to see what is gained. Why not use the following process instead: * An X11 event arrives * Use the native keycode as the keycode. * Translate the vkey as before. * Send WM_(SYS)KEYDOWN as before * In X11DRV_ToUnicodeEx: * Use the keycode to lookup with key using XLookupString I fail to see why the forward and backwards translation is good for. Explanation? Shachar

2 3

Re: wined3d: Preload target in ActivateContext() for ORM_BACKBUFFER
by Stefan Dösinger 08 Apr '07

08 Apr '07

Am Sonntag 08 April 2007 00:14 schrieb Felix Nawothnig: > --- > dlls/wined3d/context.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) You also have to do that for backbuffer

3 2

Re: wined3d: Allow np2 textures to be loaded for SFLAG_INDRAWABLE
by H. Verbeet 07 Apr '07

07 Apr '07

On 07/04/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > --- > dlls/wined3d/surface.c | 22 +++++++++++----------- > 1 files changed, 11 insertions(+), 11 deletions(-) > Why did you move d3dfmt_get_conv? I'm not too sure about always respecifying the texture.

1 1

Re: [1/8] regedit: Remove the _stscanf function dependency.
by Alexandre Julliard 07 Apr '07

07 Apr '07

Byeong-Sik Jeon <wjsqudtlr(a)gmail.com> writes: > _stscanf depends tchar.h > > Changelog: > Remove the _stscanf function dependency. You are going about this the wrong way. What you should do is convert the code to use explicit Unicode functions. Removing TCHAR and the like will then be an automatic consequence of that conversion. If you try to remove tchar.h first you only add more complexity that would have to be undone later. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3d8: Void functions should not return a value
by Eric Pouech 07 Apr '07

07 Apr '07

Andrew Talbot a écrit : > These functions are correctly declared to return nothing, so that's what they > should do. > > -- Andy. > --- > Changelog: > d3d8: Void functions should not return a value. > > diff -urN a/dlls/d3d8/cubetexture.c b/dlls/d3d8/cubetexture.c > --- a/dlls/d3d8/cubetexture.c 2006-12-06 11:51:13.000000000 +0000 > +++ b/dlls/d3d8/cubetexture.c 2007-04-07 20:35:00.000000000 +0100 > @@ -104,7 +104,8 @@ > static void WINAPI IDirect3DCubeTexture8Impl_PreLoad(LPDIRECT3DCUBETEXTURE8 iface) { > IDirect3DCubeTexture8Impl *This = (IDirect3DCubeTexture8Impl *)iface; > TRACE("(%p) Relay\n", This); > - return IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture); > + IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture); > + return; > } > I don't see the point of still having "return;" as last statement of function. It can be safely removed A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: d3d8: Void functions should not return a value
by H. Verbeet 07 Apr '07

07 Apr '07

On 07/04/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > These functions are correctly declared to return nothing, so that's what they > should do. > > -- Andy. They don't technically return a value... the wined3d functions are void as well. I'm not sure what the idea there was :-)

1 0