October 2008 - Wine-devel - list.winehq.org

Patchwatcher status
by Dan Kegel 31 Oct '08

31 Oct '08

Patchwatcher is almost recovered from its move to the new machine. I expect to turn email notifications back on tomorrow. The old machine could only just barely keep up with the patch flow. The new machine is two or so times faster, so it's much, much better at catching up when a patch flood hits it. The new machine has a fairly modern nvidia card, so more of the tests are actually run. To-do list: 1. Figure out what card I need to buy to avoid these: overlay.c:218: Tests skipped: Failed to initialize ddraw overlay.c:89: Tests skipped: Failed to create an overlay - assuming not supported sysparams.c:2313: Tests skipped: Setting depth 24 failed(ret = -2) visual.c:7453: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:8456: Tests skipped: Only 1 simultaneous render target supported, skipping MRT test visual.c:8595: Tests skipped: D3DFMT_G16R16F textures not supported visual.c:8595: Tests skipped: D3DFMT_G32R32F textures not supported visual.c:9690: Tests skipped: Sanity check returned an incorrect color(00552200), can't assure the correctness of the tests, skipping 2. Install corefonts to avoid these: font.c:1163: Tests skipped: Arial is not installed font.c:1473: Tests skipped: Arial is not installed font.c:1653: Tests skipped: Arial Black is not installed font.c:1653: Tests skipped: Symbol is not installed 3. Figure out what's causing these: font.c:1879: Tests skipped: Font DejaVu Sans doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Lohit Gujarati doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Lohit Hindi doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Lohit Punjabi doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Lohit Tamil doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Mallige doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font OpenSymbol doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Purisa doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font UnBatang doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font UnDotum doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font Vemana2000 doesn't contain 'x', skipping the test font.c:1879: Tests skipped: Font utkal doesn't contain 'x', skipping the test 4. Get the mailing list parser to handle multiple overlapping patch series so it doesn't get stuck when somebody sends a partial one. 5. Bring up my new refactored patchwatcher script. 6. Add multiple worker machines. 7. Bring up valgrind support. 8. Figure out why I have to blacklist the following tests: comctl32:tooltips.c ddraw:visual.c dsound:ds3d.c kernel32:thread.c riched20:editor.c user32:input.c user32:msg.c user32:win.c wininet:http.c 9. Figure out why winmm_test.exe.so wave.c always hangs on my new test machine.

4 4

Re: [PATCH] gdi32: Small patch to fix the return vars of WineEngRemoveFontResourceEx
by James Hawkins 31 Oct '08

31 Oct '08

On Wed, Oct 29, 2008 at 4:18 PM, Daniel Jakob <wolverine(a)stuniverse.de> wrote: > Hi > > My first post on the list is just a small patch. > WineEngRemoveFontResourceEx is currently a stub and should return a zero > on fail instead of true. > Have you thought about the possibility that we return TRUE for a reason? Maybe an app fails if an error percolates up from WineEngRemoveFontResourceEx? -- James Hawkins

2 1

patchwatcher status
by Dan Kegel 31 Oct '08

31 Oct '08

Both old and new patchwatcher: - fixed the displayed time of patches on the results web page. New patchwatcher: - for some reason it wasn't looking for all the errors the old one did. Fixed. - for some reason I had forgotten to have it actually watch for new commits in git. Fixed. - Better at logging errors during 'make depend' etc.

1 0

Re: [2/2] [PATCH] msxml3: fixed if nesting / ptr checking problems inxmlnode_transformNodemarcus
by Alistair Leslie-Hughes 31 Oct '08

31 Oct '08

Hi Marcus, "Marcus Meissner" <marcus(a)jet.franken.de> wrote in message news:35191.4944280454$1225405489(a)news.gmane.org... > Hi,> > htmlDocContentDumpOutput(pOutput, result->doc, NULL);> - if(pOutput)> - { Should this be changed to if(pOutput->buffer), I don't remember if pOutput->buffer can be NULL. Best Regards Alistair Leslie-Hughes _________________________________________________________________

1 0

Re: [PATCH] ntdll: Don't append directory entries if the filename length is less than 1.
by Alexandre Julliard 31 Oct '08

31 Oct '08

"Lei Zhang" <thestig(a)google.com> writes: > I saw the following in a +file trace a user sent me: > > trace:file:FindNextFileW returning L"" (L"") > > I tried fixing FindNextFileW(), but that patch didn't get accepted. > I'm guessing we should fix the problem in NtQueryDirectoryFile() so > nobody who call it will get back an empty file name. This should never happen. You should figure out where the empty name comes from and fix the caller. -- Alexandre Julliard julliard(a)winehq.org

2 2

Wine 1.0.2
by Austin English 31 Oct '08

31 Oct '08

Please add 1.0.2 target milestone to Bugzilla. -- -Austin

2 2

Re: PATCH: warn if missing stdole32.tlb
by Austin English 31 Oct '08

31 Oct '08

On Thu, Oct 30, 2008 at 6:13 AM, mayura <mayura(a)abcinsurance.lk> wrote: > > > > > Kind regards. > > Mayura Swarna kumara > > ABC Insurance Company Limited, > "Trans Court", No 21, > Nawam Mawatha > Colombo 0200 > Sri Lanka > ( +94 11 230 3560 7 +94 11 230 3566 > * mayura(a)abcinsurance.lk > ü www.abcinsurance.lk > > P Save a tree. Don't print this e-mail unless it's really necessary > > > > > You forgot to attach the patch. -- -Austin

1 0

re: Fix kernel_main.c to generate console Window
by Dan Kegel 30 Oct '08

30 Oct '08

Hi Slawek, Please just attach the bare patch, not a .tgz of the patch. This sounds related to http://bugs.winehq.org/show_bug.cgi?id=5541 but not a duplicate. Please open a bug report and repost your patch without compression or archiving. Thanks, Dan

2 1

RE: rundll32: build with -mwindows
by Vincent Povirk 30 Oct '08

30 Oct '08

I have tested, and it still works. I would have fully expected it to fail if I had remembered the difference between main() and WinMain(). -----Original Message----- From: Dmitry Timoshkov [mailto:dmitry(a)codeweavers.com] Sent: Thursday, October 30, 2008 11:37 AM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: rundll32: build with -mwindows "Vincent Povirk" <vincent(a)codeweavers.com> wrote: > -APPMODE = -mconsole > +APPMODE = -mwindows Have you tested that it still works? I'd expect that you also need to replace main() by WinMain() and adapt command line processing. -- Dmitry.

1 0

Re: rundll32: build with -mwindows
by Dmitry Timoshkov 30 Oct '08

30 Oct '08

"Vincent Povirk" <vincent(a)codeweavers.com> wrote: > -APPMODE = -mconsole > +APPMODE = -mwindows Have you tested that it still works? I'd expect that you also need to replace main() by WinMain() and adapt command line processing. -- Dmitry.

1 0