October 2008 - Wine-devel - list.winehq.org

winecfg - great job!
by Eric Anopolsky 29 Oct '08

29 Oct '08

Hi, I just read the following in the WWN: "The overall 'Wine Experience' was discussed next. As a whole everybody agrees that it is ugly. Winecfg is arcane, there are tons of nonsense fixmes, very little 'newbie guidance' and overall a small chance of success on the first try. Devs do care about this but its just not as much fun to fix." Don't be so hard on yourselves! Remember when we had to write a text-based configuration file with no help other than documentation? What percentage of the computer-using public reads documentation? I can say something like, "Diablo II will not run fullscreen on my computer. You have to set it to use an emulated desktop before you launch it or it will crash. You can do that using the 'Configure Wine' program on the 'Wine' menu," to my non-Linux-using girlfriend and she can figure out how to run Diablo II without additional help, and without knowing anything ahead of time about emulated desktops. It's just a checkbox and it just works. You all are doing a great job! :) Cheers, Eric

4 4

patchwatcher status: ready for volunteers to get working on bsd/solaris/mac
by Dan Kegel 29 Oct '08

29 Oct '08

Blacklisted wininet:http.c because it relies on winehq.org being up and serving php properly :-) Fixed enough problems with the new patchwatcher that it seems to be running tests properly. You can see the new patchwatcher's results at http://kegel.com/wine/patchwatcher/results2/ The results should agree with the original patchwatcher, http://kegel.com/wine/patchwatcher/results/ Now I just have to get the email and web reporting smoothed out, then I can consider turning the old one off and turning on the new one's email notifications. Then it should be pretty easy to add new slave build machines to speed up the build or add new slave types (e.g. windows, valgrind, macosx, bsd, solaris). Now is a good time for bsd / macosx / solaris enthusiasts to jump in and get patchwatcher running on their favorite OS or compiler. Patches gladly accepted. If alternate platforms or compilers are working well and are worth integrating into the main patchwatcher instance, I'll do it. The code's all in svn at http://code.google.com/p/winezeug/source/browse/#svn/trunk/patchwatcher as usual. The new patchwatcher is described in readme.txt. Have fun! - Dan

1 0

winhttp test failing because of winehq.org problem?
by Dan Kegel 29 Oct '08

29 Oct '08

Could it be that the winhttp test is failing because of some change at winehq.org? I keep seeing winhttp.c:281: Test failed: Data read did not match, got '<?php

3 3

Re: Implementation of ID3DXMatrixStack interface, with tests
by James McKenzie 29 Oct '08

29 Oct '08

Jérôme Gardou wrote: [patch removed] It would be nice to state which project this patch is associated with, however Alexandre usually fixes this when it is approved. Please put in TRACE where you removed FIXME. It makes debugging much easier. Thank you. James McKenzie

1 0

Re: [PATCH 2/3] xinput: Added the function XInputGetState with test cases
by Vitaliy Margolen 29 Oct '08

29 Oct '08

Andrew Fenn wrote: > This patch adds the function XInputGetState which is for checking if > any joysticks are plugged in. This always returns no joysticks. > > > ------------------------------------------------------------------------ > > > +static void test_no_controller(void) { > + > + XINPUT_STATE controllerState; > + DWORD controllerNum; > + DWORD result; > + > + for(controllerNum=0; controllerNum < 4; controllerNum++) { > + ZeroMemory(&controllerState, sizeof(XINPUT_STATE)); > + > + result = XInputGetState(controllerNum, &controllerState); > + ok(result != ERROR_BAD_ARGUMENTS, "XInputGetState failed with (%d)\n", result); > + > + if (ERROR_DEVICE_NOT_CONNECTED == result) { > + skip("Controller %d is not connected\n", controllerNum); > + } else { and > + if (hXinput) > + { > + XInputGetState = (void*)GetProcAddress(hXinput, "XInputGetState"); > + test_no_controller(); > + } else { > + skip("Could not load xinput1_3.dll\n"); > + } Using 2 separate stiles for curly brackets. Please put the opening and closing brackets on separate lines. It makes it so much easer to read. Ex: if (something) { /* Doing something */ } else { /* Doing something else */ } In xinput.h you adding lots of defines you not using. And you just threw all of them together in one big pile. Please add them when you need them. Or at least put them into proper groups. > + if (dwUserIndex < 4) { > + return ERROR_DEVICE_NOT_CONNECTED; > + /* If controller exists then return ERROR_SUCCESS */ > + } Why 4? Why not 40? Have you run your tests on windows? > -static void test_no_controller(void) { > + > + > +static void test_get_state(void) { You should call it the right way from the start. Vitaliy.

1 0

Re: Implementation of ID3DXMatrixStack interface, with tests
by Henri Verbeet 28 Oct '08

28 Oct '08

I don't think we want to implement this as a linked list. You'll also want to replace the FIXMEs you removed with useful TRACEs.

1 0

My xinput implementation please test, plus I am getting segfault with spore
by Andrew Fenn 28 Oct '08

28 Oct '08

Hi all, I am getting a segfault with the release version of Spore (I didn't test 1.1) right after my code implementation of xinput is handled by the game. Is there something I am doing wrong here or is it the game? I also tested Assasin's Creed which uses xinput1_3 and that happens to load my implementation fine and my test cases work on windows xp SP3 too. I have included my patches for the xinput implementation. If you could help me test and find out the spore problem before I submit this to wine patches it would be very helpful. I have included test cases with the patch. When testing please make sure that you don't have any xinput dlls in your program dir or system32. A list of xinput games can be found here, http://en.wikipedia.org/wiki/List_of_XInput_games Thanks and regards, Andrew

2 3

Re: Wine does not compile using Ubuntu real-time kernel
by Susan Cragin 28 Oct '08

28 Oct '08

>On Tue, Oct 28, 2008 at 10:50 AM, Susan Cragin wrote: >> I guess this is a FYI. Because this seems to be a rt-kernel issue, not a wine issue. >> Background -- Ubuntu stopped sponsoring the RT kernel for a while. (It used to compile wine without a problem.) But so many people used it that they started sponsoring it again, after a lag. >> DNS10 doesn't install correctly using the real-time kernel either. >> However, if you compile and install using standard kernel, DNS10 runs quite nicely using the RT kernel. >> >> 2.6.27-7 is the latest standard kernel >> 2.6.27-3-rt is the latest real-time >> >> If there is any interest I'll send terminal output. >> >> Susan >It doesn't compile, or doesn't run well? > >-- >-Austin It doesn't compile. I tried, no luck. Then rebooted into standard kernel and compiled. That worked. Then rebooted into RT. Winecfg ran OK, so tried to install DNS10. No luck. Then rebooted into standard and installed DNS. That worked. Then rebooted into RT. Ran DNS10. That worked. BTW -- I use Intrepid.

1 0

Wine does not compile using Ubuntu real-time kernel
by Susan Cragin 28 Oct '08

28 Oct '08

I guess this is a FYI. Because this seems to be a rt-kernel issue, not a wine issue. Background -- Ubuntu stopped sponsoring the RT kernel for a while. (It used to compile wine without a problem.) But so many people used it that they started sponsoring it again, after a lag. DNS10 doesn't install correctly using the real-time kernel either. However, if you compile and install using standard kernel, DNS10 runs quite nicely using the RT kernel. 2.6.27-7 is the latest standard kernel 2.6.27-3-rt is the latest real-time If there is any interest I'll send terminal output. Susan

3 2

Re: [PATCH] uxtheme: fixed the todo blocks in the SetWindowTheme tests. [try 2]
by James Hawkins 28 Oct '08

28 Oct '08

On Tue, Oct 28, 2008 at 2:29 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > Hi, > > This fixes the todo blocks in the SetWindowTheme tests. > > Changes: > v2 -- initialise the hr variable so that it is initialised in the > case where hwnd is a valid window handle. > Please fix your changelog entry to describe the *fix*, not the end result (getting rid of todo_wine's). Also, + HRESULT hr = S_OK; TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName), debugstr_w(pszSubIdList)); - hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName); + if(!IsWindow(hwnd)) + hr = E_HANDLE; + if(SUCCEEDED(hr)) + hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName); if(SUCCEEDED(hr)) hr = UXTHEME_SetWindowProperty(hwnd, atSubIdList, pszSubIdList); if(SUCCEEDED(hr)) This code is screaming for a goto. -- James Hawkins

3 3