October 2008 - Wine-devel - list.winehq.org

Vertex pipeline replacement
by Stefan Dösinger 30 Oct '08

30 Oct '08

Hi, I have my vertex pipeline replacement almost ready to send. Because the fragment pipeline replacement caused a bunch of regressions, I want to give this patch a bit of testing before committing it. I expect slightly more regressions there because the vertex processing stuff is still badly tested, especially lighting. Can you give the patches a try and see if your game still works? For now the most important part is that the game works without any performance loss or rendering bugs. This patchset is supposed to address the following issues: 1) Improve performance in applications that are hit hard by drawStridedSlow. I don't know if there are many left, because the vertex buffer fixups really helped here 2) Allow adding features that do not exist in the GL fixed function pipeline(or are not supported by drivers): Vertex blending, tweening, more efficient material tracking, per-vertex point size 3) Make the way towards OpenGL 3 forward compatibility mode So far (1) should already go some way with these patches. There are no new features added yet, and opengl 3 needs the same stuff implemented with GLSL and further work, but this is a necessary start. Once these patches are in, I'll turn to fine-tuning things. The rhw handling can be done better(maybe), and vertex buffer loading can be made much cheaper if the pipeline replacement is in use and opengl supports native 16 bit vertex attributes. This should get old card compatibility costs off our backs when we're running on a modern GPU without sacrificing backward compatibility.

2 3

comctl32 tree problem?
by Dan Kegel 30 Oct '08

30 Oct '08

Here's an app that says they had to work around a problem in our tree control: http://www.webyog.com/blog/2008/10/30/sqlyog-712-has-been-released/

2 2

Present Wine at CeBit?
by Jeremy White 30 Oct '08

30 Oct '08

Anyone want to give a presentation on Wine at CeBit? http://www.linux-magazine.com/online/news/cebit_open_source_linux_magazine_… If you're interested, email me privately, and I'll connect you with Britta. Cheers, Jeremy

1 0

Re: Changed more malloc to HeapAlloc calls
by James Hawkins 30 Oct '08

30 Oct '08

On Wed, Oct 29, 2008 at 7:39 PM, Pete Myers <peterdanielmyers(a)googlemail.com> wrote: > In line with http://wiki.winehq.org/ReplaceMalloc this is a small patch that > changes all malloc calls to HeapAlloc in the following files: > ./dlls/iphlpapi/tests/iphlpapi.c > ./dlls/wnaspi32/winaspi16.c > > Changelog: > * malloc calls in dlls/kernel32/process.c have been change to HeapAlloc > Your changelog (right above) doesn't match the patch, and - PMIB_IPADDRTABLE buf = (PMIB_IPADDRTABLE)malloc(dwSize); + PMIB_IPADDRTABLE buf = (PMIB_IPADDRTABLE)HeapAlloc( GetProcessHeap(), 0, dwSize); You've introduced a space after opening parentheses which does not match the style of the rest of the file. -- James Hawkins

3 6

Re: mshtml: Implement IHTMLElement get_document
by Jacek Caban 30 Oct '08

30 Oct '08

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLElement get_document > + *p = NULL; + + if(!This->node.doc->nsdoc) { + WARN("NULL nsdoc\n"); + return E_UNEXPECTED; + } You don't use nsdoc so there is no reason to test it. + hr = IHTMLDocument2_QueryInterface(HTMLDOC(This->node.doc), &IID_IHTMLDocument, (void**)p); + + return hr; You could just cast This->node.doc to IHTMLDocument and call AddRef on result. Jacek

1 0

Re: [PATCH 1/3] fusion: Implement the IAssemblyEnum interface. [try3]
by Jacek Caban 30 Oct '08

30 Oct '08

Hi James, James Hawkins wrote: > --- > dlls/fusion/Makefile.in | 1 + > dlls/fusion/asmcache.c | 83 ---------- > dlls/fusion/asmenum.c | 385 ++++++++++++++++++++++++++++++++++++++++++++++ > dlls/fusion/asmname.c | 15 +-- > dlls/fusion/fusion.c | 12 -- > dlls/fusion/fusionpriv.h | 15 ++ > 6 files changed, 402 insertions(+), 109 deletions(-) > create mode 100644 dlls/fusion/asmenum.c > + +done: + FindClose(hfind); + return S_OK; +} + You always set hr in error paths so I guess you want to return it here. Also, it's a matter of style, but these gotos look strange. You could replace them all by break statements. Jacek

1 0

Unable to add cc to bug 13583
by Matt Perry 30 Oct '08

30 Oct '08

I ran a regression test for bug 13583 and attempted to add the patch author to the CC field in Bugzilla as indicated in the regression test documentation. Unfortunately, I get the following error: CC: rob(a)codeweavers.com did not match anything How do I get the author of the patch onto the CC list? Matt

2 1

does anyone else's windows 98 machine not survive the user32 msg test?
by Vincent Povirk 30 Oct '08

30 Oct '08

After I run "user32_crosstest msg" on my windows 98 virtual machine in qemu, it no longer responds to any mouse input (the cursor moves and changes, but clicking has no effect). This seems to be caused by calling DefWindowProcA directly with WM_SYSCOMMAND messages SC_NEXTWINDOW and SC_PREVWINDOW. Does this happen to anyone else, especially on a windows 98 machine not running in qemu? Vincent Povirk

6 7

Re: BUG 15833: TreeView control don't save item's state
by John Klehm 30 Oct '08

30 Oct '08

On Wed, Oct 29, 2008 at 6:50 AM, warmouse <iwarmouse(a)gmail.com> wrote: > Hi. > > BUG: > TreeView sends TVS_GETDISPINFO notifycation. Main application catch it and > change "mask","state" and "stateMask" in a TVITEM structure. After returning > > from message handler, item's state don't changed. TreeView don't save new > item > state in function TREEVIEW_UpdateDispInfo after calling > TREEVIEW_SendRealNotify. > Hey, Any patch needs the authors real name with it. Also probably a test case showing the behavior implemented by your patch would be nice as well. Cheers, --John Klehm

1 0

Re: [PATCH] [1/19] paint: basic paint program
by Alexandre Julliard 29 Oct '08

29 Oct '08

"Hirofumi Katayama" <katayama.hirofumi.mz(a)gmail.com> writes: > From ee02c7995d6dcaf490f8f90b8d37ebc6b08f733e Mon Sep 17 00:00:00 2001 > From: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> > Date: Sat, 25 Oct 2008 10:55:17 +0900 > Subject: [PATCH] [1/19] paint: basic paint program The program should probably be called mspaint.exe if it's supposed to be a replacement for the Windows one. Also you can't copy the toolbar icons from the original, you need to draw your own. -- Alexandre Julliard julliard(a)winehq.org

2 1