December 2008 - Wine-devel - list.winehq.org

Re: [1\3] setupapi: add CM_Locate_DevNodeA\W stubs
by Stefan Leichter 12 Dec '08

12 Dec '08

Am Friday 12 December 2008 01:42 schrieb ricardo filipe: >--- a/dlls/setupapi/setupapi.spec >+++ b/dlls/setupapi/setupapi.spec >@@ -53,7 +53,7 @@ > @ stub CM_Free_Res_Des > @ stub CM_Free_Res_Des_Ex > @ stub CM_Free_Res_Des_Handle >-@ stub CM_Get_Child >+@ stdcall CM_Get_Child(ptr long long) > @ stub CM_Get_Child_Ex > @ stub CM_Get_Class_Key_NameA > @ stub CM_Get_Class_Key_NameW this part is wrong here as it is in the second patch too .. Stefan

2 1

Re: mshtml: Add some interfaces in mshtml.idl (try 2) (resend)
by Konstantin Kondratyuk 12 Dec '08

12 Dec '08

On Thursday 11 December 2008 17:28:03 Konstantin Kondratyuk wrote: > Add: > ILineInfo > IDisplayPointer > IDisplayPointer > IHTMLComputedStyle > IDisplayServices > IMarkupServices This patch is wrong. Please, ignore it. -- Best regards, Konstantin Kondratyuk.

1 0

Re: winmm: Sign-compare warning fix (Resend)
by Andrew Talbot 12 Dec '08

12 Dec '08

On Fri Dec 12 10:29 , Michael Stefaniuc <mstefani(a)redhat.com> sent: >Andrew Talbot wrote: >> But how would you then fix the sign-compare violation, or would you just let this >> one go? >I had to look twice as the initial warning was in a for loop above: >Either leave it as is for now as the warning is bogus or at least add >the decrement directly to the while like this: > i = sizeof(MMDrvs) / sizeof(MMDrvs[0]); > while (i-- > 0) > { > MMDRV_ExitPerType(&MMDrvs[i], MMDRV_AUX); > >Though the later would still have to pass Alexandre's review. > >bye > michael Come to think of it, I believe Alexandre did improve one of my earlier efforts in this latter way, so I might retry with the slimmer while loop you suggest. Thanks, Michael (and Chris and Peter)! -- Andy.

1 0

Re: A nicer icon for shell32 folder
by Alexandre Julliard 12 Dec '08

12 Dec '08

Hervÿffffe9 Chanal <chanal_herve(a)yahoo.fr> writes: > It's (may) be a nicer icon for the "folder icon" of shell32. comments are welcome. I think you should keep the yellow color scheme, that's what all other folder-style icons use. > Sorry for all the mess I seem to have done. I'll try to revert my old > icons patch to the previous ones as soon as I have the time. You haven't done any mess, the svg icons are a nice improvement. The reason they don't look as good as they should is because Wine doesn't support the alpha channel, we need to fix that. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: winmm: Sign-compare warning fix (Resend)
by Andrew Talbot 12 Dec '08

12 Dec '08

On Fri Dec 12 0:58 , Michael Stefaniuc sent: >Andrew Talbot wrote: >> What is wrong with this patch, please? >If I may venture a guess: You have replaced a nice and concise for loop >into and ugly 4 line while loop. > >bye > michael > Hi Michael, Ugly? Andrew Koenig and Barbara Moo show a similar construct in their book "Accelerated C++". ;) But how would you then fix the sign-compare violation, or would you just let this one go? -- Andy.

4 3

Re: kernel32: Remove _hread16() as it is not used. Move _hwrite16() next to the other related functions.
by Alexandre Julliard 12 Dec '08

12 Dec '08

Francois Gouget <fgouget(a)free.fr> writes: > The krnl386.exe.spec file points _hread() to WIN16_hread() so that this > _hread16() function is unused. > > The naming of these implementations is a bit inconsistent but it may not > be worth a patch to fix it (but if it is I'll gladly send one). The reason for the inconsistent naming is that the xxx16 functions are 16-bit implementations usable from normal Wine code, while the WIN16_xxx ones have different calling sequences and are for use by the relay code only. That's why we had both WIN16_hread and hread16. Of course at this point we shouldn't be calling 16-bit functions from Wine code, so it no longer matters. -- Alexandre Julliard julliard(a)winehq.org

1 0

Translating to winehq.org
by Maik Schulz 12 Dec '08

12 Dec '08

Hi, I just started translating the new winehq.org to German. How would you like to receive the git patches for the translated template files? One at a time whenever I have them ready, or at the end in one batch? Also, what about obsolete content? E.g. contributing.template still lists Wine 1.x tasks (with a link to an empty Bugzilla list) as well as an empty Wine 0.9.x tasks list. Cheers, -Maik

3 2

Re: winmm: Sign-compare warning fix (Resend)
by Michael Stefaniuc 11 Dec '08

11 Dec '08

Andrew Talbot wrote: > What is wrong with this patch, please? If I may venture a guess: You have replaced a nice and concise for loop into and ugly 4 line while loop. bye michael > --- > Changelog: > winmm: Sign-compare warning fix. > > diff --git a/dlls/winmm/lolvldrv.c b/dlls/winmm/lolvldrv.c > index 794c117..946d0d0 100644 > --- a/dlls/winmm/lolvldrv.c > +++ b/dlls/winmm/lolvldrv.c > @@ -737,7 +737,7 @@ static BOOL MMDRV_ExitPerType(LPWINE_MM_DRIVER lpDrv, UINT type) > */ > void MMDRV_Exit(void) > { > - int i; > + unsigned int i; > TRACE("()\n"); > > for (i = 0; i < sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0]); i++) > @@ -753,8 +753,11 @@ void MMDRV_Exit(void) > } > > /* unload driver, in reverse order of loading */ > - for (i = sizeof(MMDrvs) / sizeof(MMDrvs[0]) - 1; i >= 0; i--) > + i = sizeof(MMDrvs) / sizeof(MMDrvs[0]); > + while (i > 0) > { > + --i; > + > MMDRV_ExitPerType(&MMDrvs[i], MMDRV_AUX); > MMDRV_ExitPerType(&MMDrvs[i], MMDRV_MIXER); > MMDRV_ExitPerType(&MMDrvs[i], MMDRV_MIDIIN); > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Otto-Hahn-Strasse 20, 85609 Dornach bei Muenchen Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

compiling Windows code with g++ on Linux using msvcrt - good idea? if so, how do you do it?
by foobarbaz biffblaff 11 Dec '08

11 Dec '08

Hi, I have a huge amount of Windows code that I'm porting to Linux. Wine is turning out to be a read godsend, thank you guys! Anyway, I've had tons of luck including the directory <wine_dir>/include/wine/windows in my include path. All my Windows types are there and everything is wonderful. I've even been able to link against the libraries by renaming, for example, foo.dll.so to libfoo.so and using -lfoo on the g++ command line. I actually haven't got all my functions defined so I don't know if this will actually run yet because the link isn't complete yet. My first question is whether this will work. Will all my Windows functions with function declarations defined in the windows directory and code compiled into foo.dll.so actually run? Second, I see that some of the functions I want to use are actually defined by headers in the msvcrt directory. However, this directory contains tons of header files that my system (and gcc) also have under /usr/include and gcc's own directories. I understand that msvcrt is Windows lib c, but I wonder how I'm supposed to use it with gcc to compile? I've tried -nostdinc to gcc, but the number of errors I get is enormous. It's not the end of the world if I can't use Wine's msvcrt, but if I could use it, it would define dozens more functions on which my program relies, or if its use was mandatory in order to get the functions implemented in foo.dll.so to work, then obviously I wonder how I'm supposed to compile my Windows code with Wine to make everything work? I'm sorry if this is a dumb question. I can't find a way to search the wine-devel mailing list other than with google and I can't find anything on there or other docs that answer this question, which I'm sure has been asked a million times and has a simple answer. Thank you thank you, Jeff _________________________________________________________________ Send e-mail faster without improving your typing skills. http://windowslive.com/Explore/hotmail?ocid=TXT_TAGLM_WL_hotmail_acq_speed_…

3 3

website : http://www.winehq.org/site/who gives a 404
by Paul Vriens 11 Dec '08

11 Dec '08

Hi, Just noticed that the Who is Who page is still referenced (from http://www.winehq.org/acknowledgement for example) as being on winehq.org. Wasn't this moved to the wiki? -- Cheers, Paul.

3 3