December 2008 - Wine-devel - list.winehq.org

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.
by Huw Davies 09 Dec '08

09 Dec '08

On Fri, Dec 05, 2008 at 11:04:07AM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: e86ff2a3128f4a0157ecfa10fee31d1416312c71 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=e86ff2a3128f4a0157ecfa10f… > > Author: Huw Davies <huw(a)codeweavers.com> > Date: Fri Dec 5 14:19:25 2008 +0000 > > opengl/tests: Skip tests if we can't find a pixel format. > > --- > > dlls/opengl32/tests/opengl.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c > index 35eb8ae..a3ac3af 100644 > --- a/dlls/opengl32/tests/opengl.c > +++ b/dlls/opengl32/tests/opengl.c > @@ -555,7 +555,12 @@ START_TEST(opengl) > hdc = GetDC(hwnd); > > iPixelFormat = ChoosePixelFormat(hdc, &pfd); > - ok(iPixelFormat > 0, "No pixelformat found!\n"); /* This should never happen as ChoosePixelFormat always returns a closest match */ > + if(iPixelFormat == 0) > + { > + /* This should never happen as ChoosePixelFormat always returns a closest match, but currently this fails in Wine if we don't have glX */ > + win_skip("Unable to find pixel format.\n"); > + goto cleanup; > + } > > /* We shouldn't be able to create a context from a hdc which doesn't have a pixel format set */ > hglrc = wglCreateContext(hdc); Hi Alexandre, This wasn't what I intended my patch to do. The problem is that Wine's ChoosePixelFormat() rets 0 on XServers without glX. The win_skip results in a test failure. My patch was intended to mark this as a todo_wine. Huw. -- huw(a)codeweavers.com

2 3

Re: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10
by James Mckenzie 09 Dec '08

09 Dec '08

Milan Kostić <smoki00790(a)gmail.com> at Dec 9, 2008 7:27 AM (MST) wrote about: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10 > > Console says: > > fixme:d3d_shader:register_for_arg Unknown source argument 255 > > And picture is odd with 1.1.10, in 1.1.9<= it was good i think. I >don't know exactly, but this regression can be due changes in >ati_fragment_shader.c. > > Xorg-1.5.3 > Mesa-7.2 (r200) > ATI 9250 > Can you run a regression test to discover where Wine broke this? James McKenzie

1 0

Re: [3/4]
by Henri Verbeet 09 Dec '08

09 Dec '08

2008/12/8 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* TODO: If we're called by shader_glsl_select, we know that both we get past both checks. > + * is it cheaper to have a wrapper function check those? Inline some common code? Extra > + * parameter? > + */ > if (!prog) { > /* No GLSL program set - nothing to do. */ > return; > + } else if(isStateDirty(context, STATE_PIXELSHADER) || > + isStateDirty(context, STATE_VDECL) || > + isStateDirty(context, STATE_PIXELSHADERCONSTANT) || > + isStateDirty(context, STATE_VERTEXSHADERCONSTANT)) { > + /* Will be called again later */ > + return; If you're going to introduce a dependency on state management in the shader backends anyway, you don't need to export constant loading functions from the shader backends at all. You might as well just call shader_select(), and let that figure out if it needs to change the shader or load any constants. That would also avoid this not-so-pretty code here.

2 9

re: Gecko package
by Dan Kegel 09 Dec '08

09 Dec '08

marco meijer wrote: > I have a question about wine_gecko-0.1.0.cab >This package is from 2007-05-30 11:42 and in the mean time firefox > had a lot of security updates. > Is it still save to distribute wine_gecko-0.1.0.cab ? We'd like to move to a newer one. See http://bugs.winehq.org/show_bug.cgi?id=16198 - Dan

4 4

Re: hal: add stub for ExAcquireFastMutex
by Alexander Morozov 09 Dec '08

09 Dec '08

On Tuesday 09 December 2008 03:52:01 ricardo filipe wrote: > this is for http://bugs.winehq.org/show_bug.cgi?id=12628 This is fastcall function. It should be defined like KfAcquireSpinLock.

1 0

comdlg32: includeobject needs to notify window with CDN_INCLUDEITEM
by ricardo filipe 08 Dec '08

08 Dec '08

this is related to http://bugs.winehq.org/show_bug.cgi?id=8072 so... i decided to investigate why didn't media player classic show the files when browsing... i've been debugging this for some days but found the problem, although it's not quite solved, so if anyone has any idea please share. the good thing was that mpc source code is available so i could see how it was implemented. i found out that includeObject is supposed to notify the browsing window with CDN_INCLUDEITEM that wasn't yet declared in wine. the problem is that i get: err:pidl:_ILSimpleGetTextW -- no text err:pidl:_ILSimpleGetTextW -- no text trace:commdlg:SendCustomDlgNotificationMessage RET NOTIFY trace:commdlg:SendCustomDlgNotificationMessage Retval: 0x00000000 and the notify isn't successful :\ any ideas? patch in attachment... _________________________________________________________________ Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger! http://www.amigosdomessenger.com.br/

1 1

winex11.drv: Remove unneeded address-of operators from array names
by Andrew Talbot 08 Dec '08

08 Dec '08

Please do not apply this patch, it is wrong. -- Andy.

1 0

Re: shell32.dll: Return SE_ERR_FNF if file not found before checking for associations
by Paul Vriens 08 Dec '08

08 Dec '08

Paul Chitescu wrote: > Changelog: > shell32.dll: Return SE_ERR_FNF if file not found before checking for > associations (which will fail anyway but with SE_ERR_NOASSOC). > > This fixes 6 out of the 12 shlexec test failures. > > > ------------------------------------------------------------------------ > > Hi Paul. Not sure if Patchwatcher has sent you an email: http://kegel.com/wine/patchwatcher/results/971/1.log You have to fix the tests if you fix something in wine that removes the need for a todo_wine in those tests. -- Cheers, Paul.

2 1

Re: kernel32/tests: Added some tests for behavior of 64-bit kernel handles.
by Paul Vriens 08 Dec '08

08 Dec '08

Hi Alexandre, This new test fails on Win9x as GetCurrentProcess() returns 7FFFFFFF on those platforms. I'm not sure how to fix/change/adjust the test. -- Cheers, Paul.

1 0

Re: [PATCH 5/5] msi: Add tests for MsiEnumPatchesEx.
by Alexandre Julliard 08 Dec '08

08 Dec '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > --- > dlls/msi/tests/msi.c | 1672 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 1672 insertions(+), 0 deletions(-) The test fails here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so msi.c && touch msi.ok msi.c:8027: Test failed: Expected ERROR_NO_MORE_ITEMS, got 0 msi.c:8028: Test failed: Expected patchcode to be unchanged, got {77687AD2-C53D-11DD-5D85-001A923592CB} msi.c:8030: Test failed: Expected targetprod to be unchanged, got {77687A96-C53D-11DD-5D85-001A923592CB} msi.c:8032: Test failed: Expected context to be unchanged, got 1 msi.c:8034: Test failed: Expected targetsid to be unchanged, got S-1-5-4 msi.c:8036: Test failed: Expected size to be unchanged, got 7 msi.c:8050: Test failed: Expected ERROR_NO_MORE_ITEMS, got 0 msi.c:8051: Test failed: Expected patchcode to be unchanged, got {77687AD2-C53D-11DD-5D85-001A923592CB} msi.c:8053: Test failed: Expected targetprod to be unchanged, got {77687A96-C53D-11DD-5D85-001A923592CB} msi.c:8055: Test failed: Expected context to be unchanged, got 1 msi.c:8057: Test failed: Expected targetsid to be unchanged, got S-1-5-4 msi.c:8059: Test failed: Expected size to be unchanged, got 7 msi.c:8456: Test failed: Expected ERROR_NO_MORE_ITEMS, got 0 msi.c:8457: Test failed: Expected patchcode to be unchanged, got {77687AD2-C53D-11DD-5D85-001A923592CB} msi.c:8459: Test failed: Expected targetprod to be unchanged, got {77687A96-C53D-11DD-5D85-001A923592CB} msi.c:8461: Test failed: Expected context to be unchanged, got 2 msi.c:8463: Test failed: Expected targetsid to be unchanged, got S-1-5-4 msi.c:8465: Test failed: Expected size to be unchanged, got 7 msi.c:8479: Test failed: Expected ERROR_NO_MORE_ITEMS, got 0 msi.c:8480: Test failed: Expected patchcode to be unchanged, got {77687AD2-C53D-11DD-5D85-001A923592CB} msi.c:8482: Test failed: Expected targetprod to be unchanged, got {77687A96-C53D-11DD-5D85-001A923592CB} msi.c:8484: Test failed: Expected context to be unchanged, got 2 msi.c:8486: Test failed: Expected targetsid to be unchanged, got S-1-5-4 msi.c:8488: Test failed: Expected size to be unchanged, got 7 make: *** [msi.ok] Error 24 -- Alexandre Julliard julliard(a)winehq.org

1 0