March 2008 - Wine-devel - list.winehq.org

Re: [1/2] reg: Implement basic 'reg add'. [try 2]
by Alexandre Julliard 26 Mar '08

26 Mar '08

"Andrew Riedi" <andrewriedi(a)gmail.com> writes: > +{ > + LPCTSTR lpSubKey; Please don't use TCHAR types. > + static const WCHAR hkcrW[] = {'h','k','c','r',0}; > + static const WCHAR hkcuW[] = {'h','k','c','u',0}; > + static const WCHAR hklmW[] = {'h','k','l','m',0}; > + static const WCHAR hkuW[] = {'h','k','u',0}; > + static const WCHAR hkpdW[] = {'h','k','p','d',0}; > + static const WCHAR hkccW[] = {'h','k','c','c',0}; > + static const WCHAR hkddW[] = {'h','k','d','d',0}; > + > + /* Determine key type. */ > + if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkcrW, 4) == CSTR_EQUAL) > + *hKey = HKEY_CLASSES_ROOT; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkcuW, 4) == CSTR_EQUAL) > + *hKey = HKEY_CURRENT_USER; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hklmW, 4) == CSTR_EQUAL) > + *hKey = HKEY_LOCAL_MACHINE; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 3, hkuW, 3) == CSTR_EQUAL) > + *hKey = HKEY_USERS; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkpdW, 4) == CSTR_EQUAL) > + *hKey = HKEY_PERFORMANCE_DATA; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkccW, 4) == CSTR_EQUAL) > + *hKey = HKEY_CURRENT_CONFIG; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkddW, 4) == CSTR_EQUAL) > + *hKey = HKEY_DYN_DATA; You should use some sort of array instead of duplicating all that code, and you need to check the next character of the string too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine 1.0 status: T minus 74 days. 78 open bugs.
by Dan Kegel 26 Mar '08

26 Mar '08

Today, three bugs were resolved: 4803 programs 5 Steam: not all lnk files are processed into linux shortcuts 10032 winsock 1 Wine must not use unix select() for networking where there might be high fd's 11431 user32 5 Adobe Photoshop CS2: z-overlay of image containers (although 10032's fix went too far, and one hunk is pending reversion). and one bug was deferred: 7915 -unknown 4 15 of the internal tests of wine fail on Mac OS X History: 3/22: 87 bugs, 76 days to go 3/23: 82 bugs, 75 days to go 3/24: 78 bugs, 74 days to go Excellent progress. Too bad past performance is no indication of future results :-) Here's a list of the currently open 1.0 bugs, sorted by component, with votes: 5948 -unknown 1 Star Trek: Armada does not install 11281 -unknown 2 CJK input many issues 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 8125 -unknown 0 Marratech 6.1 crashes on start 9916 -unknown 6 "make test" usually fails 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 9459 -unknown 8 FIFA 2007 crashes with the recent versions 12097 -unknown 2 Wine 1.0 should not ship out-of-sync resource translations 7477 -unknown 1 Uplink demo crashes 4971 -unknown 3 Corel Draw 12 demo install fails 9178 -unknown 7 "hello world" dos program hangs 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5844 -unknown 9 tray minimize 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 5402 -unknown 0 Trying to run PhotoStitch 3.1 10147 -unknown 0 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 2 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 1 Multi-select listview: Shift-arrow up only selects top two items 10111 comctl32 2 WINEDEBUG=warn+heap "make test" has heap error in comdlg32/tests/printdlg.c 9104 comdlg32 2 Pdf-xchange viewer crashes 10040 crypt32 2 Steam crashes during the startup 11681 directx- 13 Add support for video overlay 5955 directx- 6 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 1 Stabilize Winelib User Guide Table of Contents 638 document 7 Document Wine debugging channels 6519 gdi32 7 Wine blacks out rotated font bitmap 9771 gdi32 37 Steam Friends doesn't work (fails to render correctly or refresh) 3270 gdi32 13 Problem with minimized top-level windows 9926 gdi32 4 gdi32.dll should not have exported function pointers 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 5351 kernel32 8 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 4733 kernel32 4 Get optimized/compressed/packed executables (non-upx) working 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 11 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 6607 ole 8 Drag and Drop not working 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 8095 ole 0 PQ Teaching toy crashes 4770 ole 2 BlackBerry Device Manager fails to install under wine 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 11 MOTD in counter-strike 1.6 and counter-strike source does not render 8439 shell32 5 Visual Studio .NET (7) install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 664 user32 5 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 5623 winex11. 2 GetAsyncKeyState wrong if querying process doesn't have focus 3297 winex11. 11 UpdateWindow() doesn't call XFlush() 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 2368 winex11. 5 Wine loses its X-Window when switching to another virt. desktop in Fvwm 11019 winex11. 1 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 11884 winex11. 1 Copy and paste garbage on end 1990 winex11. 1 modifier keys not released when switching desktop 10984 winex11. 2 sun jre 5 update 10 installer hangs in 0.9.52 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 5625 wininet 3 Wine does not handle internet proxy settings conveniently 9787 winsock 45 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

2 1

Re: [1/2] shlwapi: added tests for SHCreateStreamOnFile IStream_Read.
by Reece Dunn 26 Mar '08

26 Mar '08

On 25/03/2008, Reece Dunn <msclrhd(a)googlemail.com> wrote: > This patch adds some basic tests for the Read method of the various > SHCreateStreamOnFile APIs, while making it possible to add other > IStream method tests. > > At the moment, these tests are being skipped on Wine because it is not > returning a valid stream object in the tests. Alexandre: please ignore these patches for now. I am working on a more comprehensive series of tests for the various IStream methods. Thanks, - Reece

1 0

Scriptable configuration (reg.exe) proposals
by Maarten Lankhorst 26 Mar '08

26 Mar '08

Hello potential students, There have been at least 4 people interested in doing the reg.exe project for summer of code, but unfortunately this is not really a good project idea, becuse you can pretty much implement it all in a single day by just calling the right advapi calls. Making winecfg work from the command line is also not hard and you can't fill up 2 or 3 months with this. I'm sorry for not investigating reg.exe further. This should never have been on the ideas list to begin with, and I should be the one to be blamed for not spotting it earlier. I would strongly recommend adding a proposal for another project. It doesn't have to be one from the ideas list, on the contrary: The most succesful applications have been initiatives from people themselves. As long as you work, interact with the community and communicate with your mentor and share your code and ideas you will get paid. I hope that you will have luck in finding other proposals, and that you will be able to participate and complete gsoc succesfully. Regards, Maarten.

1 0

GSoc: Scriptable Configuration
by Matt Shanks 26 Mar '08

26 Mar '08

Hello all, Am quite keen to get involved with Wine for GSoC - specifically the project titled "Scriptable Configuration <http://wiki.winehq.org/SummerOfCode>" Having spoken briefly to Lei, he essentially said that the more features added to the reg.exe in Wine, the better. I looked up what the Windows version does, and it seems like a pretty solid list of features to aim for; - add Adds a new subkey or entry into the registry - delete Deletes a subkey or entries from the registry - query Displays the data in a subkey or a value - compare Compares specified registry subkeys or entries - copy Copy a subkey to another subkey - Save Saves a copy of specified subkeys, entries, and values of the registry in hive (binary) format-- could be changed to save as plaintext/flatfile format - Load Load a key values etc (Source <http://commandwindows.com/reg.htm>) An apparent missing feature seems to be editing an existing key value Also, for the command line tools for wine, beyond uninstallation and windows-version calls, (from Console Configuration<http://wiki.winehq.org/ConsoleConfiguration>) are there any other particularly desirable features? Any input/comments from anyone is much appreciated, Kind regards, Matt Shanks ('napi' on IRC)

2 1

qmgr test needs bits.lib to link using the MSVC headers
by Reece Dunn 26 Mar '08

26 Mar '08

Hi, I have been going through the tests to see if I can make them work using MSVC headers. When building the qmgr tests, I have found that you need to add bits.lib to LIBS (Linker/Input/Additional Dependencies). Doing this gets the test to link properly. Does anyone know how to add this to Wine? Adding EXTRALIBS=-lbits to Makefile.in does not work on Wine itself. Is this the right way to go? - Reece

2 1

Google SoC proposal
by Artur Szymiec 25 Mar '08

25 Mar '08

Greetings, I would like to participate in Wine SoC this year. I propose to implement WINED3DPMISCCAPS_TSSARGTEMP which is needed by some d3d games/apps using GL_ARB_fragment_program pixel shaders. Do you think it's a good proposal for SoC ? Best regards Artur Szymiec -- -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+ Conquer your Desktop! http://www.kde.org/trykde/ Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ --------------------------------------------------------------------------

2 1

Re: Alistair Leslie-Hughes : msxml3: Added support for SAXXMLReader.
by Michael Stefaniuc 25 Mar '08

25 Mar '08

Hello Alistair, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 264be58812fedf9a066bac521f9fff5821759890 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=264be58812fedf9a066bac521… > > Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Tue Mar 25 14:19:10 2008 +1100 > > msxml3: Added support for SAXXMLReader. Smatch is complaining about SAXXMLReader_create() loosing memory. HRESULT SAXXMLReader_create(IUnknown *pUnkOuter, LPVOID *ppObj) { saxreader *reader; TRACE("(%p,%p)\n", pUnkOuter, ppObj); reader = HeapAlloc( GetProcessHeap(), 0, sizeof (*reader) ); if( !reader ) return E_OUTOFMEMORY; reader->lpVtbl = &saxreader_vtbl; reader->ref = 1; TRACE("returning iface %p\n", *ppObj); return S_OK; } reader is a local variable with function scope. Stuff gets assigned to it but there is no usage of it nor is it "exported" aka made visible outside of the function. Is there something missing here? bye michael

3 2

Summer of Coders wanted!
by Maarten Lankhorst 25 Mar '08

25 Mar '08

Hi all, Since yesterday google is accepting applications for all participating projects. See http://code.google.com/soc for how to apply and read the faq linked there! The past few days a lot of good proposals were discussed, but you really need to submit them to the google web application officially to make them count. The deadline for this is 1 april 2008 00:00 UTC, but I would recommend submitting your application a few days before that to be sure. It optional, but recommended to slip a patch past Alexandre Julliard, he's Swiss so bribing with chocolate doesn't work! It doesn't have to be a big patch, just so that we know you can check out the wine git tree, and know how to get a patch in. Of course if you already did this once you don't have to do it again. A good guideline to what should be in an application is at http://www.perlfoundation.org/perl5/index.cgi?gsoc2008_proposal_template You don't have to follow this, but it's a good indication of what an application should contain. It's also a good idea to separate your goals into must-haves and nice-to-haves. The must haves you definitely want to do before the end of the summer, and the nice-to-haves are for the goals that you want to do, but you're not sure if you have all the time for them. Cheers, Maarten. PS: Mentors wanted, too! If you want to be a mentor, but have questions or doubts, contact me privately. To sign up as mentor: http://tinyurl.com/29awt6

1 0

Re: [PATCH 8/9] wined3d: remove ENTER_GL/LEAVE_GL in texture and cube texture PreLoad.
by Roderick Colenbrander 25 Mar '08

25 Mar '08

> > Not really needed for anything and can lead to ActivateContext being > called > while holding lock. > --- > dlls/wined3d/cubetexture.c | 2 -- > dlls/wined3d/texture.c | 3 +-- > 2 files changed, 1 insertions(+), 4 deletions(-) Sure this is a problem but there needs to be a place which calls ENTER_GL/LEAVE_GL. I believe LoadTexture and some of the other functions aren't handling that properly yet, so I wouldn't add this yet. It is very tricky. Roderick -- Psst! Geheimtipp: Online Games kostenlos spielen bei den GMX Free Games! http://games.entertainment.gmx.net/de/entertainment/games/free

2 1