March 2008 - Wine-devel - list.winehq.org

Re: setupapi: Implement pSetupGetField, with tests.
by Paul Vriens 27 Mar '08

27 Mar '08

Hi James, I'm looking into a crash of the setupapi/parser test on Vista. It crashes in this piece: 465 ret = HeapFree( GetProcessHeap(), 0, (LPVOID)field ); 466 ok( !ret, "Expected HeapFree to fail\n" ); 467 ok( GetLastError() == ERROR_INVALID_PARAMETER, 468 "Expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError() ); when trying the second field. It's been added by a patch of yours: http://source.winehq.org/git/wine.git/?a=commit;h=7588b669d8331ff64fc3b75ce… What's the reason for checking the HeapFree here? Or what's the reason for doing it at all? -- Cheers, Paul.

3 3

Contributing
by Travis Athougies 27 Mar '08

27 Mar '08

Hi, I would like to help contribute to WINE because I use it so much yet I've never actually contributed to it. I was wondering if there are any simple bugs or other tasks that someone new to WINE development could undertake. Thanks. -- From: Travis Athougies 2 + 2 = 4

2 1

Re: [Tools 3/6] winetest: Fix merging of the individual test results into one group result, especially when they all report the dll is missing or that the test crashed, etc.
by Paul Vriens 27 Mar '08

27 Mar '08

Francois Gouget wrote: > Merge all the data for a given unit test to a single structure instead of scattering them into multiple hashtables. > The new result data structure makes it possible for the same code to work for both group and individual report results. > --- > > This fixes the many '.' found in the summary table. > > winetest/gather | 333 ++++++++++++++++++++++++++++++++++--------------------- > 1 files changed, 204 insertions(+), 129 deletions(-) > > diff --git a/winetest/gather b/winetest/gather > index d032e23..881134a 100755 > --- a/winetest/gather > +++ b/winetest/gather > @@ -37,32 +37,45 @@ $name0 =~ s+^.*/++; > my $summary_version=4; > > .... > > +sub min_to_max($) > +{ > + my ($minmax)=@_; > + return $minmax->[0] if ($minmax->[0] == $minmax->[1]); > + return "$minmax->[0] to $minmax->[1]"; > +} > + Don't we need quotes around "x to y"? Firebug complains about this. > + my $mm_count=min_to_max($result->{count}); > + my $mm_errors=min_to_max($result->{errors}); > + my $mm_todos=min_to_max($result->{todos}); > + my $mm_skips=min_to_max($result->{skips}); > + my $title="$mm_count tests, $mm_errors errors, $mm_todos todos, $mm_skips skips"; Or put the quotes here of course. The results of your latest patches can be seen at: http://test.winehq.org/data/200803191000/ -- Cheers, Paul.

2 1

Re: [2/2] Setupapi patch
by Dmitry Timoshkov 27 Mar '08

27 Mar '08

"Alexander Morozov" <amorozov(a)etersoft.ru> wrote: > + if (ReferenceString && lstrlenW(ReferenceString)) > { > /* space for a hash between string and reference string: */ > len += lstrlenW(ReferenceString) + 1; > @@ -258,10 +258,10 @@ static LPWSTR SETUPDI_CreateSymbolicLink > /* replace '\\' with '#' after the "\\\\?\\" beginning */ > for (ptr = strchrW(ret + 4, '\\'); ptr; ptr = strchrW(ptr + 1, '\\')) > *ptr = '#'; > - if (ReferenceString) > + if (ReferenceString && lstrlenW(ReferenceString)) Calling lstrlenW on ReferenceString is not needed, checking *ReferenceString is enough. -- Dmitry.

1 0

Re: widl: Use is_string_type for detecting strings in write_typeformatstring_var to make it consistent with write_remoting_arg.
by Alexandre Julliard 27 Mar '08

27 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > Fix the is_string_type function used for detecting strings by only > examining aliases instead of both aliases and pointers. This is due to > the requirement that pointers to strings be handled as pointers and so > not detected as strings. This breaks qmgr: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so file.c && touch file.ok file.c:127: Test failed: Got incorrect remote name file.c:144: Test failed: Got incorrect local name make: *** [file.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] user32: add a DrawText test for bug 12226.
by Alexandre Julliard 27 Mar '08

27 Mar '08

"Lei Zhang" <thestig(a)google.com> writes: > +static void test_Bug12226(void) > +{ Please name functions according to what they do, not their bug number. The code must be understandable without having to look things up in bugzilla. In any case this should most likely go into the existing test_DrawTextCalcRect() function. > + height = DrawTextA(hdc, "", -1, &rect, > + DT_CALCRECT | DT_LEFT | DT_SINGLELINE); > + todo_wine ok(16 == height, "expected %d, got %d\n", 16, height); I don't think you can hardcode 16, that should depend on the font metrics. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] D3D8: Reject broken normal declaration types with fixed function
by Alexandre Julliard 27 Mar '08

27 Mar '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From d9182d3da1416e0bfa06b1fe879c4c74c66b0c3e Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Wed, 12 Mar 2008 01:06:38 +0100 > Subject: [PATCH] D3D8: Reject broken normal declaration types with fixed function This doesn't work for me: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok visual.c:1184: Test failed: IDirect3DDevice8_CreateVertexShader returned with 0x8876086c make[2]: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine 1.0 status: T minus 72 days. 74 open bugs.
by Dan Kegel 27 Mar '08

27 Mar '08

44 days to code freeze. Four bugs fixed in the last two days: 9104 comdlg32 2 Pdf-xchange viewer crashes 10040 crypt32 2 Steam crashes during the startup 10111 comctl32 2 WINEDEBUG=warn+heap "make test" has heap error in comdlg32/tests/printdlg.c 11884 winex11. 1 Copy and paste garbage on end History: 3/22: 87 bugs, 76 days to go 3/23: 82 bugs, 75 days to go 3/24: 78 bugs, 74 days to go 3/26: 74 bugs, 72 days to go Here's a list of the currently open 1.0 bugs, sorted by component, with votes: 5948 -unknown 1 Star Trek: Armada does not install 4971 -unknown 3 Corel Draw 12 demo install fails 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 10 tray minimize 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 7477 -unknown 1 Uplink demo crashes 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 7 "hello world" dos program hangs 9459 -unknown 8 FIFA 2007 crashes with the recent versions 9916 -unknown 6 "make test" usually fails 9959 -unknown 8 Make wine updates work even if the registry changed 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 2 CJK input many issues 12097 -unknown 2 Wine 1.0 should not ship out-of-sync resource translations 556 build-en 2 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 5955 directx- 7 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 11681 directx- 14 Add support for video overlay 82 document 2 Stabilize Winelib User Guide Table of Contents 638 document 8 Document Wine debugging channels 12217 document 0 Documentation should be in XML and not SGML format 3270 gdi32 14 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 9926 gdi32 5 gdi32.dll should not have exported function pointers 4733 kernel32 5 Get optimized/compressed/packed executables (non-upx) working 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 11 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 4770 ole 3 BlackBerry Device Manager fails to install under wine 6607 ole 8 Drag and Drop not working 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 7 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 6 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 5623 winex11. 3 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 10984 winex11. 4 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 2 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 5625 wininet 3 Wine does not handle internet proxy settings conveniently 9787 winsock 46 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Re: [PATCH 1/2] user32: Properly translate keyboard left/right-shift, alt, ctrl keys hardware messages.
by Vitaliy Margolen 27 Mar '08

27 Mar '08

Vitaliy Margolen wrote: > --- > dlls/user32/message.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > > [PATCH 2/2] winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 5) Alexandre, what was wrong with these patches? I moved the remapping of messages as you suggested. Vitaliy.

1 0

[RFC] Improving the summary results on test.winehq.org
by Reece Dunn 26 Mar '08

26 Mar '08

Hi, Looking at the results from a test run (e.g. http://test.winehq.org/data/200803181000/) it would be nice to have: 1. A summary of a dlls overall results (i.e. the summation of all its unit test results), preferably before the individual tests, but could live with them at the bottom. 2. A summary of the entire test results (i.e. the summation of all unit test results for all dlls). This would be best at the top where it is easily visible. 3. Possibly display the number of tests run in a given pass (e.g. 0/12 or 1+3/27). This is to give an idea of how many tests have been run easily (especially for the dll and overall summaries). The idea is to get a quick idea of the health of the test results for each operating system and dll. - Reece

4 3