May 2008 - Wine-devel - list.winehq.org

re: ws2_32: Test for invalid hostnames again.
by Dan Kegel 15 May '08

15 May '08

Kai, that test will always fail on some systems. How about this: just test for whether that function completes at all, rather than testing for success. - Dan

2 1

Re: dinput: Convert keyboard buffer from internal data format to user data format
by Vitaliy Margolen 15 May '08

15 May '08

Sergey Khodych wrote: > > > Any particular reason for this? Do you have a program that sets different data format? The reason I ask - copying 256 bytes is much faster then iterating over the whole data format and copying one byte at a time. Vitaliy.

2 5

shell32 failures only under winetest, not make test?
by Dan Kegel 15 May '08

15 May '08

Oddly, I only see shelllink.c:90: Test succeeded inside todo block: SHILCreateFromPath failed (0x00000000) shelllink.c:194: Test succeeded inside todo block: path_to_pidl returned a NULL pidl shelllink.c:214: Test failed: GetPath returned 'C:\nonexistent\file' shelllink: 190 tests executed (2 marked as todo, 3 failures), 0 skipped. when I run on wine with winetest-dist. When I do 'make test', shelllink.ok gets created fine. Anyone else see that?

1 0

Wineconf 2008
by Jeremy White 14 May '08

14 May '08

Hi Folks, We have provisionally set Wineconf for the weekend of September 27/28 in Saint Paul, Minnesota. The Wine conference is open to all. We host 2 days of informal sessions to discuss technical issues related to Wine development. We'll likely also have a celebration of Wine 1.0, and other social activities. If you're interested in Wineconf, please visit this web page: http://www.winehq.org/site/wineconf/survey In particular, if you have given up on Wineconf because of travel costs, please indicate that on the form. I'll use the response data I get there to nail down the details. I look forward to seeing you all, and to celebrating 1.0! Cheers, Jeremy

1 0

Re: wine.inf: add a fake dll for sensapi.dll
by Austin English 14 May '08

14 May '08

Anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2008-May/054794.html

2 2

re: Serial port support in wine-1.0: What to do to make it working ?
by Dan Kegel 14 May '08

14 May '08

Pavel wrote: > I have to use wine-0.9.40 to communicate with a device > in my work (simple text-based command-reply communication), > any wine newer than say 0.9.50 doesn't work, the communication times out. > ... I will try to dig into the driver and search for the bugs there. > One of the cases is I think simple, the device uses normal ASCII protocol > and I can talk to it using kermit or minicom, but the windows program > intended to control it simply stucks on the first command and never > gets a reply. I think there is a good place to start. Yep. FWIW, the fix might be tiny. Alexandre fixed a serial bug today, http://bugs.winehq.org/show_bug.cgi?id=9356 with just a single assignment. If you can come up with a simple way for others to reproduce the problem, that might help, too. Lessee... here are most of the existing serial bug reports; some of them (eg. 4055, 8783, 9988, 10051, 10056, 11399, 11811) have interesting info: http://bugs.winehq.org/show_bug.cgi?id=1244 (big grab bag of apps, some downloadable) http://bugs.winehq.org/show_bug.cgi?id=1700 (putty, downloadable) http://bugs.winehq.org/show_bug.cgi?id=4055 (interesting, points to kernel bug) http://bugs.winehq.org/show_bug.cgi?id=4633 (Garmin) http://bugs.winehq.org/show_bug.cgi?id=4753 (workaround, interesting, mentions kernel problem) http://bugs.winehq.org/show_bug.cgi?id=5154 (Siemens phone; 0.9.12 bad) http://bugs.winehq.org/show_bug.cgi?id=6895 (0.9.27 bad; timeout control broken) http://bugs.winehq.org/show_bug.cgi?id=5632 (Secure CRT behaves funny, downloadable) http://bugs.winehq.org/show_bug.cgi?id=8113 (0.27 good, 0.35 bad) http://bugs.winehq.org/show_bug.cgi?id=8783 (pinpoints the very commit that caused the problem in 0.9.23!) http://bugs.winehq.org/show_bug.cgi?id=9988 (good analysis, example code, patch) http://bugs.winehq.org/show_bug.cgi?id=10051 (HAL needs to create entries for serial ports?) http://bugs.winehq.org/show_bug.cgi?id=10056 (good source testcase!) http://bugs.winehq.org/show_bug.cgi?id=10573 (wine's tests fail on laptop with serial port; bisect) http://bugs.winehq.org/show_bug.cgi?id=11077 (HAL needs to create entries for serial ports) http://bugs.winehq.org/show_bug.cgi?id=11339 (bugfix for serial.c) http://bugs.winehq.org/show_bug.cgi?id=11811 (HAL support needs improvement) http://bugs.winehq.org/show_bug.cgi?id=11829 (0.9.22 good, 0.9.56 bad) http://bugs.winehq.org/show_bug.cgi?id=12479 (timeout problems?) OMG that's a lot of bugs. There has been a LOT of analysis done by various folks; now it's time to grind through it all and fix the problems. As I mentioned, Alexandre has fixed one already; perhaps he has time to look at a few more of these. FWIW, I have some win32 serial i/o example source code here, along with an archive of comments about problems (from back in the day when multiplayer games talked to modems): http://alumnus.caltech.edu/~dank/overlap.htm - Dan

3 3

TrendyFlash Site Builder works!
by Dan Kegel 14 May '08

14 May '08

http://bugs.winehq.org/show_bug.cgi?id=9376 People who generate annoying cookiecutter Flash web sites can now migrate to LInux with confidence :-)

1 0

Re: comctl32: Fix statusbar text alignment bug #12693
by James Hawkins 14 May '08

14 May '08

On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <tarasov.igor(a)gmail.com> wrote: > MSDN regarding statusbar text alignment says that "By default, text is > left-aligned <...> Text to the right of a single tab character is > centered, and text to the right of a second tab character is > right-aligned.". Current implementation, however, could be described > as "if the first character is tab, center the text. Then check second > character, if it is tab too, left-align the text". This patch makes > wine behave more like MSDN says and fixes bug > http://bugs.winehq.org/show_bug.cgi?id=12693 . > Please add a test case to prove this change is correct. -- James Hawkins

2 2

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream
by Kirill K. Smirnov 13 May '08

13 May '08

>> This doesn't look right. What if it's wineconsole with user backend >> (default) and OEM CP (which is different then UNIXCP)? Should probably hack >> GetConsoleOutputCP() instead. >> >this code is only used when no wineconsole is attached, so unixcp is the >right choice No, this is used in case of output redirection too. E.g. even in wineconsole, command c:>dir > list.txt will create a list.txt file in UNIXCP, but ConsoleOutputCP is expected. In most cases it does not hurt, but who knows... >however, it can be considered that GetConsoleOutputCP() should be >changed to return the unixcp and not the oem cp when no console is attached -- Kirill

1 0

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream
by Vitaliy Margolen 13 May '08

13 May '08

Eric Pouech wrote: > @@ -1437,7 +1437,7 @@ static void WCMD_output_asis_len(const WCHAR *message, int len, HANDLE device) { > } > > /* Convert to OEM, then output */ > - convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0, message, > + convertedChars = WideCharToMultiByte(CP_UNIXCP, 0, message, > len, output_bufA, MAX_WRITECONSOLE_SIZE, > "?", &usedDefaultChar); > WriteFile(device, output_bufA, convertedChars, > > This doesn't look right. What if it's wineconsole with user backend (default) and OEM CP (which is different then UNIXCP)? Should probably hack GetConsoleOutputCP() instead. Vitaliy.

2 1