May 2008 - Wine-devel - list.winehq.org

Re: stub implementation of GdipImageGetFrameDimensionsCount and GdipGetImageFlags
by Nikolay Sivov 12 May '08

12 May '08

GdipGetImageFlags is commited today. 2008/5/12 Petr Dlouhý <petr.dlouhy(a)email.cz>: > This is fix for bug 13036 (http://bugs.winehq.org/show_bug.cgi?id=13036) It > allows Faktury 4.1 to start. > > -- > Petr Dlouhý > > >

1 0

Re: Partial revert of c8bdebd... to fix bug #13093.
by Vitaliy Margolen 12 May '08

12 May '08

Reece Dunn wrote: > The patch "winealsa: Remove calls to deprecated functions." broke > audio playback on Cepstral SwiftTalker [bug #13093] (may also affect > other text-to-speech software like Dragon Naturally Speaking) when > running on Ubuntu 8.04 with pulseaudio+alsa (but may break on other > platforms). > > This patch reverts two of those lines that are needed to fix this > issue and generate clean WINEDEBUG=+wave,+dsalsa output. > > - Reece > > Wait a sec. Is the bug present without pulseaudio? Vitaliy.

1 0

Re: stub implementation of GdipImageGetFrameDimensionsCount and GdipGetImageFlags
by Vitaliy Margolen 12 May '08

12 May '08

Petr Dlouhý wrote: > This is fix for bug 13036 > (http://bugs.winehq.org/show_bug.cgi?id=13036) It allows Faktury 4.1 to > start. > > +GpStatus WINGDIPAPI GdipGetImageFlags(GpImage* image, UINT *flags) > +{ > + static int calls; > + > + if(!image || !flags) > + return InvalidParameter; > + > + if(!(calls++)) > + FIXME("not implemented\n"); > + > + return Ok; > +} You need to print paramenters this function is called with. And don't forget include the "magic" word "stub" in the text of the fixme. Also why are you limiting number of printed fixmes? Vitaliy.

1 0

Re: [PATCH 2/2] wined3d: Activate context for the right target in surface_blt_to_drawable.
by Vitaliy Margolen 12 May '08

12 May '08

Alexander Dorofeyev wrote: > > Fixes http://bugs.winehq.org/show_bug.cgi?id=12890 that affects several > games locking front buffer when using readtex RT lock mode. > --- > - ActivateContext(device, device->render_targets[0], CTXUSAGE_BLIT); > + ActivateContext(device, (IWineD3DSurface*)This, CTXUSAGE_BLIT); I think Stefan said something about this not being correct. The blitting is going into the render target not the current surface. In your case if the surface is not the render target, then it's not being properly selected. Vitaliy.

3 3

Re: d3dx9: Texturing functions
by tony.wasserka＠freenet.de 12 May '08

12 May '08

> > So, the first thing I want to make sure is that we redirect the function calls correctly in order > > to reduce double coding. > > This means on the one hand that we should call the Extended versions of each function > > from inside of the simpler ones (most default parameters for the Ex functions are > > on MSDN) and on the other hand that we unify all D3DXCreateTextureFromXXEx > > functions somehow. I don't know how Resources are stored internally, but I guess > > the simplest would be to redirect all of them to D3DXCreateTextureFromFileInMemory, i.e. > > when D3DXCreateTextureFromFile is called we read the file into memory and call the > > InMemory function. I hope this shouldn't be too hard to be applied to the resource function > > either. Of course, this should also be done at the corresponding Surface, Volume and > > cube texture functions. > > Also, I haven't looked too much into it yet, but I guess we could go even a step further > > and define the CreateTextuteFromXX calls like this: > > 1. Redirect to the corresponding D3DXCreateXFromFileInMemoryEx call > > 2. Call D3DXCheckXRequirements > > 3. Call IDirect3DDevice9::CreateTexture > > 4. Lock its surface > > 5. Call LoadSurfaceFromFileEx with it > > > > This would reduce most of our coding work on LoadSurfaceFromFileEx. > > However, there are still plenty of formats supported by the texturing functions > > and thus, plenty of work for us to do. IIRC we once came to the decision to > > use libraries like libpng or so to reduce that work, too, so we'd just need > > to implement formats like .dds. > > I can't remember what the differences are between the CreateTexture and > LoadSurface functions, but this is what I'd do for the LoadSurface functions: > > LoadSurfaceFromMemory (read data with the specified pixel format) > LoadSurfaceFromFileInMemory (parse image format, read actual data into memory) > LoadSurfaceFromFile (open file, read contents into memory) > LoadSurfaceFromResource (open resource, read contents into memory) > LoadSurfaceFromSurface (read image data from a surface) > > This would mean two huge chunks of code: One which parses image formats > (LoadSurfaceFromFileInMemory), and one which handles all the resizing, > conversion, filtering and stuff (LoadSurfaceFromMemory). Sorry that I'm replying that late, I was a bit busy when you wrote the reply and then nearly forgot about it. I'd agree with that design and I'll soon prepare a stub-layout for texture.c for after-code-freeze. However, have you finished the D3DXCheckTextureRequirements code meanwhile so we can start implementing the other functions? Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

re: Lots of regressions in games in last few versions
by Dan Kegel 12 May '08

12 May '08

Marcel wrote: > i don't even see the point of a 1.0 release at this point in time. > This project has been a work in progress since 15 years. > Why the heck has it been decided to do a 'gold' release *now* anyways? To get lots more people to try it and report bugs, so it can improve faster. And to get the word out about its rapid progress in the last two years. Most people still think Wine can't wipe its nose. Now, for some users, Wine still can't wipe its nose -- it all depends on the app you try. But it seems that "linux wine sucks" pulls only about half as many hits as "linux wine amazing" in a web search, so we must be doing something right lately. - Dan

4 4

Re: Stop flooding with EV_TXEMPTY and EV_RXCHAR
by Vitaliy Margolen 11 May '08

11 May '08

Michael Karcher wrote: > Do not generate an EV_TXEMPTY event if the transmitter is empty, > but if it got empty. Do not generate a EV_RXCHAR event if some > bytes are in the queue, but if some new bytes got into the queue. > Handle a Linux quirk that TIOCGICOUNT might report characters that > TIOCINQ does not yet report. > > Add some further TRACE calls to aid debugging. Please one change at a time (as a separate patch). In case of possible regressions it would be much easier to catch what was the cause. Vitaliy.

1 0

New winetricks 20080511: dotnet11 working again, new verb fontfix
by Dan Kegel 11 May '08

11 May '08

Another week, another winetricks. Changes since last week's annoucement: - dotnet11 now works again. Removed GAC kludge, added font kludges. - new verb fontfix to install working versions of arphic fonts (bad versions crash dotnet 1.1) I haven't looked at whether dotnet20 also needs the font kludges... Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 1

Re: [PATCH] ddraw: Fix some code unprotected by ddraw lock.
by Vitaliy Margolen 11 May '08

11 May '08

Alexander Dorofeyev wrote: > --- > dlls/ddraw/device.c | 24 ++++++++++++++---------- > 1 files changed, 14 insertions(+), 10 deletions(-) > > What is this patch fixing? Do you have tests? Do you have a bug # showing the problem? Please explain why parts of the code needs to be protected? Vitaliy.

2 2

Concerning Bug 11509 (AES Provider Handling for Windows XP)
by Mounir IDRASSI 11 May '08

11 May '08

Hi, >From what I see, the patch correcting this bug from Vijay has been refused because it modifies the name of the RSA and AES provider, which is wrong. However, this patch can be easily changed to keep the current name and simply add a new provider name. So, the declaration of the variable szRSAName should be changed to "static const WCHAR szRSAName[4][66]" and its value appended at the end with the new name of the provider for XP instead of modifying the last field. This way, I'm sure the patch will be accepted. Vijay : can you submit a modified version of your patch. Cheers, Mounir IDRASSI IDRIX - Cryptography And IT Security Experts http://www.idrix.fr

2 1