May 2008 - Wine-devel - list.winehq.org

Wine 1.0 status: rc2 in 12 days, 34 bugs left
by Dan Kegel 10 May '08

10 May '08

Hell is starting to freeze over. A clickable version of the following info is at http://kegel.com/wine/countdown.html Wine is now in a code freeze in preparation for the 1.0 release. According to http://wiki.winehq.org/WineReleasePlan, wine-1.0.0-rc2 will be due out Friday, May 23rd, 2008. It will be something like be the next to last release candidate for 1.0. During the code freeze, patches that * are simple * come with a conformance test * fix a regression * are low risk are more likely to get in than other patches. (Heck, that's always true, but it's even truer during a freeze.) We will actively discourage patches that might endanger a June 1.0 release. Bug Status There are 34 open 1.0 bugs as of 10 May. Most of these will simply be rolled over to be fixed for a later release; we only have time to fix a few, and much as we'd like to fix the rest, most are not showstoppers. Changes since last week (with category and votes): New (!): 13071 quartz 0 Flashplayer crashes in a quartz bug 13115 advapi 0 .net 1.1 installer fails in ControlService() Fixed: 8125 -unknown 0 Marratech 6.1 crashes on start 8783 ntdll 14 USB serial ports do not work 9178 -unknown 8 "hello world" dos program hangs 9356 ntdll 11 Serial communication not working since wine-0.9.33 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) Invalid: 12914 tools 1 wineprefixcreate overrides custom entries in Explorer\\Shell Folders Deferred: 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 7372 winex11. 14 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9942 ole 3 Powerpoint Viewer 2007 crashes opening .pptx files Here's the full list of current bugs: 13115 advapi 0 .net 1.1 installer fails in ControlService() 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 20 Planescape:Torment doesn't work 11584 directx- 2 Multiple games crash with stack overflow error 3270 gdi32 16 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 9771 gdi32 45 Steam Friends doesn't work (fails to render correctly or refresh) 12730 gdi32 1 gdi32: some tests fail when X is run in 16 bit mode, but not 32 bit 5024 kernel32 5 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 10147 msi 2 Word Viewer 2003 - Tab behavior differs from Windows 12263 opengl 3 Sketchup Cannot initialize OpenGL - ChoosePixelFormat fails 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 10288 programs 0 wine_gecko download hangs sometimes 13071 quartz 0 Flashplayer crashes in a quartz bug 5163 setupapi 14 Office XP 2002 crashes on installation 6095 shdocvw 16 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 1 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 8439 shell32 10 Visual Studio .NET (7) install fails 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 3 The conformance tests fail on Windows 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 16 tray minimize 5948 -unknown 2 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 9916 -unknown 6 "make test" usually fails 11281 -unknown 5 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 664 user32 8 The help menu functionality inside programs is broken (messaging problem) 3023 user32 6 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 9787 winsock 63 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 2 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

VB6 and wine_get_unix_file_name
by Escuder Nicolas 10 May '08

10 May '08

Hello, I'm trying to make a function for using wine_get_unix_file_name in VB6 programs. Private Declare Function lstrcpyA Lib "kernel32.dll" (ByVal lpString1 As String, ByVal lpString2 As Long) As Long Public Declare Function GetProcessHeap Lib "kernel32" () As Long Public Declare Function HeapFree Lib "kernel32" (ByVal hHeap As Long, ByVal dwFlags As Long, IpMem As Any) As Long Public Declare Function wine_get_unix_file_name Lib "kernel32" (ByVal lpszSrc As String) As Long Public Function GetUnixPath(ByVal sPath As String) As String Dim ptr As Long Dim sBuffer As String * 255 ptr = wine_get_unix_file_name(StrConv(sPath, vbUnicode)) lstrcpyA sBuffer, ptr HeapFree GetProcessHeap(), 0, ByVal ptr GetUnixPath = sBuffer End Function Sub Main() UnixPath = GetUnixPath() MsgBox UnixPath End usb When running this code I got a blank msgbox can anyone help me please. See you. Escuder Nicolas

2 1

Re bug #8132
by Andrew Talbot 10 May '08

10 May '08

I have marked this bug as fixed, because Alex has written some patches that, indeed, fix it. But these will be held back until after the code freeze, so the bug is still actually present in the current code. Would it be preferable to reopen it, therefore, until the patches are actually applied? Thanks, -- Andy.

3 2

Re: shdocvw: Use array syntax with array elements (Try 2)
by Jacek Caban 10 May '08

10 May '08

Andrew Talbot wrote: > Including some instances that I left out, earlier. > > -- Andy. > --- > Changelog: > shdocvw: Use array syntax with array elements. > Why? Both syntaxes are correct, so it's a matter of style preferences. I prefer the style I use and I don't see any reason to change it. Jacek

2 1

CreateProcess and retrieving stdout and stderr from unix program
by Escuder Nicolas 10 May '08

10 May '08

Hello, Is there a way to retrieve stdout and stderr when lauching unix program with CreateProcess. At this thime I can only get stdout / stderr from windows programs. See You Escuder Nicolas

1 0

Bugs in Wine research
by tomecek＠cs.aau.dk 10 May '08

10 May '08

Hi, we are students from Department of computer science at Aalborg university. During this semester we were working on project on static analysis using the Coccinelle tool (http://www.emn.fr/x-info/coccinelle/) and Flawfinder (http://en.wikipedia.org/wiki/Flawfinder) We decided to search for bugs in Wine source code. Our aim was to find as many bugs in Wine source code as possible but on the other hand to find real and dangerous ones. We solved some of the Janitorial projects and beside that we searched for common bugs. We decided to deal with 2 of Janitorial Projects: Ignored return values and Memory leaks. Beside that searched for memory allocation without NULL checking. Then we ran some more scripts searching for not unlocking memory objects after locking them and searching for untested file descriptors. We also ran two tests looking for not dangerous problems: searching for unused variables and searching for pointers comparison to 0 instead of NULL. All the test were run on Wine 0.9.57 version. In http://www.cs.aau.dk/~tomecek/scripts.tar.gz we present the list of the most obvious bugs in 'diff' format and Coccinelle 'cocci' scripts in Semantic Patch Language (SmPL) used for bug searching. * Ignored return variables We found 115 function callings without checking the returned value which we considered to be possibly dangerous. In many cases we think that the behaviour could be dangerous but we need some information about the code. In 'ignored_return_values.diff' we present some examples of code where the returned value should not be ignored but it is so. * Unused variables This was one of the Janitorial Projects. This issue is not dangerous but it helps to clean the code and make it more readable. All of the variables could be removed using \textit{diff} file. We found 18 matches and all of them were true positives. Beside that we find some possible security bug with 'Flawfinder'. Here is the output: wine-0.9.57/programs/taskmgr/perfdata.c:292: [4] (access) ImpersonateLoggedOnUser: If this call fails, the program could fail to drop heightened privileges. Make sure the return value is checked, and do not continue if a failure is reported. * NULL comparison Sometimes developers use comparison of pointers to zero instead of NULL. This is not critical bug but the \textit{gcc} compiler warns against such using. In this case we were able to change all the zero comparison to NULL variant using Coccinelle. We found 176 matches and all of them were corrected automatically. * Memory allocation Using both functions for memory allocation - 'malloc' and 'HeapAlloc' - requires NULL checking of the returned value to be sure that the allocation was done correctly. We matched 598 possible bugs. In 'memAlloc.diff' we send to you 10 examples of bugs we have found. * Memory leaks This searching was part of one of the Janitorial Projects. We were looking for memory allocations where the pointer to the allocated memory is lost or forgotten without freeing the memory. We matched 13 of them as true positives. In 'memLeaks.diff' we send to you 5 examples of most obvious problems. * Object locking We were searching for locking object with 'GlobalLock()' without 'GlobalUnLock()' for unlocking. If the object was locked then it has to be unlocked to prevent deadlocks when some process or thread is waiting for unlocking of this object. We have 2 true positives. * Descriptors In this test we were looking for unchecked descriptors returned by fopen(), fdopen(), freopen(), open(), creat() and pipe() or for wrong check of this descriptors. fopen(), fdopen() and freopen() functions return in the case of failure 0 but the rest of these functions return -1. Sometimes programmers use it in wrong way and sometimes they do not check it anyway. We matched 3 wrong usings. If you are interested in our work or if you want the full list of bugs we found let us know. Regards, Bertrand Dechoux, Youenn Corre, Jaroslav Tomecek ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

1 0

Another app bundled with Wine: Navicat
by Dan Kegel 09 May '08

09 May '08

http://navicat.com ships a Linux version which is based on Wine from late 2007 and the Picasa wrapper scripts. One more case study for http://kegel.com/wine/isv ... And users are, as usual, confused about whether they need to install Wine to run navicat. See e.g. http://ubuntuforums.org/showthread.php?t=670282 (Installing Wine may actually helped there, because he's on a 64 bit machine, and using aptitude to install wine brought in dependencies that also made Navicat's wine happy.)

1 0

Fixing wintab window messaging, bug 11846. Requesting review
by John Klehm 09 May '08

09 May '08

Hey, Well I'm trying to nail down why sai paint tool isn't doing its pressure stuff and I think this is starting down the right track but I wanted to get some input from those more familiar with wine messaging and x11 events. Without the first patch sai can't find an x11 window to attach too and doesn't have any shot at all at getting pressure events from x11. After that patch is applied it attaches to an x11 window but then doesn't pass the information back to the child window that the wintab context was created in. The second patch implements an EnumChildWindows callback function in order to get it back to the child window. I'm asking for this review as while the above works to get the pressure events flowing I'm not sure if its the appropriate way to go. I believe these patches are on the path to fix http://bugs.winehq.org/show_bug.cgi?id=11846 Thanks, John Klehm

1 0

Re: [1/3] gdiplus: GdipGetImageFlags (bug 12144)
by Maarten Lankhorst 08 May '08

08 May '08

Hello Nikolay, 2008/5/8 Nikolay Sivov <bunglehead(a)gmail.com>: > Maarten Lankhorst wrote: >> >> Hello Nikolay, >> >> 2008/5/8 Nikolay Sivov <bunglehead(a)gmail.com>: >> >>> >>> Changelog: >>> - simple implementation of GdipGetImageFlags >>> >>> --- >>> dlls/gdiplus/gdiplus.spec | 2 +- >>> dlls/gdiplus/gdiplus_private.h | 1 + >>> dlls/gdiplus/image.c | 11 +++++++++++ >>> include/gdiplusenums.h | 25 ++++++++++++++++++++++--- >>> include/gdiplusflat.h | 1 + >>> 5 files changed, 36 insertions(+), 4 deletions(-) >>> >> >> It's better to send changes to the wine headers in wine/include/ >> separately, and to add accompanying testcases when adding new >> functions. This allows us to verify changes more easy. It's a bit more >> work in the short run, but saves time in the long run. >> >> Cheers, >> Maarten. >> >> > > You're right of course (about tests). But it isn't that case: > GdipGetImageFlags just get a member, no more than a return. > So test for it is a redundant (at actual level of gdiplus.dll > implementation). You can still see what happens if you pass it null as argument, what flags are invalid, etc. Cheers, Maarten.

1 0

Re: [3/3] gdiplus: GdipCreateFromHWNDICM (bug 12185)
by Juan Lang 08 May '08

08 May '08

You appear to have sent the wrong patch for this one. --Juan

1 0