May 2008 - Wine-devel - list.winehq.org

re: Vehicle for minor bugs?
by Dan Kegel 05 May '08

05 May '08

Andrew Talbot wrote: > Frequently, I am finding minor bugs that I probably cannot fix myself, that > are probably not suitable for a Bugzilla bug report and that are likely to > be ignored if posted to wine-devel (witness my current postings: "XBOOL, > XBYTE, XINT8, etc." and "Five functions that cannot handle a NULL > parameter", I haven't seen those posts, where are they? I'd say a conformance test would be the right vehicle.

3 2

Re: Jacek Caban : mshtml: Added IMG element tests.
by Alistair Leslie-Hughes 05 May '08

05 May '08

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message news:E1Jszaj-0008Vx-SO(a)wine.codeweavers.com... > Module: wine > Branch: master > Commit: 29d8c366bb278a6b73c3669817063087d7cd080d > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=29d8c366bb278a6b73c366981… > > Author: Jacek Caban <jacek(a)codeweavers.com> > Date: Sun May 4 19:22:46 2008 +0200 > > mshtml: Added IMG element tests. > > --- > > dlls/mshtml/tests/dom.c | 19 +++++++++++++++++-- > 1 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 1039ab5..a3d0701 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -48,6 +48,7 @@ static const char elem_test_str[] = > "<table><tbody></tbody></table>" > "<script id=\"sc\" type=\"text/javascript\"></script>" > "<test />" > + "<img /" ^^^ Is this mssing a ending > Best Regards Alistair Leslie-Hughes

2 1

Time-based releases idea
by Dan Kegel 05 May '08

05 May '08

I just wrote up an idea related to release management for post-1.0 wine releases. It's online at http://wiki.winehq.org/TimeBasedReleases Essentially, the idea is to release in March and September, in time for the April and October releases of Ubuntu. For instance, following this strategy, we might plan to release wine-1.2.0 in September 2008 or March 2009. The alternative is to propose a set of criteria that wine-1.2 needs to meet, and working until they are met, which is what we did for wine-0.9 and wine-1.0 (I think; it's kind of hard to tell). I look forward to discussing this idea... perhaps we shouldn't bother to until after 1.0 is released, but I wanted to get it out early so the discussion can begin in time for us to move on it if we want to. - Dan

10 13

quartz: regression: Assertion failed at pin.c:1236
by Alex Villacís Lasso 05 May '08

05 May '08

The patch: 3066116f76c0c44950fde3552485b37dce24d1f8 quartz: Clean up pullpin code. causes a regression in a test application I have. I see the following message in the console: pin.c:1236: PullPin_Init: La declaración `pCustomRequest' no se cumple. And I get an "Automation error" in a message box. This, every time I try to load an AVI file in a Windows Media Control. Reversing the patch gets rid of the error. I believe this patch was to be followed by a cleanup of code to ensure that no users of PullPin_Init pass a NULL pCustomRequest. However, this parameter gets passed as NULL from parser.c:92, which in turn gets it from avisplit.c, mpegsplit.c and waveparser.c, all of them with NULL as the value for the parameter. Was there supposed to be any follow-up patch for this? Why was it not committed? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: d3dx8: Dynamically import d3dx8 in the tests so the tests can be skipped if the dll is not found
by Paul Vriens 05 May '08

05 May '08

Maarten Lankhorst wrote: > This is better then downright crashing on the missing dlls. > > This patch was created using grep and sed. :-) > --- > > > ------------------------------------------------------------------------ > > Hi Maarten, When do you see a crash? Winetest itself already checks if a dll is present. If it's not, the tests are skipped as can be seen on test.winehq.org.. -- Cheers, Paul.

3 2

[PATCH] Add SIO_KEEPALIVE_VALS support to winsock
by Couriousous 05 May '08

05 May '08

Hello When Altium 6 is used with a license server, it need the WSAIoctl() with SIO_KEEPALIVE_VALS control code to succeed, otherwise it cannot connect to the license server. The following patch implement the missing parts and allow altium 6 to works perfectly with wine ! Regards, Philippe --- Index: dlls/ws2_32/socket.c =================================================================== --- dlls/ws2_32/socket.c +++ dlls/ws2_32/socket.c 2008-05-04 13:53:50.000000000 +0200 @@ -2292,6 +2292,48 @@ WSASetLastError(WSAEOPNOTSUPP); return SOCKET_ERROR; + case WS_SIO_KEEPALIVE_VALS: + if(lpvInBuffer) { + int fd; + struct tcp_keepalive *d = lpvInBuffer; + int idle = d->keepalivetime / 1000; + int interv = d->keepaliveinterval / 1000; + int enable = d->onoff ? 1: 0; + TRACE("socket %04lx, keepalivetime: %d, keepaliveinterval: %d\n", s, idle, interv); + if(idle == 0 || interv == 0) { + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } + fd = get_sock_fd( s, 0, NULL ); + if(setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, (void *) &enable, sizeof(int)) == -1) { + release_sock_fd( s, fd ); + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } +#if (defined TCP_KEEPIDLE) && (defined TCP_KEEPINTVL) + if(setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE, (void *) &idle, sizeof(int)) == -1) { + release_sock_fd( s, fd ); + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } + + if(setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL, (void *) &interv, sizeof(int)) == -1) { + release_sock_fd( s, fd ); + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } +#else + FIXME("Ignoreing keepalive interval and timeout"); +#endif + release_sock_fd( s, fd ); + break; + } else { + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } + + break; + default: FIXME("unsupported WS_IOCTL cmd (%08x)\n", dwIoControlCode); WSASetLastError(WSAEOPNOTSUPP); Index: include/winsock2.h =================================================================== --- include/winsock2.h +++ include/winsock2.h 2008-05-03 22:45:08.000000000 +0200 @@ -142,6 +142,7 @@ #define WS_SIO_ADDRESS_LIST_CHANGE _WSAIO(WS_IOC_WS2,23) #define WS_SIO_QUERY_TARGET_PNP_HANDLE _WSAIOR(WS_IOC_WS2,24) #define WS_SIO_GET_INTERFACE_LIST WS__IOR('t', 127, WS_u_long) +#define WS_SIO_KEEPALIVE_VALS _WSAIOW(WS_IOC_VENDOR,4) #else /* USE_WS_PREFIX */ #undef IOC_VOID #undef IOC_IN @@ -178,8 +179,16 @@ #define SIO_ADDRESS_LIST_CHANGE _WSAIO(IOC_WS2,23) #define SIO_QUERY_TARGET_PNP_HANDLE _WSAIOR(IOC_WS2,24) #define SIO_GET_INTERFACE_LIST _IOR ('t', 127, u_long) +#define SIO_KEEPALIVE_VALS _WSAIOW(IOC_VENDOR,4) #endif /* USE_WS_PREFIX */ +/* Argument structure for SIO_KEEPALIVE_VALS */ +struct tcp_keepalive { + u_long onoff; + u_long keepalivetime; + u_long keepaliveinterval; +}; + /* Constants for WSAIoctl() */ #define WSA_FLAG_OVERLAPPED 0x01 #define WSA_FLAG_MULTIPOINT_C_ROOT 0x02

3 2

Re: d3d8: Dangling pointers fix
by Stefan Dösinger 05 May '08

05 May '08

Am Montag, 5. Mai 2008 17:42:51 schrieb Andrew Talbot: > I have moved the TRACEs to where I think they belong. Please give feedback > if this patch is incorrect. on a quick look it looks OK. Did you check if any output is written in the case of failures in those functions?

2 1

Vehicle for minor bugs?
by Andrew Talbot 05 May '08

05 May '08

Hi, Frequently, I am finding minor bugs that I probably cannot fix myself, that are probably not suitable for a Bugzilla bug report and that are likely to be ignored if posted to wine-devel (witness my current postings: "XBOOL, XBYTE, XINT8, etc." and "Five functions that cannot handle a NULL parameter", and apologies if you are feverishly working on replies or patches for either of these ;) ). For an explicit example - from the later posting - I know that one should be able to call LookupPrivilegeNameW() with its optional "lpName" parameter given a NULL pointer argument, as indeed we do ourselves in advapi32/security:line 1760, but we pass this down, within our rendition of this function, as the first argument to strcpyW() (on line 1852). This is clearly a bug and it seems not to have been spotted by Coverity. The patch I sent for this would appear to have been inadequate, so it would be good if I could flag this bug up on a janitorial page somewhere, perhaps categorized by dll, so that the advapi32 experts (in this case) could occasionally browse for such things. What do people think? Thanks, -- Andy.

1 0

Re: credui: Danish translation
by Robert Shearman 04 May '08

04 May '08

Jens Albretsen wrote: > Changelog: > Danish translation of credui > > +LANGUAGE LANG_DANISH, SUBLANG_DEFAULT > + > +IDD_CREDDIALOG DIALOG DISCARDABLE 0, 0, 213, 149 > +STYLE DS_MODALFRAME | DS_NOIDLEMSG | DS_CENTER | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "IDS_TITLEFORMAT" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL IDB_BANNER,IDC_STATIC,"Statisk",SS_BITMAP | SS_CENTERIMAGE,0, > + 0,213,37 It's an easy mistake to make, but the third piece of data for the CONTROL statement is the name of a Windows class, so it shouldn't be translated. BTW, you can test your translation of credui by running the credui tests with the WINETESTINTERACTIVE environment variable to "1". -- Rob Shearman

1 0

winex11.drv: Set the size of returned DEVMODE to least common one as XP does
by David Adam 04 May '08

04 May '08

Hello >- devmode->dmSize = sizeof(DEVMODEW); >- devmode->dmSpecVersion = MAKEWORD(1,4); >- devmode->dmDriverVersion = MAKEWORD(1,4); >+ devmode->dmSize = FIELD_OFFSET(DEVMODEW, dmICMMethod); >+ devmode->dmSpecVersion = DM_SPECVERSION; >+ devmode->dmDriverVersion = DM_SPECVERSION; Wouldn't it be better to write *devmode->dmDeviceName=*dev_name instead of > memcpy(devmode->dmDeviceName, dev_name, sizeof(dev_name)); David

2 1