May 2008 - Wine-devel - list.winehq.org

Re: [1/3] gdiplus: GdipGetImageFlags (bug 12144)
by Maarten Lankhorst 08 May '08

08 May '08

Hello Nikolay, 2008/5/8 Nikolay Sivov <bunglehead(a)gmail.com>: > Changelog: > - simple implementation of GdipGetImageFlags > > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/gdiplus_private.h | 1 + > dlls/gdiplus/image.c | 11 +++++++++++ > include/gdiplusenums.h | 25 ++++++++++++++++++++++--- > include/gdiplusflat.h | 1 + > 5 files changed, 36 insertions(+), 4 deletions(-) It's better to send changes to the wine headers in wine/include/ separately, and to add accompanying testcases when adding new functions. This allows us to verify changes more easy. It's a bit more work in the short run, but saves time in the long run. Cheers, Maarten.

1 0

Re: inetmib1(0/15)
by Maarten Lankhorst 08 May '08

08 May '08

Hello Juan, 2008/5/8 Juan Lang <juan.lang(a)gmail.com>: > This series of patches implements the inetmib1 dll, mainly to fix bug 13004. I don't see any testcases? With the code freeze I think it is best to add them since it will have more chance of getting accepted. I don't know if it's a good idea otherwise to add code at this point in code freeze. Cheers, Maarten.

2 1

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow
by Alexandre Julliard 08 May '08

08 May '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -1970,7 +1970,7 @@ NTSTATUS WINAPI RtlIntegerToUnicodeString( > } while (value != 0L); > > str->Length = (&buffer[32] - pos) * sizeof(WCHAR); > - if (str->Length >= str->MaximumLength) { > + if (str->Length + sizeof(WCHAR) >= str->MaximumLength) { > return STATUS_BUFFER_OVERFLOW; > } else { > memcpy(str->Buffer, pos, str->Length + sizeof(WCHAR)); There's no overflow here. The Windows implementation of RtlIntegerToUnicodeString seems badly confused but I don't think we need to replicate those bugs. -- Alexandre Julliard julliard(a)winehq.org

3 3

re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow
by Dan Kegel 08 May '08

08 May '08

James wrote: > > It copies str->Length + sizeof(WCHAR) to the destination buffer > > according to james' testcases. > > No, the length is indeterminate. Oh, is that the test that checks whether not double-null terminating works? I think that test needs rewriting to be determinate... e.g. by putting in a list that has known bad (but properly terminated) elements after the nominal end, and making sure the bad part doesn't get processed... or something...

2 1

Re: [PATCH] cmd.exe: MSI packages execution implemented
by Vitaliy Margolen 08 May '08

08 May '08

Vitaly Perov wrote: > Changelog: cmd.exe: MSI packages execution implemented > > > That doesn't look right. You sure this information is hard-coded into cmd.exe and it's not coming from the registry CLASSES hive? Vitaliy

3 2

winetest reports shows a lot of "debugger.c:185:debugger: done debugging..."
by Paul Vriens 08 May '08

08 May '08

Hi, On test.winehq.org one can see that both the W98 and the NT4 reports show a lot of the mentioned lines. For example : http://test.winehq.org/data/200805081000/95_W95/report Any idea where these are coming from? They weren't there before (AFAIK). -- Cheers, Paul.

2 1

Review request: real async for GetAsyncKeyState (bug #5623)
by Rafał Miłecki 08 May '08

08 May '08

Hi, This is my first wine patch and fix for bug #5623. This was tested and works fine however I suspect this is not clean enought for commiting to master. Would be nice if you could review this and tell me what sould be done better (and how?). This patch adds new variable: BYTE global_key_state_table[256]; to wineserver and two new entries in protocol: /* Get global key state */ @REQ(get_global_key_state) int key; /* key */ @REPLY BYTE value; /* status of key */ @END /* Set global key state */ @REQ(set_global_key_state) int key; /* key */ BYTE value; /* status for key */ @END That allows me to keep current *global* state of keyboard. Of course this will works only for wine windows from current wineserver. This was discussed in bug report and it is fine for reported applications. The last think I done is using wineserver in X11DRV_send_keyboard_input -- Rafał Miłecki

2 2

re: winetricks missing MFC42
by Dan Kegel 08 May '08

08 May '08

Cesar wrote: > I see that MFC42 is missing on wine tricks. Nope! It's installed by the vcrun6 verb: echo " vcrun6 vc6redist from VS6sp4 (mfc42, msvcp60, msvcrt)" I've been considering making it more obvious. > There's a cab available from: > http://activex.microsoft.com/controls/vc/mfc42.cab Thanks, nice to have an alternate source.

4 5

Re: mlang: Fix some more tests to pass under windows, try 2
by Dmitry Timoshkov 08 May '08

08 May '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > It disallows certain conversions now. Please don't commit this and other mlang related patches, they are wrong. Maarten, if your only intent is to show clean results under test.winehq.org that's not worth an effort without at least understanding why the test fails and what might be a proper fix for each failure. -- Dmitry.

1 0

Should winedevice.exe in the end be able to load file system drivers as well?
by Paul Vriens 08 May '08

08 May '08

Hi, The comment in winedevice.exe says "Service process to load a kernel driver". But will winedevice.exe in the (far ?) future be the vehicle to load file system drivers as well. -- Cheers, Paul.

2 2